-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass displayed amount to the backend when paying a money request #36904
Conversation
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Code change looks good, I'll have it tested today. |
@mananjadhav bump! 😁 |
Will check this in an hour. |
if this is urgent then I can take it, otherwise I leave it to you @mananjadhav |
Thanks @hungvu193. I am on this right now, it'll be done in 1-2 hours. |
all yours 😄 |
@Gonals I tried a few times, but I didn't get expected behavior that shows the error. Here are two of my tests . Can you confirm if I am missing out something?
same-steps.mp4
altered-steps.mp4 |
Hmmm. The only thing I can think of is that the "Going offline" might not fully mimic being offline. Try: User A invites User B to Free workspace |
Okay and swapping the steps 4 and 5 also shouldn’t have any impact right ? |
@Gonals I tried with full offline too. offline-test_UfrPkZqA.mp4 |
Weird. I'll take another look tomorrow |
Thanks for resolving. I'll take a look at this again. |
Reviewer Checklist
Screenshots/Videos@Gonals I am assuming because this error is from the backend, we won't have any translation for this one now? |
@mananjadhav can you update your checklist? The check is failing with this error:
|
@Gonals can you address @mananjadhav's question about whether we need a translation for the error message? Otherwise I think we're good to merge ✅ |
@blimpich I've completed the whole checklist. Can you please retrigger the action? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.48-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.48-0 🚀
|
Details
Fixed Issues
$ #36440
PROPOSAL:
Tests
Offline tests
Included above
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop