Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Use lowercase "id" for policy object in Onyx #3678

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Jun 18, 2021

Details

Came across this minor inconsistency here for the policy objects in Onyx.

Fixed Issues

No issue

Tests

QA Steps

Nothing to QA yet as nothing is using this data yet AFAIK

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Jun 18, 2021
@marcaaron marcaaron requested a review from a team as a code owner June 18, 2021 17:10
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team June 18, 2021 17:10
@ctkochan22 ctkochan22 merged commit f90328e into main Jun 18, 2021
@ctkochan22 ctkochan22 deleted the marcaaron-standardizeIDForPolicy branch June 18, 2021 17:41
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.71-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants