Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recovery code input fix #36774

Merged
merged 9 commits into from
Mar 13, 2024
Merged

Recovery code input fix #36774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bc076b5
Increase editing space for recovery code
neonbhai Feb 18, 2024
04fb210
Add logic to trim text on input
neonbhai Feb 18, 2024
6465479
Update recovery code trim logic
neonbhai Feb 20, 2024
c6ddf5e
Merge branch 'main' of https://github.com/Expensify/App into recovery…
neonbhai Feb 29, 2024
1dce287
Trim recovery code on text input
neonbhai Feb 29, 2024
3630b1b
Increase editing space for recovery code input
neonbhai Mar 1, 2024
e395de7
Merge branch 'Expensify:main' into recovery-code-input-fix
neonbhai Mar 8, 2024
bba0864
Remove unused const
neonbhai Mar 8, 2024
a5d9fe2
Merge branch 'Expensify:main' into recovery-code-input-fix
neonbhai Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,8 +991,6 @@ const CONST = {
MAGIC_CODE_LENGTH: 6,
MAGIC_CODE_EMPTY_CHAR: ' ',

RECOVERY_CODE_LENGTH: 8,

KEYBOARD_TYPE: {
VISIBLE_PASSWORD: 'visible-password',
ASCII_CAPABLE: 'ascii-capable',
Expand Down
4 changes: 2 additions & 2 deletions src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ function BaseValidateCodeForm({account, credentials, session, autoComplete, isUs
setTwoFactorAuthCode(text);
}
if (key === 'recoveryCode') {
setRecoveryCode(text);
setRecoveryCode(text.trim());
}

setFormError((prevError) => ({...prevError, [key]: undefined}));
Expand Down Expand Up @@ -290,7 +290,7 @@ function BaseValidateCodeForm({account, credentials, session, autoComplete, isUs
accessibilityLabel={translate('recoveryCodeForm.recoveryCode')}
value={recoveryCode}
onChangeText={(text) => onTextInput(text, 'recoveryCode')}
maxLength={CONST.RECOVERY_CODE_LENGTH}
maxLength={CONST.FORM_CHARACTER_LIMIT}
label={translate('recoveryCodeForm.recoveryCode')}
errorText={formError?.recoveryCode ?? ''}
hasError={hasError}
Expand Down
Loading