[No QA] Connect New Workspace Page with the backend #3639
Conversation
src/libs/actions/Policy.js
Outdated
| * @param {String} name | ||
| */ | ||
| function create(name) { | ||
| Policy_Create({type: 'free', policyName: name}) |
There was a problem hiding this comment.
We should use a CONST for this like CONST.POLICY.TYPE.FREE
src/libs/API.js
Outdated
| /** | ||
| * @param {object} parameters | ||
| * @param {string} [parameters.type] | ||
| * @param {string} [parameters.policyName] |
There was a problem hiding this comment.
Capitalize the param types like we do elsewhere?
There was a problem hiding this comment.
Done! I copied those from another comment, so I have also fixed these.
src/languages/es.js
Outdated
| uploadPhoto: 'Subir Foto', | ||
| editPhoto: 'Editar Foto', | ||
| requestCall: 'Concertar una llamada', | ||
| genericFailureMessage: 'Se ha producido un error al intentar crear el Workspace. Por favor intentalo de nuevo.', |
There was a problem hiding this comment.
@HorusGoul do you speak Spanish or is this Google Translate? If it's the latter we should have a Spanish-speaking Expensifier verify that the grammar is good.
There was a problem hiding this comment.
I'm a native speaker! Also, I just sent a commit fixing a typo.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging in version: 1.0.71-1🚀
|
|
@marcaaron Should we halt QAing as this is |
|
Yes please do not QA |
marcaaron
changed the title
|
🚀 Deployed to production in version: 1.0.73-3🚀
|
Details
Removes stuff that won't ship in V1 and connects the form submission with the backend.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/167378
Tests
/workspace/newrouteQA Steps
❌
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android