Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Move reproduction steps above expected/actual results in issue template #3570

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

roryabraham
Copy link
Contributor

Details

The E.cash issue template has been bothering me for a while, the new ordering just makes a lot more sense:

  • What you did
  • What you expected to happen
  • What actually happened

Instead of what we have now, which is more like:

  • What you expected to happen
  • What actually happened
  • Oh yeah, what did you do to make this unexpected thing happen?

Fixed Issues

n/a

Tests

Make a new issue and verify that the changes in the template take effect.

QA Steps

None.

Tested On

n/a – GitHub only.

@roryabraham roryabraham self-assigned this Jun 12, 2021
@roryabraham roryabraham requested a review from a team as a code owner June 12, 2021 17:09
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team June 12, 2021 17:09
@MonilBhavsar MonilBhavsar merged commit 85b22bf into main Jun 14, 2021
@MonilBhavsar MonilBhavsar deleted the Rory-ChangeIssueTemplate branch June 14, 2021 04:47
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor Author

Verified this worked ✅

@roryabraham roryabraham changed the title Move reproduction steps above expected/actual results in issue template [No QA] Move reproduction steps above expected/actual results in issue template Jun 14, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.68-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants