-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close the new chat page when pressing the back button #35568
Close the new chat page when pressing the back button #35568
Conversation
please fix conflict |
@situchan conflicts solved |
Looks like typescript checks failing, could have been a problem with main, can you try pulling main please @bernhardoj ? |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemchrome.moviOS: Nativeios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
@situchan mind moving forward with testing this PR? 🙏 and @bernhardoj can you please merge main again so we're sure we're testing on latest main? |
Merged with main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.44-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|
Details
When pressing the back button on new chat page, it will go back to the previous tab instead of closing the page.
Fixed Issues
$ #35143
PROPOSAL: #35143 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-02-01.at.23.34.23.mov
Android: mWeb Chrome
Screen.Recording.2024-02-01.at.23.33.00.mov
iOS: Native
Screen.Recording.2024-02-01.at.23.32.33.mov
iOS: mWeb Safari
Screen.Recording.2024-02-01.at.23.33.41.mov
MacOS: Chrome / Safari
Screen.Recording.2024-02-01.at.23.03.59.mov
MacOS: Desktop
Screen.Recording.2024-02-01.at.23.31.15.mov