Input inline tracking #35149

perunt · 2024-01-25T13:26:50Z

it's patch of:
facebook/react-native#38110
facebook/react-native#36979

❗ Native mobile only❗

Details

With this PR, the onSelectionChange method will now return the cursor position alongside the start and end positions, as follows:

selection: {
    start: number,
    end: number,
    cursorPosition: {
        start: {x: number, y: number},
        end: {x: number, y: number}
    }
}

The cursorPosition object contains the coordinates of the top left corner (start) and the bottom right corner (end) of the cursor or selected text.

Fixed Issues

$ #16078 (comment)
PROPOSAL:

Tests

put this:

<View style={{height: 10, width: 10, backgroundColor: 'red', position: 'absolute', top: Number(selection.cursorPosition?.end?.y), left: Number(selection.cursorPosition?.end?.x)}} />

next to Composer element https://github.com/Expensify/App/blob/17efef8020a0ad2e9cfd7c52f8bf62c08e2d9db0/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js#L573C18-L573C19

Test if the red square follows the cursor.
NOTE: This red square does not include the maximum available height of the input. So if you reach the end, it will move away from the screen

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

2024-01-25.14.28.47.mp4

Android: mWeb Chrome

iOS: Native

2024-01-25.14.31.30.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…nput-inline-tracking

melvin-bot · 2024-01-25T14:15:48Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2024-01-30T15:23:24Z

I tried to review the PR, reading native code but I couldn't understand them thoroughly. Seeking help on Slack https://expensify.slack.com/archives/C02NK2DQWUX/p1706627905939359

hoangzinh · 2024-01-30T15:24:44Z

@puneetlath when you're back, could you help to assign this PR to @allroundexperts as a C+? Thanks

allroundexperts · 2024-01-30T22:37:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-09.at.2.51.01.AM.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-02-07.at.1.23.59.PM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allroundexperts · 2024-01-31T21:09:56Z

Still reviewing.

perunt · 2024-02-06T18:52:32Z

@allroundexperts, do you need any help here?

allroundexperts · 2024-02-07T07:12:35Z

@perunt Apologies for the delay here. I was just trying to follow the conversation in the RN repository around this PR. I'll complete the review today.

allroundexperts · 2024-02-07T08:45:14Z

@perunt I was able to test this on iOS, but on Android, the red marker never shows up. I ran npm run android several times after clearing the build folder, but the cursor object is still undefined. Do you have an idea of what might be wrong?

patches/react-native+0.73.2+002+inputInlineTracking.patch

perunt · 2024-02-08T07:57:44Z

@allroundexperts can you double-check if the patch was applied for an Android part?

allroundexperts

Looks good!

perunt · 2024-02-14T07:38:30Z

❗ ❗ ❗ We're waiting for fixing https://expensify.slack.com/archives/C01GTK53T8Q/p1707846163324679. Currently on hold ❗ ❗ ❗

…nput-inline-tracking

perunt · 2024-02-26T11:08:08Z

UPDATE: This PR can be reviewed/merged even without this fix (https://expensify.slack.com/archives/C01GTK53T8Q/p1707846163324679), as we already have this code in the main branch and it doesn't introduce any inconsistency. This PR won't break anything, so we're good to go.

@allroundexperts i've added optional chaining as you suggested

perunt · 2024-02-27T16:20:36Z

@allroundexperts @puneetlath, can we merge it?

allroundexperts · 2024-02-27T16:24:58Z

I've approved already. This tested well for me.

allroundexperts · 2024-02-27T18:08:00Z

I'll do a sanity check tomorrow morning again if that is fine.

puneetlath · 2024-04-23T16:08:49Z

I'm going to close this out since I believe we've decided to go a different route.

perunt added 3 commits January 22, 2024 10:17

Merge branch 'main' of https://github.com/Expensify/App into perunt/i…

56fcf98

…nput-inline-tracking

Merge branch 'main' of https://github.com/Expensify/App into perunt/i…

c0d7d6b

…nput-inline-tracking

patch mobile

2ed541b

perunt marked this pull request as ready for review January 25, 2024 14:15

perunt requested a review from a team as a code owner January 25, 2024 14:15

melvin-bot bot removed the request for review from a team January 25, 2024 14:15

melvin-bot bot requested a review from hoangzinh January 25, 2024 14:15

puneetlath requested a review from allroundexperts January 30, 2024 16:08

allroundexperts reviewed Feb 7, 2024

View reviewed changes

patches/react-native+0.73.2+002+inputInlineTracking.patch Show resolved Hide resolved

allroundexperts approved these changes Feb 8, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath February 8, 2024 22:04

dangrous mentioned this pull request Feb 12, 2024

[HOLD #16078] Chat - Disappears popup mentioning @here when clicking outside the compos box #20128

Closed

6 tasks

perunt added 3 commits February 22, 2024 10:47

Merge branch 'main' of https://github.com/Expensify/App into perunt/i…

5f26f38

…nput-inline-tracking

add optional chaining for cursorPosition

f98c2cb

more optional chaining

e7c1474

perunt mentioned this pull request Feb 27, 2024

Inline suggestion #36239

Closed

50 tasks

puneetlath closed this Apr 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Input inline tracking #35149

Input inline tracking #35149

perunt commented Jan 25, 2024 •

edited

Loading

melvin-bot bot commented Jan 25, 2024

hoangzinh commented Jan 30, 2024

hoangzinh commented Jan 30, 2024

allroundexperts commented Jan 30, 2024 •

edited

Loading

allroundexperts commented Jan 31, 2024

perunt commented Feb 6, 2024

allroundexperts commented Feb 7, 2024

allroundexperts commented Feb 7, 2024

perunt commented Feb 8, 2024

allroundexperts left a comment

perunt commented Feb 14, 2024

perunt commented Feb 26, 2024

perunt commented Feb 27, 2024

allroundexperts commented Feb 27, 2024

allroundexperts commented Feb 27, 2024

puneetlath commented Apr 23, 2024

Input inline tracking #35149

Input inline tracking #35149

Conversation

perunt commented Jan 25, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 25, 2024

hoangzinh commented Jan 30, 2024

hoangzinh commented Jan 30, 2024

allroundexperts commented Jan 30, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Jan 31, 2024

perunt commented Feb 6, 2024

allroundexperts commented Feb 7, 2024

allroundexperts commented Feb 7, 2024

perunt commented Feb 8, 2024

allroundexperts left a comment

Choose a reason for hiding this comment

perunt commented Feb 14, 2024

perunt commented Feb 26, 2024

perunt commented Feb 27, 2024

allroundexperts commented Feb 27, 2024

allroundexperts commented Feb 27, 2024

puneetlath commented Apr 23, 2024

perunt commented Jan 25, 2024 •

edited

Loading

allroundexperts commented Jan 30, 2024 •

edited

Loading