Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about internationalization / localization #3444

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Add info about internationalization / localization #3444

merged 2 commits into from
Jun 11, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Jun 8, 2021

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/152157

Tests

No

QA Steps

No

@iwiznia iwiznia requested a review from a team June 8, 2021 21:38
@iwiznia iwiznia self-assigned this Jun 8, 2021
@MelvinBot MelvinBot requested review from tgolen and removed request for a team June 8, 2021 21:38
@iwiznia iwiznia requested a review from a team as a code owner June 8, 2021 21:44
@MelvinBot MelvinBot requested review from AndrewGable and removed request for a team June 8, 2021 21:45
@iwiznia
Copy link
Contributor Author

iwiznia commented Jun 11, 2021

OH Tim is ooo

@iwiznia iwiznia merged commit 19ad75e into main Jun 11, 2021
@iwiznia iwiznia deleted the ionatan_i18nreadme branch June 11, 2021 17:08
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jun 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.68-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

@tgolen tgolen Awaiting requested review from tgolen

Assignees

@iwiznia iwiznia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwiznia @OSBotify @AndrewGable