Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "[NO QA] Remove areChatRoomsEnabled checks" #34311

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[CP Staging] Revert "[NO QA] Remove areChatRoomsEnabled checks" #34311

merged 1 commit into from
Jan 11, 2024

Conversation

thienlnam
Copy link
Contributor

Reverts #34046

@thienlnam thienlnam marked this pull request as ready for review January 11, 2024 05:18
@thienlnam thienlnam requested a review from a team as a code owner January 11, 2024 05:18
@melvin-bot melvin-bot bot requested review from Gonals and removed request for a team January 11, 2024 05:18
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 11, 2024

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@situchan situchan mentioned this pull request Jan 11, 2024
Merged
50 tasks
@yuwenmemon
Copy link
Contributor

Straight revert so merging with failing tests

@yuwenmemon yuwenmemon merged commit 778eee5 into main Jan 11, 2024
11 of 15 checks passed
@yuwenmemon yuwenmemon deleted the revert-34046-ionatan_killareChatRoomsEnabled branch January 11, 2024 05:57
@melvin-bot melvin-bot bot added the Emergency label Jan 11, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 11, 2024

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@thienlnam thienlnam changed the title Revert "[NO QA] Remove areChatRoomsEnabled checks" [CP Staging] Revert "[NO QA] Remove areChatRoomsEnabled checks" Jan 11, 2024
OSBotify pushed a commit that referenced this pull request Jan 11, 2024
@yuwenmemon @OSBotify
Merge pull request #34311 from Expensify/revert-34046-ionatan_killare…
906c004 
…ChatRoomsEnabled

Revert "[NO QA] Remove areChatRoomsEnabled checks"

(cherry picked from commit 778eee5)
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Closed
54 tasks
@thienlnam thienlnam mentioned this pull request Jan 11, 2024
Closed
6 tasks
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.24-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.24-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@jasperhuangg jasperhuangg mentioned this pull request Jan 23, 2024
Closed
@iwiznia iwiznia mentioned this pull request Feb 1, 2024
Merged
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenmemon yuwenmemon yuwenmemon approved these changes

@Gonals Gonals Awaiting requested review from Gonals

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thienlnam @yuwenmemon @OSBotify