-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'MoneyRequestHeader.js' component to TypeScript #34106
[TS migration] Migrate 'MoneyRequestHeader.js' component to TypeScript #34106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 😄
2399d5e
to
d45b5e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…eader-to-typescript # Conflicts: # src/libs/HeaderUtils.ts
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…eader-to-typescript
…eader-to-typescript
Performance tests are failing. Could you please take a look |
Reviewer Checklist
Screenshots/VideosAndroid: NativeIssue with android emulatorAndroid: mWeb ChromeIssue with android emulator |
…eader-to-typescript # Conflicts: # src/components/MoneyRequestHeader.tsx
@MonilBhavsar Feedback applied! Thank you and have fun 😄 |
Bump @MonilBhavsar |
Oops sorry, I'll take a look today. |
…eader-to-typescript # Conflicts: # src/components/MoneyRequestHeader.tsx
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.39-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.39-8 🚀
|
Details
Fixed Issues
$#25111
PROPOSAL:
N/A
Tests
( + )
button and selectRequest money
Request money
panel on the right of the screen, selectmanual
optionNext
cash
that is owedcash
message and you'll be redirected to a page with the money request detailspin
,add receipt
,delete request
) works correctlyOffline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop