No emoji list after expanding/collapsing #33707

ZhenjaHorbach · 2023-12-28T12:05:08Z

No emoji list after expanding

Details

No emoji list after expanding

Fixed Issues

$ #32740
PROPOSAL: #32740 (comment)

Tests

Go to any chat
Type multiline message
Type : and any incomplete emoji name
Click on the expand/collapse icon
Verify a emoji list reopens

Verify that no errors appear in the JS console

Offline tests

Go to any chat
Type multiline message
Type : and any incomplete emoji name
Click on the expand/collapse icon
Verify a emoji list reopens

QA Steps

Go to any chat
Type multiline message
Type : and any incomplete emoji name
Click on the expand/collapse icon
Verify a emoji list reopens

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2023-12-28T12:05:13Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2023-12-28T12:10:41Z

@parasharrajat

Hello )
PR is ready )

Plus I remember that you had an idea not to close the popup
I have an idea how to do this

If you want to take a look, I can commit these changes
And if you like it, we can leave the changes

But if you like the current implementation
We can move on))

parasharrajat · 2023-12-28T13:00:51Z

@ZhenjaHorbach I didn't understand your previous comment.

Let's remove the extra code responsible for hiding or closing the popup which is not needed now e.g.

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js

Line 220 in 6cff8ba

updateShouldShowSuggestionMenuToFalse();

.

Please review the code and make changes accordingly.

ZhenjaHorbach · 2023-12-28T13:07:13Z

@parasharrajat
If we just remove this code
Then the popup will not change its position
That's why I say we need to make a little more changes.

Screen.Recording.2023-12-28.at.16.04.20.mov

But okay
If we decide to remove this code, then I'll now make a few additional changes

ZhenjaHorbach · 2023-12-28T14:22:52Z

@parasharrajat

I updated the code and videos )
Ready for review )

parasharrajat · 2023-12-30T10:57:04Z

Let's remove the new prop changes for repositioning the suggestions. I think it would be better to update the measureContainer callback which is directly linked to the position of the autocomplete suggestion menu.

To do this we can add isComposerFullSize as a dependency to

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Lines 203 to 208 in 8cb48e4

    
           const measureContainer = useCallback((callback) => { 
        
               if (!containerRef.current) { 
        
                   return; 
        
               } 
        
               containerRef.current.measureInWindow(callback); 
        
           }, []);

Also, add an explanation as a comment on why we did this.

ZhenjaHorbach · 2023-12-30T11:11:22Z

Let's remove the new prop changes for repositioning the suggestions. I think it would be better to update the measureContainer callback which is directly linked to the position of the autocomplete suggestion menu.

To do this we can add isComposerFullSize as a dependency to

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Lines 203 to 208 in 8cb48e4

const measureContainer = useCallback((callback) => {

if (!containerRef.current) {

return;

}

containerRef.current.measureInWindow(callback);

}, []);

Also, add an explanation as a comment on why we did this.

Hmm
Good catch )
This works the same way)

parasharrajat · 2023-12-30T12:07:27Z

I noticed that menu is not opening while expanding on iOS:Safari. Use Virtual Keyboard to test. Same on Android.

Screen.Recording.2023-12-30.at.5.35.23.PM.mov

ZhenjaHorbach · 2023-12-30T15:03:43Z

@parasharrajat
I fixed this problem

The problem was related to the fact that when we collapse and expand the input
There are cases when the scroll is triggered, which causes the closure of all popups

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js

Line 593 in 8cb48e4

onScroll={hideSuggestionMenu}

But fortunately, we have similar cases to disable closing popups while scrolling using isScrollLikelyLayoutTriggered

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js

Line 411 in 8cb48e4

if (!suggestionsRef.current || isScrollLikelyLayoutTriggered.current) {

So I moved this logic into the parent component
So that we can turn on this flag when pressing expanding/collapsing

And since all components are used in one copy
I don't think it's a bad idea to move the logic to the parent component

Or I can create similar logic for parent component and don't move isScrollLikelyLayoutTriggered functionality

parasharrajat · 2023-12-30T17:17:01Z

...ages/home/report/ReportActionCompose/ComposerWithSuggestions/composerWithSuggestionsProps.js

+    /** A flag to indicate whether the onScroll callback is likely triggered by a layout change (caused by text change) or not */
+    isScrollLikelyLayoutTriggered: PropTypes.bool,


Why ?)
Or you mean we need set PropTypes.bool.isRequired here ?)

you are passing the ref directly to this prop which is an object.

Oh, yeah )
Sorry
You are right

ZhenjaHorbach · 2024-01-02T07:42:57Z

@parasharrajat
Hello )
Friendly bump )

parasharrajat · 2024-01-02T10:50:04Z

Screenshots

🔲 iOS / native

Screen.Recording.2024-01-02.at.4.16.56.PM.mov

🔲 iOS / Safari

Screen.Recording.2024-01-02.at.3.59.32.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2024-01-02.at.4.03.08.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2024-01-02.at.3.30.51.PM.mov

🔲 Android / Chrome

Screen.Recording.2024-01-02.at.3.58.46.PM.mov

🔲 Android / native

Screen.Recording.2024-01-02.at.4.17.46.PM.mov

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2024-01-02T15:50:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-02T23:52:25Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T18:55:01Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T19:19:51Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T20:17:18Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Fix bug with No emoji list after expanding

965f2b5

ZhenjaHorbach requested a review from a team as a code owner December 28, 2023 12:05

melvin-bot bot requested review from parasharrajat and removed request for a team December 28, 2023 12:05

ZhenjaHorbach added 3 commits December 28, 2023 16:58

Update fix

d185bf7

Fix eslint issues

dd292b4

Update AutoCompleteSuggestions

ea6346d

Update fix

acf2db6

Merge branch 'main' into no-emoji-list-after-expanding

28b86ed

ZhenjaHorbach added 3 commits December 30, 2023 17:37

Fix bug with closing popups for mobile

44ab91f

Fix prettier issues

2488eb7

Fix eslint issues

7e37ba9

parasharrajat reviewed Dec 30, 2023

View reviewed changes

ZhenjaHorbach added 2 commits December 30, 2023 20:31

Fix type issue

5978ea3

Merge branch 'main' into no-emoji-list-after-expanding

ed1d784

parasharrajat approved these changes Jan 2, 2024

View reviewed changes

melvin-bot bot requested a review from Beamanator January 2, 2024 10:50

Beamanator approved these changes Jan 2, 2024

View reviewed changes

Beamanator merged commit d831d77 into Expensify:main Jan 2, 2024
16 checks passed

github-actions bot mentioned this pull request Jan 2, 2024

Deploy Checklist: New Expensify 2024-01-02 #33855

Closed

58 tasks

melvin-bot bot mentioned this pull request Jan 4, 2024

[HOLD for payment 2024-01-11] [$500] Chat - No emoji list after expanding composer and hitting Enter still selects the emoji #32740

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

No emoji list after expanding/collapsing #33707

No emoji list after expanding/collapsing #33707

ZhenjaHorbach commented Dec 28, 2023 •

edited

Loading

melvin-bot bot commented Dec 28, 2023

ZhenjaHorbach commented Dec 28, 2023 •

edited

Loading

parasharrajat commented Dec 28, 2023 •

edited

Loading

ZhenjaHorbach commented Dec 28, 2023

ZhenjaHorbach commented Dec 28, 2023

parasharrajat commented Dec 30, 2023 •

edited

Loading

ZhenjaHorbach commented Dec 30, 2023

parasharrajat commented Dec 30, 2023 •

edited

Loading

ZhenjaHorbach commented Dec 30, 2023 •

edited

Loading

parasharrajat Dec 30, 2023

ZhenjaHorbach Dec 30, 2023

parasharrajat Dec 30, 2023

ZhenjaHorbach Dec 30, 2023

ZhenjaHorbach commented Jan 2, 2024

parasharrajat commented Jan 2, 2024

parasharrajat left a comment

OSBotify commented Jan 2, 2024

OSBotify commented Jan 2, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

		/** A flag to indicate whether the onScroll callback is likely triggered by a layout change (caused by text change) or not */
		isScrollLikelyLayoutTriggered: PropTypes.bool,

No emoji list after expanding/collapsing #33707

No emoji list after expanding/collapsing #33707

Conversation

ZhenjaHorbach commented Dec 28, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 28, 2023

ZhenjaHorbach commented Dec 28, 2023 • edited Loading

parasharrajat commented Dec 28, 2023 • edited Loading

ZhenjaHorbach commented Dec 28, 2023

ZhenjaHorbach commented Dec 28, 2023

parasharrajat commented Dec 30, 2023 • edited Loading

ZhenjaHorbach commented Dec 30, 2023

parasharrajat commented Dec 30, 2023 • edited Loading

ZhenjaHorbach commented Dec 30, 2023 • edited Loading

parasharrajat Dec 30, 2023

Choose a reason for hiding this comment

ZhenjaHorbach Dec 30, 2023

Choose a reason for hiding this comment

parasharrajat Dec 30, 2023

Choose a reason for hiding this comment

ZhenjaHorbach Dec 30, 2023

Choose a reason for hiding this comment

ZhenjaHorbach commented Jan 2, 2024

parasharrajat commented Jan 2, 2024

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

OSBotify commented Jan 2, 2024

OSBotify commented Jan 2, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

ZhenjaHorbach commented Dec 28, 2023 •

edited

Loading

ZhenjaHorbach commented Dec 28, 2023 •

edited

Loading

parasharrajat commented Dec 28, 2023 •

edited

Loading

parasharrajat commented Dec 30, 2023 •

edited

Loading

parasharrajat commented Dec 30, 2023 •

edited

Loading

ZhenjaHorbach commented Dec 30, 2023 •

edited

Loading