Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: PDF is not cached #32678

Merged
merged 18 commits into from
Feb 28, 2024
Merged

Fix: PDF is not cached #32678

Changes from 3 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6749e0a
fix: pdf not cached
tienifr Dec 7, 2023
0624e89
fix lint
tienifr Dec 7, 2023
552592c
fix lint
tienifr Dec 7, 2023
ad010da
Merge branch 'main' of https://github.com/tienifr/App into fix/32232
tienifr Dec 11, 2023
7ef7951
Merge branch 'main' of https://github.com/tienifr/App into fix/32232
tienifr Dec 28, 2023
eff555e
Merge branch 'main' of https://github.com/tienifr/App into fix/32232
tienifr Jan 24, 2024
35c7989
remove cached file when delete comment
tienifr Jan 24, 2024
f296a75
Merge branch 'main' into fix/32232
tienifr Jan 25, 2024
0d97aef
Merge branch 'main' of https://github.com/tienifr/App into fix/32232
tienifr Jan 26, 2024
6981075
resolve comments
tienifr Jan 26, 2024
5baa4b8
Merge branch 'main' into fix/32232
tienifr Feb 5, 2024
9379469
seperate platform logic
tienifr Feb 5, 2024
6eb146a
add types for CachedPDFPaths
tienifr Feb 5, 2024
e3c7d72
Merge branch 'main' into fix/32232
tienifr Feb 23, 2024
55884df
fix lint
tienifr Feb 23, 2024
adfae33
Merge branch 'main' of https://github.com/tienifr/App into fix/32232
tienifr Feb 26, 2024
f7ed37e
remove redundant condition
tienifr Feb 26, 2024
abd5347
delete cache for transaction receipt
tienifr Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/PDFView/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ class PDFView extends Component {
fitPolicy={0}
trustAllCerts={false}
renderActivityIndicator={() => <FullScreenLoadingIndicator />}
source={{uri: this.props.sourceURL}}
source={{uri: this.props.sourceURL, cache: true, expiration: 864000}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tienifr I think we should raise a discussion for the expiration interval. IMO 12 hours should be good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised discussion on Slack.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another question: will the cache be removed when attachment is deleted from the chat?

Copy link
Contributor Author

@tienifr tienifr Dec 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will the cache be removed when attachment is deleted from the chat

Seems like it does not. But it still gets removed when we logged out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it does not. But it still gets removed when we logged out.

We should clear the cache when the attachment is deleted, and i am not sure how this will work incase of protected pdf i am checking.

style={pdfStyles}
onError={this.handleFailureToLoadPDF}
password={this.state.password}
Expand Down
Loading