feat: app sounds #31055

lauridskern · 2023-11-08T10:20:58Z

Details

This PR implements sounds playing when message gets received (only when app is in foreground, i. e. not sounds for push notifications).

To play a sound I used react-native-sound ( and react-native-web-sound for web, underhood it uses howler.js). Initially I wanted to use expo-sound but was getting ridiculous errors and couldn't resolve them (on iOS and web).

Fixed Issues

$ #29835
PROPOSAL: N/A

Tests

Open app on two devices
Send message from one device to another

Done sound -> when user sends a message/emoji/attachment/assigning task/sends money/request money (i. e. if user sends any content to another user we play done sound);
Success sound -> when someone completes task/someone completes money request/someone sends money to you (regardless of who marks the task as done, i. e. sender or receiver);
Attention sound -> someone mentioned you/someone request money from you/someone assigns a task to you (@here also should produce the sound);
Received sound -> when message (excluding success/attention cases from above) received

go to setting and mute all sounds
verify step 2 but be sure there is no audio actually played
unmute sounds in app setting
go to a particular channel -> open settings of this channel -> open "Notify me about new messages" -> set it to "Mute"
verify step 2 but be sure there is no audio actually played (excluding "done" case - "done" sound should be played in any case).
set "Daily" mode and repeat step 2 - be sure that all sounds are playable
set "Immediately" mode and repeat step 2 - be sure that all sounds are playable
mute sound in app settings and for channel - be sure that step 2 will not play any sound at all

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open app on two devices
Send message from one device to another

Done sound -> when user sends a message/emoji/attachment/assigning task/sends money/request money (i. e. if user sends any content to another user we play done sound);
Success sound -> when someone completes task/someone completes money request/someone sends money to you (regardless of who marks the task as done, i. e. sender or receiver);
Attention sound -> someone mentioned you/someone request money from you/someone assigns a task to you (@here also should produce the sound);
Received sound -> when message (excluding success/attention cases from above) received

go to setting and mute all sounds
verify step 2 but be sure there is no audio actually played

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-demo-sound-truncated.mp4

Android: mWeb Chrome

iOS: Native

iOS-sound-demo.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web-sound-demo.mov

MacOS: Desktop

desktop-demo-sounds.mov

github-actions · 2023-11-08T10:21:14Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

mountiny · 2023-11-30T19:57:17Z

@lauridskern can you please comment signing the CLA as instructed? i will try to rerun the job

lauridskern · 2023-11-30T20:11:59Z

I have read the CLA Document and I hereby sign the CLA

lauridskern · 2023-11-30T20:12:13Z

recheck

mountiny · 2023-12-01T12:26:07Z

@lauridskern CLA passing now, thanks!

lauridskern · 2023-12-01T12:32:37Z

Awesome! Thanks for your assistance

melvin-bot · 2023-12-06T20:24:53Z

@shawnborton @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2023-12-08T14:11:26Z

Hmm, QR build seems to be failed

@lauridskern please fix conflict

melvin-bot · 2023-12-22T14:09:37Z

@shawnborton @thesahindia @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2023-12-22T14:10:08Z

@aimane-chnaif can you please review this?

I added puller bear and it also assigned @thesahindia - whoever can prioritize this, please help us get this merged. Thanks!

aimane-chnaif · 2023-12-22T14:20:10Z

yes, was waiting for conflict to be fixed. 4.7k commits are behind

shawnborton · 2024-01-04T09:11:27Z

Hi there, can we please try to move this one forward?

aimane-chnaif · 2024-01-05T19:34:28Z

@lauridskern bump for fixing conflict

cristipaval

Code looks great. One mention though: Is there a reason why you didn't create connstants for 'done', 'success' and the other sounds?

Also, question for @shawnborton: Shouldn't we also save the muted settings from Preferences as an account NVP in the backend? Do we want this to be a device specific setting?

cristipaval · 2024-02-12T12:27:19Z

@hannojg, I see that you have change requests. Are they resolved?

cristipaval · 2024-02-12T12:30:05Z

Also, question for @shawnborton: Shouldn't we also save the muted settings from Preferences as an account NVP in the backend? Do we want this to be a device specific setting?

I went through the conversation on the issue, and it seems that we are testing different sounds for now, so I think it makes sense to let this one a device-specific setting with no BE changes, at least for now.

kirillzyusko · 2024-02-12T13:03:01Z

I went through the conversation on the #29835, and it seems that we are testing different sounds for now, so I think it makes sense to let this one a device-specific setting with no BE changes, at least for now.

@cristipaval yes, you are right - for now I think we want this feature to keep it as simple as possible, so we didn't involve BE yet

One mention though: Is there a reason why you didn't create connstants for 'done', 'success' and the other sounds?

Yes, sure, I can create constants - I'll push a new commit soon 👍

hannojg · 2024-02-12T13:10:44Z

Yes, all resolved 😊

shawnborton · 2024-02-12T13:34:48Z

Shouldn't we also save the muted settings from Preferences as an account NVP in the backend? Do we want this to be a device specific setting?

Agree that this particular preference wouldn't be device specific, given that when you mute a channel you mute it everywhere and not just your local device.

cristipaval · 2024-02-12T14:16:27Z

Shouldn't we also save the muted settings from Preferences as an account NVP in the backend? Do we want this to be a device specific setting?

Agree that this particular preference wouldn't be device specific, given that when you mute a channel you mute it everywhere and not just your local device.

@shawnborton this PR persists the settings locally on the device only. We need backend support to persist the setting for the account accros different devices. We can merge this one as it is and open a follow-up PR to save the setting on the backend, given that it's been open for a while already. What do you think?

shawnborton · 2024-02-12T14:30:21Z

Ah, I was mostly thinking that we already save a user's preference for muting rooms across devices, right? So we could just use that to inform whether or not sounds should play if the user has sounds enabled but the room is muted.

Otherwise I think it's fine that we use local preferences for sound given that you might want sound on your desktop app but not mobile for instance.

cristipaval · 2024-02-12T14:44:17Z

Ah, I was mostly thinking that we already save a user's preference for muting rooms across devices, right? So we could just use that to inform whether or not sounds should play if the user has sounds enabled but the room is muted.

yes, this is already in place.

Otherwise I think it's fine that we use local preferences for sound given that you might want sound on your desktop app but not mobile for instance.

alright, yes, it makes sense 👍

Thanks!

cristipaval · 2024-02-12T14:52:04Z

One mention though: Is there a reason why you didn't create connstants for 'done', 'success' and the other sounds?

Yes, sure, I can create constants - I'll push a new commit soon 👍

Ok, so this is good to merge once you create constants @kirillzyusko

kirillzyusko · 2024-02-12T15:03:10Z

@cristipaval done 👍

cristipaval

Thanks!

cristipaval · 2024-02-12T15:40:08Z

DANG! it has conflicts. Could you please resolve them, @kirillzyusko 🙏

kirillzyusko · 2024-02-12T15:42:11Z

@cristipaval sure, I'm on it 👀

…imation-and-sound

kirillzyusko · 2024-02-12T15:48:41Z

@cristipaval merged upstream 👍

shawnborton · 2024-02-12T16:12:11Z

I think you mean @cristipaval :)

kirillzyusko · 2024-02-12T16:15:54Z

@shawnborton you are absolutely right, @christianwen sorry for disturbing you 😅

@cristipaval can we merge this PR? 👀

cristipaval · 2024-02-12T16:19:09Z

Merged 🚀

Thanks for the work here! 🙏

OSBotify · 2024-02-12T16:21:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-15T05:23:01Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

situchan · 2024-03-15T00:17:07Z

src/libs/actions/User.ts

+    });
+
+function playSoundForMessageType(pushJSON: OnyxServerUpdate[]) {
+    const reportActionsOnly = pushJSON.filter((update) => update.key.includes('reportActions_'));


There's case of key not existing in update, which lead to #36632.
i.e. CloseAccount pusher event

feat: add animated splash screen

594d0c8

lauridskern force-pushed the origin/feat/update-loading-screen-to-play-animation-and-sound branch from c4c87c3 to 594d0c8 Compare December 6, 2023 14:57

fix: indents

67923f1

lauridskern marked this pull request as ready for review December 6, 2023 20:24

lauridskern requested a review from a team as a code owner December 6, 2023 20:24

melvin-bot bot requested review from aimane-chnaif and shawnborton and removed request for a team December 6, 2023 20:24

shawnborton added the Ready To Build label Dec 7, 2023

lauridskern added 3 commits December 19, 2023 13:21

feat: select random video each time

087ca99

feat: randomize video and show last shown splash video in dev settings

5b9a1ff

Add MenuItemWithTopDescription component to TestToolMenu

1adb767

shawnborton requested a review from a team December 22, 2023 14:09

melvin-bot bot removed the request for review from a team December 22, 2023 14:09

melvin-bot bot requested a review from thesahindia December 22, 2023 14:09

shawnborton removed the Ready To Build label Dec 22, 2023

remove old splashscreen hider component

d2fa21f

cristipaval reviewed Feb 12, 2024

View reviewed changes

kirillzyusko added 2 commits February 12, 2024 16:00

refactor: added dictionary for playing a sound

1e828f6

fix: changes after code review

7ed56ec

cristipaval previously approved these changes Feb 12, 2024

View reviewed changes

Merge branch 'main' into origin/feat/update-loading-screen-to-play-an…

748d554

…imation-and-sound

kirillzyusko dismissed cristipaval’s stale review via 748d554 February 12, 2024 15:48

cristipaval approved these changes Feb 12, 2024

View reviewed changes

cristipaval merged commit 9c8d7d2 into Expensify:main Feb 12, 2024
18 checks passed

github-actions bot mentioned this pull request Feb 13, 2024

Deploy Checklist: New Expensify 2024-02-13 #36429

Closed

ikevin127 mentioned this pull request Feb 14, 2024

[$500] Unable to mute all sounds on App #36455

Closed

6 tasks

dangrous mentioned this pull request Feb 14, 2024

Preferences - Mute all sounds from Expensify toggle does not update on secondary device #36487

Closed

6 tasks

situchan reviewed Mar 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: app sounds #31055

feat: app sounds #31055

lauridskern commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023 •

edited

Loading

mountiny commented Nov 30, 2023

lauridskern commented Nov 30, 2023

lauridskern commented Nov 30, 2023

mountiny commented Dec 1, 2023

lauridskern commented Dec 1, 2023

melvin-bot bot commented Dec 6, 2023

aimane-chnaif commented Dec 8, 2023

melvin-bot bot commented Dec 22, 2023

shawnborton commented Dec 22, 2023

aimane-chnaif commented Dec 22, 2023 •

edited

Loading

shawnborton commented Jan 4, 2024

aimane-chnaif commented Jan 5, 2024

cristipaval left a comment

cristipaval commented Feb 12, 2024

cristipaval commented Feb 12, 2024 •

edited

Loading

kirillzyusko commented Feb 12, 2024

hannojg commented Feb 12, 2024

shawnborton commented Feb 12, 2024

cristipaval commented Feb 12, 2024

shawnborton commented Feb 12, 2024

cristipaval commented Feb 12, 2024

cristipaval commented Feb 12, 2024

kirillzyusko commented Feb 12, 2024

cristipaval left a comment

cristipaval commented Feb 12, 2024

kirillzyusko commented Feb 12, 2024 •

edited

Loading

kirillzyusko commented Feb 12, 2024 •

edited

Loading

shawnborton commented Feb 12, 2024

kirillzyusko commented Feb 12, 2024

cristipaval commented Feb 12, 2024

OSBotify commented Feb 12, 2024

OSBotify commented Feb 15, 2024

situchan Mar 15, 2024

feat: app sounds #31055

feat: app sounds #31055

Conversation

lauridskern commented Nov 8, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Nov 8, 2023 • edited Loading

mountiny commented Nov 30, 2023

lauridskern commented Nov 30, 2023

lauridskern commented Nov 30, 2023

mountiny commented Dec 1, 2023

lauridskern commented Dec 1, 2023

melvin-bot bot commented Dec 6, 2023

aimane-chnaif commented Dec 8, 2023

melvin-bot bot commented Dec 22, 2023

shawnborton commented Dec 22, 2023

aimane-chnaif commented Dec 22, 2023 • edited Loading

shawnborton commented Jan 4, 2024

aimane-chnaif commented Jan 5, 2024

cristipaval left a comment

Choose a reason for hiding this comment

cristipaval commented Feb 12, 2024

cristipaval commented Feb 12, 2024 • edited Loading

kirillzyusko commented Feb 12, 2024

hannojg commented Feb 12, 2024

shawnborton commented Feb 12, 2024

cristipaval commented Feb 12, 2024

shawnborton commented Feb 12, 2024

cristipaval commented Feb 12, 2024

cristipaval commented Feb 12, 2024

kirillzyusko commented Feb 12, 2024

cristipaval left a comment

Choose a reason for hiding this comment

cristipaval commented Feb 12, 2024

kirillzyusko commented Feb 12, 2024 • edited Loading

kirillzyusko commented Feb 12, 2024 • edited Loading

shawnborton commented Feb 12, 2024

kirillzyusko commented Feb 12, 2024

cristipaval commented Feb 12, 2024

OSBotify commented Feb 12, 2024

OSBotify commented Feb 15, 2024

situchan Mar 15, 2024

Choose a reason for hiding this comment

lauridskern commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023 •

edited

Loading

aimane-chnaif commented Dec 22, 2023 •

edited

Loading

cristipaval commented Feb 12, 2024 •

edited

Loading

kirillzyusko commented Feb 12, 2024 •

edited

Loading

kirillzyusko commented Feb 12, 2024 •

edited

Loading