Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form Provider Refactor] EditRequestDescriptionPage #30382

Conversation

cdOut
Copy link
Contributor

@cdOut cdOut commented Oct 25, 2023

Details

Changed the Form component into the new FormProvider component in EditRequestDescriptionPage

Fixed Issues

$ #30307

Tests

  1. Log in and go into a chat that has a request in it or create a new one.
  2. Press on the request and then go into the description field.
  3. Update the description text and press save.
  4. Confirm that description updated successfully.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
ANDROID-NATIVE.mov
Android: mWeb Chrome
ANDROID-CHROME.mov
iOS: Native
IOS-NATIVE.mov
iOS: mWeb Safari
IOS-SAFARI.mov
MacOS: Chrome / Safari
SAFARI.mov
MacOS: Desktop
DESKTOP.mov

@cdOut cdOut marked this pull request as ready for review October 30, 2023 11:54
@cdOut cdOut requested a review from a team as a code owner October 30, 2023 11:54
@melvin-bot melvin-bot bot requested review from narefyev91 and removed request for a team October 30, 2023 11:54
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2023

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@narefyev91
Copy link
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
web.mov
Mobile Web - Chrome
android-web.mov
Mobile Web - Safari
ios-web.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov

Copy link
Contributor

@narefyev91 narefyev91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
🎀 👀 🎀 C+ reviewed

@melvin-bot melvin-bot bot requested a review from luacmartins October 30, 2023 14:21
@luacmartins luacmartins merged commit 2f4d50d into Expensify:main Oct 30, 2023
14 of 15 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 30, 2023
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1044.565 ms → 1288.195 ms (+243.630 ms, +23.3%) 🔴
App start runJsBundle 720.063 ms → 908.350 ms (+188.287 ms, +26.1%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1044.565 ms
Stdev: 33.667 ms (3.2%)
Runs: 959.470900000073 973.8804379999638 989.4986490001902 991.9561290000565 1004.2526039998047 1007.7320050001144 1007.885408999864 1010.3386809998192 1012.8621680000797 1013.8040970000438 1014.9162469999865 1016.8892109999433 1017.3996999999508 1017.5200140001252 1017.5545769999735 1018.606087999884 1018.9761370001361 1019.9296510000713 1020.5331870000809 1022.4784619999118 1022.6629869998433 1023.0213689999655 1024.40277899988 1025.4078179998323 1026.5851799999364 1026.9584539998323 1027.5780050000176 1027.6009140000679 1031.0077200001106 1031.6572639998049 1032.8225710000843 1033.6590240001678 1034.1115700001828 1035.270717999898 1036.0993079999462 1037.3270840002224 1037.4249709998257 1038.1185480002314 1039.3389220000245 1040.5866530002095 1041.3816370000131 1042.069079999812 1042.0691109998152 1045.3331070002168 1046.30917399982 1048.3895470001735 1048.3926940001547 1049.6683809999377 1051.0966730001383 1051.4922989998013 1053.1819719998166 1053.5574670000933 1053.782105000224 1055.1990939998068 1057.2549939998426 1060.4656969998032 1061.0729419998825 1062.1097929999232 1065.388059000019 1065.8638300001621 1069.4858140000142 1070.5226560002193 1075.8083859998733 1077.4945319998078 1078.8324059997685 1078.851063999813 1081.210543999914 1081.240120000206 1086.4352139998227 1087.0901649999432 1094.1173499999568 1094.5066619999707 1096.6099410001189 1116.6827329997905 1129.431020999793 1134.8588979998603 1136.0922389999032

Current
Mean: 1288.195 ms
Stdev: 40.000 ms (3.1%)
Runs: 1204.66048900038 1217.3176220003515 1226.1331780003384 1226.5501070003957 1231.26860900037 1235.0692229997367 1238.293622000143 1239.0527900001034 1241.9048979999498 1245.5008509997278 1246.1870980001986 1247.434841999784 1255.1027800003067 1255.5074389996007 1258.1135099995881 1259.9964300002903 1260.0314720002934 1260.4576500002295 1261.243483999744 1262.9253329997882 1263.637982999906 1264.310015999712 1264.8465870004147 1266.0544320000336 1266.9644980002195 1270.5445379996672 1272.026212000288 1273.2005869997665 1273.2373820003122 1273.3091789996251 1273.9366149995476 1276.8876670002937 1278.2568520000204 1278.341657999903 1278.3903419999406 1280.5859780004248 1281.868889999576 1282.252652999945 1286.0316220000386 1286.1699740001932 1287.2330109998584 1287.3075190000236 1289.276317000389 1290.0120369996876 1291.4521899996325 1292.4096619999036 1293.4052250003442 1295.402060000226 1299.163316999562 1300.365888999775 1300.4395549995825 1303.0193910002708 1305.5342009998858 1306.2392490003258 1306.6141569996253 1307.5960320001468 1309.422814999707 1311.29764899984 1312.1739370003343 1315.2926599998027 1319.0637870002538 1319.4286890001968 1320.445569000207 1322.1170220002532 1331.230685999617 1345.124684999697 1348.2193999998271 1350.8612529998645 1351.7748919995502 1352.5598849998787 1355.1954600000754 1359.479124000296 1380.1260770000517 1394.387590000406 1397.334854000248
App start runJsBundle Baseline
Mean: 720.063 ms
Stdev: 22.418 ms (3.1%)
Runs: 667 672 675 685 689 689 693 693 695 698 698 699 699 699 701 703 703 703 703 704 704 704 706 706 707 707 708 708 710 710 710 711 711 713 713 713 714 714 714 716 720 720 722 722 723 723 725 725 727 728 728 729 729 730 734 735 735 736 737 737 737 738 742 744 744 745 745 746 747 750 751 751 751 753 753 753 755 773 775

Current
Mean: 908.350 ms
Stdev: 40.353 ms (4.4%)
Runs: 823 843 843 853 856 856 857 863 866 867 868 869 869 870 870 872 873 873 874 874 874 876 877 882 884 888 890 890 891 891 893 895 897 898 898 903 903 905 906 906 906 908 909 909 909 910 911 911 911 912 912 913 914 915 916 918 920 925 926 932 933 938 939 940 944 947 954 954 955 956 959 959 963 970 984 986 992 998 1001 1023

Meaningless Changes To Duration

Show entries
Name Duration
Open Search Page TTI 697.234 ms → 741.562 ms (+44.328 ms, +6.4%)
App start regularAppStart 0.013 ms → 0.016 ms (+0.003 ms, +25.9%) 🟡
App start nativeLaunch 23.835 ms → 23.066 ms (-0.770 ms, -3.2%)
Show details
Name Duration
Open Search Page TTI Baseline
Mean: 697.234 ms
Stdev: 41.234 ms (5.9%)
Runs: 621.503010999877 624.6200370001607 628.8651939998381 629.3628749996424 633.6367190000601 633.7790529998019 643.7431649998762 644.9867760003544 650.1020100000314 650.6611739997752 652.7999680000357 657.4065350000747 658.3800449999981 658.6854249997996 659.143514000345 663.1762299998663 665.2309159999713 667.2749840002507 668.034139000345 668.3594160000794 668.6378179998137 669.9480789997615 671.2290040003136 672.3861500001512 675.3667399999686 675.906413000077 677.5540769998915 677.8904630001634 678.1044510002248 678.6341150002554 680.0663250000216 681.8547359998338 684.9524739999324 685.313518000301 685.375 688.003255000338 688.2108970000409 688.5578609998338 688.7346199997701 689.1149499998428 689.452432999853 690.5182300000452 690.9274899996817 691.5456139999442 692.0574550000019 692.2559819999151 695.3212489997968 699.9377439999953 701.5790610001422 703.7333990000188 705.6159669999033 706.9215090000071 709.2621659999713 709.2966720000841 709.9708669995889 712.7077639997005 713.6355789997615 717.7209879998118 720.4240319998935 721.6858719997108 723.3816729998216 726.2049969998188 726.7752290000208 731.7925619999878 732.1391199999489 733.275309999939 733.8819169998169 736.0384519998915 737.6404220000841 749.1381029998884 749.3016360001639 750.0050050001591 754.3677990003489 760.9894210002385 761.8340259999968 773.6880299998447 773.8175459997728 782.2579749999568 782.278565000277 792.9600829998963 803.99768100027

Current
Mean: 741.562 ms
Stdev: 44.364 ms (6.0%)
Runs: 643.1528730001301 662.8819590006024 674.3120940001681 679.203572999686 680.1571450000629 681.1785479998216 683.7573650004342 684.432658999227 687.5576179996133 687.6428629998118 688.2672529993579 691.0046390006319 695.396646999754 695.6330570001155 698.9849040005356 702.3256839998066 703.1169839994982 704.7097169999033 706.3899739999324 708.1420090002939 708.4683029996231 709.965657999739 710.0088710002601 711.5170090002939 711.9880789993331 713.0742190005258 717.6307380003855 718.3265789998695 718.7910970002413 719.2637130003422 719.4330240003765 719.6588949998841 722.9802660001442 725.1807049997151 728.7886560000479 730.7034919997677 730.734864000231 731.909831000492 732.4526380002499 733.9458420006558 736.0259199999273 736.6619070004672 739.266114000231 740.7474369993433 741.2444659993052 744.8324379995465 751.5686450004578 753.4477549996227 753.5203459998593 755.1345620006323 757.2814950002357 760.2648109998554 760.3588460003957 760.556641000323 763.9934079991654 764.4841720005497 765.4025069996715 766.9724129997194 767.0701090004295 770.0534260002896 777.0419120006263 777.2394619993865 779.0195310004056 781.531128000468 781.9886079998687 783.4694830002263 783.7916260007769 783.8039959995076 790.3467619996518 791.6242280006409 797.8379319999367 798.9386809999123 799.0129810003564 799.3954670000821 810.3979089995846 811.115438000299 817.5149739999324 823.5638030003756 826.5780440000817 835.5448409998789 854.7974040005356
App start regularAppStart Baseline
Mean: 0.013 ms
Stdev: 0.001 ms (4.7%)
Runs: 0.011880999896675348 0.011881999671459198 0.012126000132411718 0.012165999971330166 0.012329000048339367 0.012410999741405249 0.012451000045984983 0.012451999820768833 0.01249199965968728 0.012492000125348568 0.012532000429928303 0.012533000204712152 0.0125730000436306 0.0125730000436306 0.012614000122994184 0.012614000122994184 0.012614000122994184 0.012653999961912632 0.012655000202357769 0.01269499957561493 0.012695999816060066 0.012695999816060066 0.012775999959558249 0.012776999734342098 0.012776999734342098 0.012777000200003386 0.01281800027936697 0.01285799965262413 0.01285799965262413 0.01285799965262413 0.012858000118285418 0.012858000118285418 0.012858000118285418 0.012899000197649002 0.012899000197649002 0.0129399998113513 0.012980000115931034 0.012980000115931034 0.013019999954849482 0.013019999954849482 0.013021000195294619 0.013021000195294619 0.013061999808996916 0.013062000274658203 0.01310200011357665 0.01310200011357665 0.013141999952495098 0.013141999952495098 0.013183000031858683 0.013183999806642532 0.013224000111222267 0.013264999724924564 0.013265000190585852 0.013306000269949436 0.013346000108867884 0.013346999883651733 0.01334700034931302 0.013387000188231468 0.013428000267595053 0.01346899988129735 0.01358999963849783 0.013590000104159117 0.013591000344604254 0.013630999717861414 0.013671000022441149 0.013671999797224998 0.013712999876588583 0.013753000181168318 0.013793999794870615 0.013794000260531902 0.013875999953597784 0.013915999792516232 0.0142000000923872 0.014404000248759985 0.014485000167042017 0.014689000323414803 0.014689000323414803 0.01485099969431758

Current
Mean: 0.016 ms
Stdev: 0.001 ms (6.7%)
Runs: 0.014078999869525433 0.0147299999371171 0.014851999469101429 0.014933000318706036 0.015013999305665493 0.015137000009417534 0.015177000313997269 0.015177999623119831 0.015177999623119831 0.015217999927699566 0.015217999927699566 0.015298999845981598 0.015339999459683895 0.015381000004708767 0.015381000004708767 0.015461999922990799 0.015461999922990799 0.015463000163435936 0.015502999536693096 0.015502999536693096 0.015583999454975128 0.015625 0.015625 0.015666000545024872 0.015747000463306904 0.0157880000770092 0.015828000381588936 0.01590999960899353 0.015951000154018402 0.015991000458598137 0.016032000072300434 0.016032000072300434 0.016152999363839626 0.016193999908864498 0.01623500045388937 0.016236000694334507 0.016236000694334507 0.016397999599575996 0.016439000144600868 0.01647899951785803 0.016479000449180603 0.016479999758303165 0.016560999676585197 0.016561000607907772 0.016561000607907772 0.016681999899446964 0.01676500029861927 0.016805000603199005 0.0168869998306036 0.016887000761926174 0.01696799974888563 0.01696799974888563 0.017009000293910503 0.017049000598490238 0.017049000598490238 0.0170499999076128 0.017090000212192535 0.017171000130474567 0.017211999744176865 0.017252999357879162 0.01733400020748377 0.01749700028449297 0.017537999898195267 0.017700999975204468 0.017740999348461628 0.017781000584363937 0.0177819998934865 0.0177819998934865 0.017822000198066235 0.017822000198066235 0.017862999811768532 0.017985000275075436 0.018025999888777733 0.018025999888777733 0.018147999420762062 0.018473000265657902 0.018596000038087368 0.018962000496685505 0.019286999478936195
App start nativeLaunch Baseline
Mean: 23.835 ms
Stdev: 3.905 ms (16.4%)
Runs: 18 19 19 19 19 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 23 24 24 25 25 25 25 25 25 25 25 26 26 27 27 27 27 27 28 28 28 28 28 28 29 29 29 30 30 30 31 31 33 33 35

Current
Mean: 23.066 ms
Stdev: 2.562 ms (11.1%)
Runs: 19 19 19 19 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 25 25 25 25 25 25 25 26 26 26 26 27 27 27 27 28 30 30 31

@github-actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.94-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

1 similar comment
@OSBotify
Copy link
Contributor

OSBotify commented Nov 1, 2023

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.94-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 2, 2023

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 2, 2023

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.95-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 6, 2023

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants