Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Fix a ButtonWithLoader usage #3004

Merged
merged 1 commit into from
May 19, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented May 19, 2021

Details

This build is failing because a dependency is missing so main is broken

https://github.com/Expensify/Expensify.cash/commit/eabb5e2bf993e14db0804dc2f02904a58cbbeed1/checks

Fixed Issues

No issue

Tests

QA Steps

No QA

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this May 19, 2021
@marcaaron marcaaron requested a review from a team as a code owner May 19, 2021 02:51
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team May 19, 2021 02:51
Copy link
Contributor

@jasperhuangg jasperhuangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Gonna hold off on merging till E2E tests are all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants