Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix can't close location error message while address suggestion dropdown is open #29932

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix can't close location error message while address suggestion dropdown is open #29932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/LocationErrorMessage/BaseLocationErrorMessage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ function BaseLocationErrorMessage({onClose, onAllowLocationLinkPress, locationEr
<Tooltip text={translate('common.close')}>
<PressableWithoutFeedback
onPress={onClose}
onMouseDown={(e) => e.preventDefault()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if we can add a brief comment. : )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a pretty common pattern found in the codebase and some of them already have the comment, so I didn't add it on purpose. Do you think we should still add it here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion either, just feel that if there are better UI optimizations for this component in the future, this can be deleted without hesitation. Also, let's wait a few more hours. If @neil-marcellini doesn't have other thoughts, I'll fill the list. : )

style={[styles.touchableButtonImage]}
accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
accessibilityLabel={translate('common.close')}
Expand Down
Loading