-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved error message handling when searching for multiple emails #29549
Conversation
Only slow contact suggestions for the final search term
@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mananjadhav I guess this is yours |
Thanks for tagging @Santhosh-Sellavel. Testing this. |
@Samueljh1 Shouldn't we show the same error message when it's just a single participant that is already a member. |
Could you clarify the steps you took to get this? I am not having this issue. |
Any update here? |
Details
Improved error message handling when searching for multiple emails.
Fixed Issues
$ #29494
Related to: #26242
PROPOSAL: #26242 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-10-13.at.12.32.09.mov
Mobile Web - Chrome
proof_android_web.mov
Mobile Web - Safari
proof_ios_web.mov
Desktop
proof_desktop.mov
iOS
proof_ios.mov
Android
proof_android.mov