Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed chrome check for fixing regression #28580

Merged
merged 7 commits into from
Oct 11, 2023
Merged

removed chrome check for fixing regression #28580

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2836e7d
removed chrome check for fixing regression
ayazalavi Oct 2, 2023
ccace96
linting fix
ayazalavi Oct 2, 2023
6ad3ff9
prettier fix
ayazalavi Oct 2, 2023
e405e9b
Update BaseTextInput.js
ayazalavi Oct 2, 2023
4314590
prettier fix
ayazalavi Oct 2, 2023
23470eb
updated css height for chrome mobile
ayazalavi Oct 5, 2023
1a1dbec
added comment
ayazalavi Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/components/TextInput/BaseTextInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,17 +242,16 @@ function BaseTextInput(props) {
For other platforms, explicitly remove `lineHeight` from single-line inputs
to prevent long text from disappearing once it exceeds the input space.
See https://github.com/Expensify/App/issues/13802 */

const lineHeight = useMemo(() => {
if (Browser.isSafari() && _.isArray(props.inputStyle)) {
const lineHeightValue = _.find(props.inputStyle, (f) => f.lineHeight !== undefined);
if (lineHeightValue) {
return lineHeightValue.lineHeight;
}
} else if (Browser.isSafari() || Browser.isMobileChrome()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayazalavi We had an issue on Chrome as well. If we remove the condition, won't it recreate the problem on mWeb/Chrome?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sobitneupane issue is not reported for android chrome by the bug reporter. Please cross verify it on your end as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But since we have known the issue exists in android chrome as well, our goal should be to handle the issue on all platforms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if you can see the issue on android chrome? It is working fine now on my end.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is still reproducible on mWeb/Chrome.

Screen.Recording.2023-10-05.at.17.20.24.mov

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sobitneupane I have made updates, this issue must be fixed now on mobile chrome as well. Kindly make sure to test other things if something is broken then let me know

Copy link
Contributor

@sobitneupane sobitneupane Oct 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayazalavi Please make sure to make thorough review in your end before requesting review. Also, after making major update or any platform specific changes, make sure to update the screen recordings. Make sure to upload screen recordings for all test cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure let me do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is working fine on my end.

Untitled.16.mp4
Untitled.17.mp4

But you need to check as per platform requirement as well. I might have missed something.

return height;
}
return undefined;
}, [props.inputStyle, height]);
}, [props.inputStyle]);

return (
<>
Expand Down
Loading