-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile - GMT time is not displayed #2097 #2756
Conversation
Profile - GMT time is not displayed #2097
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Hi @kaushiktd it looks like you didn't use our pull request template which has a lot of important info on it. Could you update your PR to follow it? This is the template
|
@kaushiktd can you please update this PR? |
@stitesExpensify please check I've updated PR request. |
@@ -101,7 +101,15 @@ const DetailsPage = ({personalDetails, route}) => { | |||
<Text style={[styles.textP]} numberOfLines={1}> | |||
{moment().tz(details.timezone.selected).format('LT')} | |||
{' '} | |||
{moment().tz(details.timezone.selected).zoneAbbr()} | |||
{isNaN(moment().tz(details.timezone.selected).zoneAbbr()) ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind moving the logic here up above the return? So basically make a currentTime
var and then here it will just be <Text>{currentTime}</Text>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick change, and there appear to be some style problems as well :)
duplicate pull request |
Details
This issue is resolved by just modifying moment syntax because in the moment library, some timezone abbreviation, not support. so if return numeric value I've put modified syntax to show GMT.
Fixed Issues
Fixes #2097
Tests
QA Steps
I've already QA this issue and it's working properly.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android