Add Personal Bank Account via Plaid flow #2746
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| buildscript { | ||
| ext { | ||
| buildToolsVersion = "29.0.2" | ||
| minSdkVersion = 21 | ||
|
There was a problem hiding this comment. This appears to be a requirement in order to use the Plaid SDK on Android https://github.com/plaid/react-native-plaid-link-sdk#3-configure-gradle I'm hoping it's OK ? @Jag96 There was a problem hiding this comment. We talked about doing this a while back but this is definitely fine, the issue is here: https://github.com/Expensify/Expensify/issues/149395 |
||
| compileSdkVersion = 30 | ||
| targetSdkVersion = 30 | ||
| androidXCore = "1.0.2" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ | |
| # Specifies the JVM arguments used for the daemon process. | ||
| # The setting is particularly useful for tweaking memory settings. | ||
| # Default value: -Xmx10248m -XX:MaxPermSize=256m | ||
| org.gradle.jvmargs=-Xmx2048m -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8 | ||
|
There was a problem hiding this comment. This seems necessary after adding the Plaid SDK there's some more information here about this: https://medium.com/google-developers/faster-android-studio-builds-with-dex-in-process-5988ed8aa37e There was a problem hiding this comment. TL;DR is that without this enabled the android app wouldn't build at all. There was a problem hiding this comment. What version of the JDK do we target? There was a problem hiding this comment. JDK 8 I believe, I don't know much about Java though I just uncommented this line out based on the advice in that blog post. |
||
|
|
||
| # When configured, Gradle will run in incubating parallel mode. | ||
| # This option should only be used with decoupled projects. More details, visit | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import {useCallback, useEffect} from 'react'; | ||
| import {usePlaidLink} from 'react-plaid-link'; | ||
| import {plaidLinkPropTypes, plaidLinkDefaultProps} from './plaidLinkPropTypes'; | ||
|
|
||
| const PlaidLink = (props) => { | ||
| const onSuccess = useCallback((publicToken, metadata) => { | ||
| props.onSuccess({publicToken, metadata}); | ||
| }, []); | ||
|
|
||
| const {open, ready, error} = usePlaidLink({ | ||
|
There was a problem hiding this comment. We normally should not need to use hooks (and kind of discourage it), but the Plaid library we're using for React web here really only offers this option to launch the flow programmatically. |
||
| token: props.token, | ||
| onSuccess, | ||
| onExit: props.onExit, | ||
| }); | ||
|
|
||
| useEffect(() => { | ||
| if (error) { | ||
| props.onError(error); | ||
|
There was a problem hiding this comment. This usage leads to #38069. This happened due to a change in |
||
| return; | ||
| } | ||
|
|
||
| if (!ready) { | ||
| return; | ||
| } | ||
|
|
||
| open(); | ||
| }, [ready, error]); | ||
|
|
||
| return null; | ||
| }; | ||
|
|
||
| PlaidLink.propTypes = plaidLinkPropTypes; | ||
| PlaidLink.defaultProps = plaidLinkDefaultProps; | ||
| PlaidLink.displayName = 'PlaidLink'; | ||
| export default PlaidLink; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, can't we reuse the
EXPENSIFY_URL_SECUREconfig for this, and make people enter their secure-ngrok URL there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could, but this way means if you want to switch from using ngrok to not using it you can just set
USE_NGROKto false without having to change the urls often.