Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix broken production deploy #2641

Merged
merged 1 commit into from
Apr 30, 2021
Merged

[No QA] Fix broken production deploy #2641

merged 1 commit into from
Apr 30, 2021

Conversation

roryabraham
Copy link
Contributor

Details

This PR borked prod deploys. Unfortunately JSON.parse is really not that flexible. 😕

Fixed Issues

Broken E.cash production deploys: https://github.com/Expensify/Expensify.cash/runs/2471474181?check_suite_focus=true

Tests

Run a production deploy to find out if it works 🙃

@roryabraham roryabraham requested a review from a team as a code owner April 29, 2021 23:35
@roryabraham roryabraham self-assigned this Apr 29, 2021
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team April 29, 2021 23:35
@roryabraham roryabraham mentioned this pull request Apr 29, 2021
Merged
Beamanator
Beamanator approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck 🙏 :D

@Beamanator Beamanator merged commit 52c9edf into main Apr 30, 2021
@Beamanator Beamanator deleted the Rory-FixProdDeploys branch April 30, 2021 14:41
@OSBotify OSBotify mentioned this pull request Apr 30, 2021
Closed
23 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.34-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

@Beamanator Beamanator Beamanator approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roryabraham @OSBotify @AndrewGable @Beamanator