Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double click navigating twice on lists #25604

Merged
merged 59 commits into from
May 28, 2024
Merged

Fix double click navigating twice on lists #25604

merged 59 commits into from
May 28, 2024

Commits on Aug 21, 2023

  1. Added debounce row selection prop to selection list

    @huzaifa-99
    huzaifa-99 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    ae5a99f View commit details
    Browse the repository at this point in the history

  2. Updated pages to use debounced onSelectRow on selection list for side… 

    … effects
    @huzaifa-99
    huzaifa-99 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    9213d0d View commit details
    Browse the repository at this point in the history

  3. Added debounce row selection prop to options list

    @huzaifa-99
    huzaifa-99 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e2ea627 View commit details
    Browse the repository at this point in the history

  4. Updated pages to use debounced onSelectRow on options list for side e… 

    …ffects
    @huzaifa-99
    huzaifa-99 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4754aa7 View commit details
    Browse the repository at this point in the history

  5. Added debounce row selection prop to options selector

    @huzaifa-99
    huzaifa-99 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    c289d5a View commit details
    Browse the repository at this point in the history

  6. Updated pages to use debounced onSelectRow on options selector for si… 

    …de effects
    @huzaifa-99
    huzaifa-99 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    54e0fe0 View commit details
    Browse the repository at this point in the history

  7. Updated debounce callback in option row

    @huzaifa-99
    huzaifa-99 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    fc64f73 View commit details
    Browse the repository at this point in the history

  8. Fix lint

    @huzaifa-99
    huzaifa-99 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    6e3c7ac View commit details
    Browse the repository at this point in the history

  9. Fix lint

    @huzaifa-99
    huzaifa-99 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e50bb84 View commit details
    Browse the repository at this point in the history

  10. Fix debounced onSelectRow implementation in OptionRow

    @huzaifa-99
    huzaifa-99 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4adf263 View commit details
    Browse the repository at this point in the history

  11. Removed extra call to onSelectRow

    @huzaifa-99
    huzaifa-99 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d375d2d View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8edf17f View commit details
    Browse the repository at this point in the history

  2. Updated new selection list to conditionally debounce onSelectRow

    @huzaifa-99
    huzaifa-99 committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7be2135 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Merge branch 'Expensify:main' into 24074-fix-double-click-navigating-… 

    …twice
    @huzaifa-99
    huzaifa-99 authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    3f6942d View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Added debounced row select to ThemePage

    @huzaifa-99
    huzaifa-99 authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c57dbba View commit details
    Browse the repository at this point in the history

  2. Added debounced row select to CategoryPicker

    @huzaifa-99
    huzaifa-99 authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9d0d697 View commit details
    Browse the repository at this point in the history

  3. Updated early return syntax

    @huzaifa-99
    huzaifa-99 authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    3712746 View commit details
    Browse the repository at this point in the history

  4. Added comment explaining updateOnSelectRow in OptionRow

    @huzaifa-99
    huzaifa-99 authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    995f33d View commit details
    Browse the repository at this point in the history

  5. Cancel debounced function version when props change

    @huzaifa-99
    huzaifa-99 authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0abd5d2 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5cfe674 View commit details
    Browse the repository at this point in the history

  7. Removed unnecessary callback

    @huzaifa-99
    huzaifa-99 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    329767c View commit details
    Browse the repository at this point in the history

  8. Updated comments lettercase

    @huzaifa-99
    huzaifa-99 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b2b25fa View commit details
    Browse the repository at this point in the history

  9. Fixed comment syntax

    @huzaifa-99
    huzaifa-99 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    44c5f32 View commit details
    Browse the repository at this point in the history

  10. Remove eslint disable rule

    @huzaifa-99
    huzaifa-99 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1f2d67a View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    2f67ee0 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    27f5aca View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    9cb54b1 View commit details
    Browse the repository at this point in the history

  2. Added debounce for arrow selection on selection list

    @huzaifa-99
    huzaifa-99 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    f5aaccc View commit details
    Browse the repository at this point in the history

  3. Added row select debounce on tag picker

    @huzaifa-99
    huzaifa-99 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    57696cc View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    dec4563 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e93c2ab View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Updated debounce function

    @huzaifa-99
    huzaifa-99 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    21ce3df View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    bee6f1a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Use seperate callback for debounced func

    @huzaifa-99
    huzaifa-99 committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2b81ebf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    0434a68 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e987f14 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    ce8e6e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4c9668e View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Added single execution logic on web

    @huzaifa-99
    huzaifa-99 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    fe8f185 View commit details
    Browse the repository at this point in the history

  2. Removed debounced onRowSelect from OptionsList, OptionsSelector and O… 

    …ptionRow
    @huzaifa-99
    huzaifa-99 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    4e71b31 View commit details
    Browse the repository at this point in the history

  3. Added shouldDebounceRowSelect on all SelectionLists with single item … 

    …select
    @huzaifa-99
    huzaifa-99 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    f410673 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    f668b79 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    d0ea9f3 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    3940e32 View commit details
    Browse the repository at this point in the history

  2. Fix type export

    @huzaifa-99
    huzaifa-99 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    019e706 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    855a7f3 View commit details
    Browse the repository at this point in the history

  2. Fix type

    @huzaifa-99
    huzaifa-99 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1a69275 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2d46d87 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Revert useSingleExecution on web

    @huzaifa-99
    huzaifa-99 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    dfe0c26 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    403d15f View commit details
    Browse the repository at this point in the history

  3. Lint

    @huzaifa-99
    huzaifa-99 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    bfd87a2 View commit details
    Browse the repository at this point in the history

  4. Added shouldDebounceRowSelect to new pages

    @huzaifa-99
    huzaifa-99 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    2f8f685 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    1aff45b View commit details
    Browse the repository at this point in the history

  2. Added debounce to new components

    @huzaifa-99
    huzaifa-99 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    dda25b6 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    762c3b4 View commit details
    Browse the repository at this point in the history

  2. Added shouldDebounceRowSelect to newer components

    @huzaifa-99
    huzaifa-99 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f626b5e View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Merge branch 'main' into 24074-fix-double-click-navigating-twice

    @huzaifa-99
    huzaifa-99 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    1e5c77f View commit details
    Browse the repository at this point in the history

  2. Removed unnecessary logical check

    @huzaifa-99
    huzaifa-99 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    7c9240b View commit details
    Browse the repository at this point in the history

  3. Updated comment

    @huzaifa-99
    huzaifa-99 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    8dcd282 View commit details
    Browse the repository at this point in the history