Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement report approvals #24639

Merged
merged 53 commits into from
Aug 28, 2023
Merged

Implement report approvals #24639

merged 53 commits into from
Aug 28, 2023

Commits on Aug 7, 2023

  1. Add approveMoneyRequest action

    @youssef-lr
    youssef-lr committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    e1c0319 View commit details
    Browse the repository at this point in the history

  2. Add logic for showing the approve/settlement button

    @youssef-lr
    youssef-lr committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b1e77ab View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Merge branch 'main' into youssef_approve_money_request

    @youssef-lr
    youssef-lr committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    386d9f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Add helper methods

    @youssef-lr
    youssef-lr committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    fa1bb92 View commit details
    Browse the repository at this point in the history

  2. Allow APPROVED action to be displayed

    @youssef-lr
    youssef-lr committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    691ceba View commit details
    Browse the repository at this point in the history

  3. Fix optimistic data for approved action

    @youssef-lr
    youssef-lr committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    e0da0f3 View commit details
    Browse the repository at this point in the history

  4. Add missing imports and code tidying up

    @youssef-lr
    youssef-lr committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    f7b422e View commit details
    Browse the repository at this point in the history

  5. Display APPROVED action text in subtle color

    @youssef-lr
    youssef-lr committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    9a8bef8 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2023

  1. Display approved reports as approved and not paid

    @youssef-lr
    youssef-lr committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    2d50862 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Fix lastMessageText showing duplicate actor name

    @youssef-lr
    youssef-lr committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    e8543c8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into youssef_approve_money_request

    @youssef-lr
    youssef-lr committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    00fb139 View commit details
    Browse the repository at this point in the history

  3. Code improvement

    @youssef-lr
    youssef-lr committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1140036 View commit details
    Browse the repository at this point in the history

  4. Create new IOU report if the current report is approved

    @youssef-lr
    youssef-lr committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    266cd4c View commit details
    Browse the repository at this point in the history

  5. Display translated IOU/Report previews

    @youssef-lr
    youssef-lr committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    5de9792 View commit details
    Browse the repository at this point in the history

  6. Fix bug showing approve button when report is settled

    @youssef-lr
    youssef-lr committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    75e9ed4 View commit details
    Browse the repository at this point in the history

  7. Display green dot properly

    @youssef-lr
    youssef-lr committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    508021d View commit details
    Browse the repository at this point in the history

  8. Cleanup

    @youssef-lr
    youssef-lr committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    ecd428a View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Clean up

    @youssef-lr
    youssef-lr committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    18c5198 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into youssef_approve_money_request

    @youssef-lr
    youssef-lr committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    4e2a5c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Use getIOUReportActionMessage to format APPROVED action message

    @youssef-lr
    youssef-lr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    da32226 View commit details
    Browse the repository at this point in the history

  2. Add spanish translations

    @youssef-lr
    youssef-lr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    d75e3f8 View commit details
    Browse the repository at this point in the history

  3. Code tidying up

    @youssef-lr
    youssef-lr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    3930802 View commit details
    Browse the repository at this point in the history

  4. Fix IOU report being created instead of Expense report

    @youssef-lr
    youssef-lr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    c7d51cf View commit details
    Browse the repository at this point in the history

  5. Code tidying up

    @youssef-lr
    youssef-lr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    d160aed View commit details
    Browse the repository at this point in the history

  6. Fix bug

    @youssef-lr
    youssef-lr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    07682c5 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into youssef_approve_money_request

    @youssef-lr
    youssef-lr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    74b8caf View commit details
    Browse the repository at this point in the history

  8. Bug fix

    @youssef-lr
    youssef-lr committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    3b570e2 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. Fix code action

    @youssef-lr
    youssef-lr committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    273966c View commit details
    Browse the repository at this point in the history

  2. Fix code actions

    @youssef-lr
    youssef-lr committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    100f03d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into youssef_approve_money_request

    @youssef-lr
    youssef-lr committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    03cc982 View commit details
    Browse the repository at this point in the history

  4. Linting

    @youssef-lr
    youssef-lr committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    909cd45 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Style and translation

    @youssef-lr
    youssef-lr committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    3462084 View commit details
    Browse the repository at this point in the history

  2. Add back code removed by mistake

    @youssef-lr
    youssef-lr committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    fca135f View commit details
    Browse the repository at this point in the history

  3. Fix test

    @youssef-lr
    youssef-lr committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    f7382f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Style fix

    @youssef-lr
    youssef-lr committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    2d3bf23 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Remove no longer needed helper func

    @youssef-lr
    youssef-lr committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    c134640 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into youssef_approve_money_request

    @youssef-lr
    youssef-lr committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    216618b View commit details
    Browse the repository at this point in the history

  3. Show Pay button in report preview for admins when report is approved

    @youssef-lr
    youssef-lr committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    21d5783 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Merge branch 'main' into youssef_approve_money_request

    @youssef-lr
    youssef-lr committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    10a287a View commit details
    Browse the repository at this point in the history

  2. Clean up

    @youssef-lr
    youssef-lr committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    03e9513 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Carlos Martins <cmartins@expensify.com>
    @youssef-lr @luacmartins
    youssef-lr and luacmartins authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ceff45b View commit details
    Browse the repository at this point in the history

  4. Address PR comments

    @youssef-lr
    youssef-lr committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    2e373a8 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Address comments

    @youssef-lr
    youssef-lr committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    95dc9e2 View commit details
    Browse the repository at this point in the history

  2. Only display "Pay" button for the admin in the report preview

    @youssef-lr
    youssef-lr committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    15ab698 View commit details
    Browse the repository at this point in the history

  3. Optimise how policy is passed to money request componenets

    @youssef-lr
    youssef-lr committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    e7c4804 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Merge branch 'main' into youssef_approve_money_request

    @youssef-lr
    youssef-lr committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c89f0a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Bug fix

    @youssef-lr
    youssef-lr committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    66b6724 View commit details
    Browse the repository at this point in the history

  2. Another bug fix

    @youssef-lr
    youssef-lr committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    4833ce4 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Merge branch 'main' into youssef_approve_money_request

    @youssef-lr
    youssef-lr committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7dc3738 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into youssef_approve_money_request

    @youssef-lr
    youssef-lr authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1b176a9 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Carlos Martins <cmartins@expensify.com>
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @youssef-lr @luacmartins @mountiny
    3 people authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    575524c View commit details
    Browse the repository at this point in the history

  4. Address PR comments

    @youssef-lr
    youssef-lr committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b341aa1 View commit details
    Browse the repository at this point in the history

  5. Fix lint and approve button style

    @youssef-lr
    youssef-lr committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    577d9ad View commit details
    Browse the repository at this point in the history