-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 23369 back button navigation fixed for ondify steps #24406
base: main
Are you sure you want to change the base?
Conversation
…eps"" This reverts commit 32ae589.
@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@robertKozik did you get a chance to look at this PR? |
Sorry I was OOO, coming back to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comment below, what you think about such a approach
goBack() { | ||
const platform = getPlatform(); | ||
const isNative = platform === CONST.PLATFORM.IOS || platform === CONST.PLATFORM.ANDROID; | ||
if (!isNative) { | ||
const onfidoBack = document.querySelector('.onfido-sdk-ui-NavigationBar-back'); | ||
if (onfidoBack && !onfidoBack.classList.contains('onfido-sdk-ui-NavigationBar-disabled')) { | ||
return onfidoBack.click(); | ||
} | ||
} | ||
this.props.onBackButtonPress(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you think about hoisting onfidoBackAction it to another file where we would have index.js and index.native.js so we won't have the wole platform checking?
The onBackButtonPress
can be passed as argument then, sth like:
...
onBackButtonPress={() => onfidoBackAction(this.props.onBackButtonPress)}
...
@vipin87 kindly bump |
@vipin87 bumping again |
Details
Fixed Issues
$ #23369
PROPOSAL: #23369 (comment)
Tests
Offline tests
Onfido flow not available in offline mode. It has to be tested while application is online.
QA Steps
Same as "Tests" section above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web-1.mov
Mobile Web - Chrome
chrome-1.MP4
Mobile Web - Safari
safari-1.MP4
Desktop
desktop-1.mov
iOS
ios-1.mov
Android
android-1.mov