Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate native AttachmentPicker to functional component #24364

Merged
merged 21 commits into from
Aug 22, 2023
Merged

migrate native AttachmentPicker to functional component #24364

merged 21 commits into from
Aug 22, 2023

Commits on Aug 18, 2023

  1. migrate native AttachmentPicker to functional component

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    4e85d60 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary comment

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    acfd749 View commit details
    Browse the repository at this point in the history

  3. destructure props

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    1cd666a View commit details
    Browse the repository at this point in the history

  4. refactor function declarations

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    2ad8277 View commit details
    Browse the repository at this point in the history

  5. remove unnecessary newline

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    d90c027 View commit details
    Browse the repository at this point in the history

  6. simplify style conditional expression

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    491fb12 View commit details
    Browse the repository at this point in the history

  7. replace withLocalize with useLocalize hook

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    859f22c View commit details
    Browse the repository at this point in the history

  8. simplify passing function as a prop

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    05aad64 View commit details
    Browse the repository at this point in the history

  9. wrap necessary functions with useCallback

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    2901087 View commit details
    Browse the repository at this point in the history

  10. simplify showDocumentPicker function call

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    e2af866 View commit details
    Browse the repository at this point in the history

  11. add displayName

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    bf143c9 View commit details
    Browse the repository at this point in the history

  12. remove unnecessary comment

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    e1a30e4 View commit details
    Browse the repository at this point in the history

  13. replace withWindowDimensions with useWindowDimensions hook

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    fdd4db7 View commit details
    Browse the repository at this point in the history

  14. move useState to the top

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    98ae4a5 View commit details
    Browse the repository at this point in the history

  15. add explaination to eslint disable rule

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    845470f View commit details
    Browse the repository at this point in the history

  16. convert menuItemData to useState

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    cc36b2a View commit details
    Browse the repository at this point in the history

  17. replace empty return statement with Promise.resolve()

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    374b292 View commit details
    Browse the repository at this point in the history

  18. take advantage of useKeyboardShortcut hook

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    f1089df View commit details
    Browse the repository at this point in the history

  19. take advantage of useArrowKeyFocusManager hook

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    48922a7 View commit details
    Browse the repository at this point in the history

  20. restore general comment

    @JKobrynski
    JKobrynski committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    33c88fc View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. run prettier

    @JKobrynski
    JKobrynski committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    968434b View commit details
    Browse the repository at this point in the history