-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract emojis from paste text #23153
Merged
marcaaron
merged 43 commits into
Expensify:main
from
jeet-dhandha:fix-emoji-paste-issue
Aug 22, 2023
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
d8594f5
chore: extract emojis from paste text
jeet-dhandha 29f0a45
chore: lint issue fix
jeet-dhandha 0d5523b
Merge branch 'main' into fix-emoji-paste-issue
jeet-dhandha 164b2b3
Merge remote-tracking branch 'upstream/main'
jeet-dhandha 61444f8
chore: change jsdoc and varible names
jeet-dhandha 27f37b8
chore: change condition for early return
jeet-dhandha 2758401
chore: remove extra regex and use the available one EMOJIS
jeet-dhandha 8cccc89
chore: variable name spell fix
jeet-dhandha e8b2632
fix: zwj sequences issue
jeet-dhandha 4a533bd
Removed extra emojis
jeet-dhandha 8b10df2
fix: lint issue
jeet-dhandha 2729ae4
Merge remote-tracking branch 'upstream/main'
jeet-dhandha c1d189c
Merge branch 'main' into fix-emoji-paste-issue
jeet-dhandha af59f1b
fix: emoji not adding due to null sequence
jeet-dhandha a8b6aaa
fix: used all the emoji constants
jeet-dhandha eb1ec24
Update CONST.js
jeet-dhandha dec57bc
Merge remote-tracking branch 'upstream/main'
jeet-dhandha d863fef
chore: remove extra regex for emoji and use updated one
jeet-dhandha 5b98212
chore: remove extra str and change continue code
jeet-dhandha c81da8b
Merge remote-tracking branch 'upstream/main'
jeet-dhandha 0ad3371
Merge remote-tracking branch 'upstream/main'
jeet-dhandha d0acea1
Merge remote-tracking branch 'upstream/main'
jeet-dhandha 9f170bd
Merge branch 'main' into fix-emoji-paste-issue
jeet-dhandha 91d7a3e
Merge remote-tracking branch 'upstream/main'
jeet-dhandha 4fdd603
Merge remote-tracking branch 'upstream/main'
jeet-dhandha e76bbd0
Merge remote-tracking branch 'upstream/main'
jeet-dhandha ecf4f05
Merge remote-tracking branch 'upstream/main'
jeet-dhandha db51c50
Merge remote-tracking branch 'upstream/main'
jeet-dhandha 5ce9cf2
fix: handle skin tones for emojis
jeet-dhandha 2c59c73
Merge remote-tracking branch 'upstream/main'
jeet-dhandha c72a561
Merge branch 'main' into fix-emoji-paste-issue
jeet-dhandha 420c187
chore: replace emojiCodeTable with emojiCodeTableWithSkinTones
jeet-dhandha c0b42b1
fix: logic for removing duplicates
jeet-dhandha 99ce37c
Merge remote-tracking branch 'upstream/main'
jeet-dhandha e8f02ee
Merge branch 'main' into fix-emoji-paste-issue
jeet-dhandha 425cd7f
Merge remote-tracking branch 'upstream/main'
jeet-dhandha 66b0b9e
Merge branch 'main' into fix-emoji-paste-issue
jeet-dhandha b7ef46d
updated comments
jeet-dhandha 8f9fba2
Merge remote-tracking branch 'upstream/main'
jeet-dhandha 3ee107f
Merge branch 'main' into fix-emoji-paste-issue
jeet-dhandha fb9ced7
modify code to remove extra set
jeet-dhandha 3ea6611
Added comments and updated variable name
jeet-dhandha f4e916a
updated comment
jeet-dhandha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we replace the existing
emojiCodeTable
with the newemojiCodeTableWithSkinTones
instead of keeping two different maps?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Updating the code.