[No QA] Add new style rule for refs in constructor #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
requested review from
AndrewGable,
Julesssss,
alex-mechler and
marcaaron
roryabraham
changed the title
marcaaron
reviewed
Mar 29, 2021
STYLE.md
Outdated
| super(props); | ||
|
|
||
| // Good: Ref is declared in the constructor | ||
| this.myRef = null; |
There was a problem hiding this comment.
Why null and not undefined? Does it make any difference?
There was a problem hiding this comment.
No big difference, and I have no preference.
|
Cool with this change, but I'd prefer using |
|
Updated |
marcaaron
approved these changes
Mar 29, 2021
alex-mechler
approved these changes
Mar 29, 2021
85 tasks
5 tasks
|
Coming from here ... @tgolen makes a pretty good case that this rule adds lines of code that don't have any effect, so should be remove. The purpose of this change was to improve readability, which is subjective. Since it's not unanimous that this is beneficial, I think we should revert. Does anyone disagree? |
|
Since there were no objections, the revert PR is here |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing the addition of a new React style rule. I believe that having all refs be declared in the constructor is good for documentation purposes and makes it easier to quickly figure out how a component works. Tagging a small sampling of people I know are pretty good with React to see if people agree.