Fix inconsistent input field size in close account page message field #21333

reinaldosg · 2023-06-22T17:04:58Z

Details

Fixed Issues

$ #20904
PROPOSAL: #20904(COMMENT)

Tests

Open Setting
Open Security
Open Close Account
See if the message text field is only one line and auto grow
Close Setting
Open Any Workspace room
Open room details
Open setting then welcome message
See if the welcome message text field is only one line and auto grow

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as test steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-22.at.18.50.23.mp4

Mobile Web - Chrome

Screen.Recording.2023-06-22.at.23.21.16.mov

Mobile Web - Safari

Screen.Recording.2023-06-22.at.23.08.07.mov

Desktop

Screen.Recording.2023-06-22.at.23.06.54.1.mp4

iOS

iphone.mp4

Android

Screen.Recording.2023-06-22.at.23.18.57.mp4

melvin-bot · 2023-06-22T17:05:02Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

github-actions · 2023-06-22T17:05:11Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

melvin-bot · 2023-06-22T17:05:30Z

@NikkiWines Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

srikarparsi · 2023-06-22T17:09:40Z

hey @NikkiWines, sorry for the assign, I think it might've been linked differently

reinaldosg · 2023-06-22T17:20:45Z

I have read the CLA Document and I hereby sign the CLA

reinaldosg · 2023-06-22T17:44:10Z

@venture1981 I think my changes aren't worth mentioning on the docs since it doesn't affect how to implement the Form component. But let me know if you have a different opinion 🙏

reinaldosebastian · 2023-06-23T07:45:21Z

I have read the CLA Document and I hereby sign the CLA

reinaldosebastian · 2023-06-23T07:45:28Z

recheck

thesahindia · 2023-06-23T08:58:42Z

@shawnborton, should we keep the max height same as invite message field?

thesahindia · 2023-06-23T09:14:13Z

src/components/TextInput/BaseTextInput.js

@@ -224,6 +224,8 @@ class BaseTextInput extends Component {
            {},
        );
        const isMultiline = this.props.multiline || this.props.autoGrowHeight;
+        //if AutoGrowWeight is true, placeholder needs to be filled with any string.
+        const hiddenTextPlaceholder = this.props.placeholder ? this.props.placeholder : this.props.autoGrowHeight ? ' ' : '';


Why do we need this @reinaldosg ?

@thesahindia Actually this is kind of weird behavior. In the Desktop app, the height isn't set right away if there's no text set on the hidden Text component. (see attached video)

Screen.Recording.2023-06-23.at.16.32.39.mov

@reinaldosg, I think you can revert this fix. It's not a part of this PR. It's a known issue and I think there's already an issue for this on GH.

@thesahindia Oh didn't know that! I pushed the revert, please take a look again when you have time 🙏

shawnborton · 2023-06-23T11:59:31Z

should we keep the max height same as invite message field?

I think it makes sense to keep them consistent, yeah. It should just be a global component that behaves the same everywhere as much as we can.

thesahindia · 2023-06-24T11:32:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-24.at.3.28.39.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-06-24.at.3.36.50.AM.mov

Mobile Web - Safari

Screen.Recording.2023-06-24.at.3.42.18.AM.mov

Desktop

Screen.Recording.2023-06-24.at.1.51.49.PM.mov

iOS

Screen.Recording.2023-06-24.at.3.43.54.AM.mov

Android

Screen.Recording.2023-06-24.at.3.30.31.AM.mov

thesahindia

Tests well!

NOTE: In mWeb and desktop the field height will be 115 px from the start and the height will be auto adjusted on entering some text.

cc: @srikarparsi

thesahindia

@reinaldosg, it seems like the commits aren't signed.

reinaldosg · 2023-06-25T05:51:53Z

@thesahindia Hi sorry for the inconvenience. I found that for signing the existing commit, I need to force push the commit. Is that okay or do I have another way to sign the commit?

thesahindia · 2023-06-25T06:30:44Z

Yeah, you can do that.

reinaldosg · 2023-06-25T07:40:23Z

@thesahindia thanks for the confirmation! Done signing the commit!

thesahindia

Thanks @reinaldosg! It looks good now.

srikarparsi

looks good to me!

srikarparsi · 2023-06-26T19:42:34Z

Hi @reinaldosg! Tests are failing but I believe merging main into your branch should fix it. Could you try that whenever you get a chance?

reinaldosg · 2023-06-26T20:25:36Z

@srikarparsi done!

srikarparsi · 2023-06-26T22:11:21Z

Thanks @reinaldosebastian and @thesahindia!

OSBotify · 2023-06-26T23:01:42Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.33-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-28T14:06:13Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.33-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

reinaldosg requested a review from a team as a code owner June 22, 2023 17:04

melvin-bot bot requested review from NikkiWines and removed request for a team June 22, 2023 17:05

reinaldosg mentioned this pull request Jun 22, 2023

[HOLD for payment 2023-07-05] [$1000] Inconsistent input field size in close account page message field #20904

Closed

6 tasks

srikarparsi requested review from srikarparsi and thesahindia and removed request for NikkiWines June 22, 2023 17:08

thesahindia reviewed Jun 23, 2023

View reviewed changes

thesahindia approved these changes Jun 24, 2023

View reviewed changes

thesahindia suggested changes Jun 24, 2023

View reviewed changes

reinaldosebastian added 2 commits June 25, 2023 14:38

Fix inconsistent input field size in close account page message field

1b36c75

Revert hidden text placeholder on BaseTextInput

93c513e

reinaldosg force-pushed the issue/20904 branch from ac95d19 to 93c513e Compare June 25, 2023 07:39

reinaldosg requested a review from thesahindia June 25, 2023 08:29

thesahindia approved these changes Jun 25, 2023

View reviewed changes

srikarparsi approved these changes Jun 26, 2023

View reviewed changes

Merge branch 'main' into issue/20904

45f665e

srikarparsi merged commit 7eacc10 into Expensify:main Jun 26, 2023

OSBotify mentioned this pull request Jun 26, 2023

Deploy Checklist: New Expensify 2023-06-26 #21650

Closed

23 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix inconsistent input field size in close account page message field #21333

Fix inconsistent input field size in close account page message field #21333

reinaldosg commented Jun 22, 2023 •

edited by srikarparsi

Loading

melvin-bot bot commented Jun 22, 2023

github-actions bot commented Jun 22, 2023 •

edited

Loading

melvin-bot bot commented Jun 22, 2023

srikarparsi commented Jun 22, 2023

reinaldosg commented Jun 22, 2023

reinaldosg commented Jun 22, 2023

reinaldosebastian commented Jun 23, 2023

reinaldosebastian commented Jun 23, 2023

thesahindia commented Jun 23, 2023

thesahindia Jun 23, 2023

reinaldosg Jun 23, 2023

thesahindia Jun 23, 2023 •

edited

Loading

reinaldosg Jun 24, 2023

shawnborton commented Jun 23, 2023

thesahindia commented Jun 24, 2023

thesahindia left a comment

thesahindia left a comment

reinaldosg commented Jun 25, 2023

thesahindia commented Jun 25, 2023

reinaldosg commented Jun 25, 2023

thesahindia left a comment

srikarparsi left a comment

srikarparsi commented Jun 26, 2023

reinaldosg commented Jun 26, 2023

srikarparsi commented Jun 26, 2023

OSBotify commented Jun 26, 2023

OSBotify commented Jun 28, 2023

Fix inconsistent input field size in close account page message field #21333

Fix inconsistent input field size in close account page message field #21333

Conversation

reinaldosg commented Jun 22, 2023 • edited by srikarparsi Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 22, 2023

github-actions bot commented Jun 22, 2023 • edited Loading

melvin-bot bot commented Jun 22, 2023

srikarparsi commented Jun 22, 2023

reinaldosg commented Jun 22, 2023

reinaldosg commented Jun 22, 2023

reinaldosebastian commented Jun 23, 2023

reinaldosebastian commented Jun 23, 2023

thesahindia commented Jun 23, 2023

thesahindia Jun 23, 2023

Choose a reason for hiding this comment

reinaldosg Jun 23, 2023

Choose a reason for hiding this comment

thesahindia Jun 23, 2023 • edited Loading

Choose a reason for hiding this comment

reinaldosg Jun 24, 2023

Choose a reason for hiding this comment

shawnborton commented Jun 23, 2023

thesahindia commented Jun 24, 2023

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

thesahindia left a comment

Choose a reason for hiding this comment

reinaldosg commented Jun 25, 2023

thesahindia commented Jun 25, 2023

reinaldosg commented Jun 25, 2023

thesahindia left a comment

Choose a reason for hiding this comment

srikarparsi left a comment

Choose a reason for hiding this comment

srikarparsi commented Jun 26, 2023

reinaldosg commented Jun 26, 2023

srikarparsi commented Jun 26, 2023

OSBotify commented Jun 26, 2023

OSBotify commented Jun 28, 2023

reinaldosg commented Jun 22, 2023 •

edited by srikarparsi

Loading

github-actions bot commented Jun 22, 2023 •

edited

Loading

thesahindia Jun 23, 2023 •

edited

Loading