-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grab the users custom avatar or default avatar to display properly #20727
Conversation
@Santhosh-Sellavel @hayata-suenaga One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
const displayName = getDisplayNameForParticipant(participant.login, isMultipleParticipantReport); | ||
const avatar = UserUtils.getDefaultAvatar(participant.login); | ||
const avatar = UserUtils.getAvatar(personalDetails.avatar, participant.login); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const avatar = UserUtils.getAvatar(personalDetails.avatar, participant.login); | |
const {avatar} = getPersonalDetailsForLogin(participant.login); |
@bondydaa I think we can simply get avatar from getPersonalDetailsForLogin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fedirjh Please have a look again getPersonalDetailsForLogin
doesn't always have an avatar, so it seems fine to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Santhosh-Sellavel It either return allPersonalDetails[login]
which have avatar , or it construct a default object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allPersonalDetails[login] might not have an avatar if not set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay then!
Is this a regression PR? |
Yes |
@bondydaa I have a second thought about the root cause. Actually, the
I believe the root cause is that we are not passing the App/src/pages/ReportParticipantsPage.js Line 79 in 0a471b0
|
@fedirjh Can you test your proposed solution if it works well? |
@mountiny Tested and works as expected. tooltip.mov |
@bondydaa ok so should we just live with this problem for a bit and let it be handled in here https://github.com/Expensify/App/pull/20473/files#diff-cfc1b0041979edd1cf120bf6f6b714a0c81f0562ee1aafbda836ce61aae559d5? we plan to merge that today |
okay closing this then. |
Details
I believe this came from #20276 because it was using
getDefaultAvatar
which will only ever grab the default avatar for a user and never one they might have uploaded. I believe this new method will first grab a custom one if present then default to the default avatar if it needs to but honestly I'm really confused byUserUtils.getAvatar
since you have to pass it the url you think you want 🤷Fixed Issues
$ #20683
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android