Fix the navigation to chat group member profiles #20612

PauloGasparSv · 2023-06-12T18:13:58Z

Details

If you create a group it will show all the member emails/profiles + a welcome message

If you click on any member mentioned there it should take you to that member's profile page (where you can check that user's public info and choose to chat 1:1 with them).

This P.R. fixes a bug where refreshing the page would change the order of some internal arrays causing this feature to navigate you to the wrong profile.

Fixed Issues

$ #20583
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Start a group chat and make sure to include
- An SMS/phoneNumber account
- An account with no Display name
- An account with the display name filled
- An account that exists and you didn't chat with before
Verify each member is mentioned in the Welcome message and that clicking on their mentions takes you to the correct profile page.
Refresh the page in Web/mWeb and Sign Off then back in for other platforms
Verify that each member link in the Welcome message still takes you to their correct profile page (instead of before where it would take you to the wrong member's profile)

Verify that no errors appear in the JS console

Offline tests

N/A, this happens after redirecting or signing in and that requires connectivity.

QA Steps

Start a group chat and make sure to include
- An SMS/phoneNumber account
- An account with no Display name
- An account with the display name filled
- An account that exists and you didn't chat with before
Verify each member is mentioned in the Welcome message and that clicking on their mentions takes you to the correct profile page. (Except for the account you didn't have a chat with before since you don't have connectivity to fetch their info)
Refresh the page in Web/mWeb and Sign Off then back in for other platforms
Verify that each member link in the Welcome message still takes you to their correct profile page (instead of before where it would take you to the wrong member's profile) (Except for the account you didn't have a chat with before since you don't have connectivity to fetch their info)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mweb.Android.mov

Mobile Web - Safari

ios.mweb.mov

Desktop

Desktop.mov

iOS

iOS.native.mov

Android

Android.mov

melvin-bot · 2023-06-12T18:14:33Z

@aimane-chnaif @bondydaa One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

PauloGasparSv · 2023-06-12T18:16:16Z

Adding evidences right now!

PauloGasparSv · 2023-06-12T18:18:05Z

I think @bondydaa might be OOO so I'll try to re-assign this

melvin-bot · 2023-06-12T18:18:44Z

@mananjadhav @bondydaa One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2023-06-12T18:19:53Z

Since this is deploy blocker, reviewing now as top priority

PauloGasparSv · 2023-06-12T18:21:41Z

Thks so much! I failed to re-assign another internal engineer so will ask if anyone wants to take a look at it internally!

Will un-assign @mananjadhav sorry for that!!

mountiny

@aimane-chnaif let us know once done with testing

mountiny · 2023-06-12T18:30:52Z

src/components/ReportWelcomeText.js

+                                            const accountDetails = props.personalDetails[OptionsListUtils.addSMSDomainIfPhoneNumber(displayNamesWithTooltips[index].tooltip)];
+                                            if (accountDetails && accountDetails.accountID) {
+                                                Navigation.navigate(ROUTES.getProfileRoute(accountDetails.accountID));
+                                            }


Tagging @Beamanator as I believe this might have to be included in your refactor PR

PauloGasparSv · 2023-06-12T18:36:04Z

I think we have a problem with this fix! I'm checking right now and I think personalDetails doesn't have new contact data, so creating a group with a new Contact breaks this!

I think I'll have to use another object other than personalDetails!

src/components/ReportWelcomeText.js

PauloGasparSv · 2023-06-12T18:44:59Z

I changed the logic to search for the email/login index in participants then grab the id from participantAccountIDs and now I'm testing!

onPress={() => {
    const participantIndex = _.indexOf(participants, OptionsListUtils.addSMSDomainIfPhoneNumber(displayNamesWithTooltips[index].tooltip));
    if (participantIndex > -1) {
        Navigation.navigate(ROUTES.getProfileRoute(participantAccountIDs[participantIndex]));
    }
}}

aimane-chnaif · 2023-06-12T18:45:17Z

I think we have a problem with this fix! I'm checking right now and I think personalDetails doesn't have new contact data, so creating a group with a new Contact breaks this!

I think I'll have to use another object other than personalDetails!

This works fine for me in online but not offline.
Is it possible to get accountID from login without fetching from backend?

Screen.Recording.2023-06-12.at.7.42.36.PM.mov

PauloGasparSv · 2023-06-12T18:48:36Z

This works fine for me in online but not offline.
Is it possible to get accountID from login without fetching from backend?

Double checking that right now!
Maybe this is happening when the account also doesn't exist, saying that because I'm seeing some new bugs with this other approach that indicate that.

Is it possible to get accountID from login without fetching from backend?

Oh that makes total sense, I'll mention that in the offline step as expected behaviour since IMO it is!

…sage profile logic

aimane-chnaif · 2023-06-12T18:58:05Z

Is it possible to get accountID from login without fetching from backend?

Oh that makes total sense, I'll mention that in the offline step as expected behaviour since IMO it is!

If this is really true, is there any frontend logic to get accountID from login?
I am testing the case when create new group chat with new accounts in offline mode

PauloGasparSv · 2023-06-12T18:59:08Z

I am testing the case when create new group chat with new accounts in offline mode

I don't think there is a way to know that new Account's accountID without connectivity right? So that's why I think we should consider it intended behavior, you can't check someone's profile and info without connection : )

Please LMK if I'm wrong on this!

aimane-chnaif · 2023-06-12T18:59:52Z

I am testing the case when create new group chat with new accounts in offline mode

I don't think there is a way to know that new Account's accountID without connectivity right? So that's why I think we should consider it intended behavior, you can't check someone's profile and info without connection : )

ok so this feature should not be available in offline mode until get connection and fetch contacts list.

PauloGasparSv · 2023-06-12T19:00:46Z

ok so this feature should not be available in offline mode until get connection and fetch contacts list.

I think so! Updated QA steps for that and added tests for new accounts you didn't have a chat with before.

aimane-chnaif · 2023-06-12T19:01:08Z

@mountiny can you double confirm?

aimane-chnaif · 2023-06-12T19:18:19Z

So there's no user feedback for now when click display name that doesn't have accountID.
We can polish this later but NAB for this PR.

aimane-chnaif · 2023-06-12T19:22:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop.mov

iOS

ios.mov

Android

mountiny

Thanks @PauloGasparSv and @aimane-chnaif

PauloGasparSv · 2023-06-12T19:39:29Z

Thks for the super speedy reviews too!

PauloGasparSv · 2023-06-12T19:39:51Z

Will ask for a CP to staging!
Actually discussing that here : p

OSBotify · 2023-06-12T19:43:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2023-06-12T20:09:49Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

…act-profile-navigation Fix the navigation to chat group member profiles (cherry picked from commit 15d8c11)

…-20612 🍒 Cherry pick PR #20612 to staging 🍒

OSBotify · 2023-06-12T20:55:55Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.26-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-13T00:21:51Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:24:27Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:42:15Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Paulo Vale added 2 commits June 12, 2023 15:05

Search for correct accountID in groups when navigating to member profile

0213206

Remove unused variable

3f23baf

PauloGasparSv requested a review from a team as a code owner June 12, 2023 18:13

PauloGasparSv self-assigned this Jun 12, 2023

melvin-bot bot requested review from aimane-chnaif and bondydaa and removed request for a team June 12, 2023 18:14

PauloGasparSv requested review from a team and removed request for bondydaa June 12, 2023 18:18

melvin-bot bot requested review from bondydaa and removed request for a team June 12, 2023 18:18

melvin-bot bot requested a review from mananjadhav June 12, 2023 18:18

PauloGasparSv removed the request for review from mananjadhav June 12, 2023 18:21

mountiny self-requested a review June 12, 2023 18:26

mountiny previously approved these changes Jun 12, 2023

View reviewed changes

aimane-chnaif reviewed Jun 12, 2023

View reviewed changes

src/components/ReportWelcomeText.js Outdated Show resolved Hide resolved

Remove OptionsListUtils.addSMSDomainIfPhoneNumber call in welcome mes…

b9daeec

…sage profile logic

PauloGasparSv dismissed mountiny’s stale review via b9daeec June 12, 2023 18:55

PauloGasparSv requested review from mountiny and aimane-chnaif June 12, 2023 18:56

aimane-chnaif approved these changes Jun 12, 2023

View reviewed changes

mountiny approved these changes Jun 12, 2023

View reviewed changes

PauloGasparSv merged commit 15d8c11 into main Jun 12, 2023

PauloGasparSv deleted the paulogasparsv-fix-group-contact-profile-navigation branch June 12, 2023 19:39

mountiny added the CP Staging label Jun 12, 2023

OSBotify pushed a commit that referenced this pull request Jun 12, 2023

Merge pull request #20612 from Expensify/paulogasparsv-fix-group-cont…

58de54d

…act-profile-navigation Fix the navigation to chat group member profiles (cherry picked from commit 15d8c11)

OSBotify mentioned this pull request Jun 12, 2023

🍒 Cherry pick PR #20612 to staging 🍒 #20617

Merged

OSBotify added a commit that referenced this pull request Jun 12, 2023

Merge pull request #20617 from Expensify/mountiny-cherry-pick-staging…

3d87704

…-20612 🍒 Cherry pick PR #20612 to staging 🍒

PauloGasparSv mentioned this pull request Jun 12, 2023

Deploy Checklist: New Expensify 2023-06-08 #20466

Closed

74 tasks

melvin-bot bot mentioned this pull request Jun 13, 2023

[$1000] [HOLD for payment 2023-06-21] [HOLD for payment 2023-06-19] Web - New Group - Wrong user details page opens on clicking at display names #20583

Closed

6 tasks

OSBotify mentioned this pull request Jun 13, 2023

Deploy Checklist: New Expensify 2023-06-12 #20640

Closed

71 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the navigation to chat group member profiles #20612

Fix the navigation to chat group member profiles #20612

PauloGasparSv commented Jun 12, 2023 •

edited

Loading

melvin-bot bot commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023

melvin-bot bot commented Jun 12, 2023

aimane-chnaif commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023

mountiny left a comment

mountiny Jun 12, 2023

PauloGasparSv commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023

aimane-chnaif commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023

aimane-chnaif commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023 •

edited

Loading

aimane-chnaif commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023 •

edited

Loading

aimane-chnaif commented Jun 12, 2023

aimane-chnaif commented Jun 12, 2023

aimane-chnaif commented Jun 12, 2023

mountiny left a comment

PauloGasparSv commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023 •

edited

Loading

OSBotify commented Jun 12, 2023

github-actions bot commented Jun 12, 2023

OSBotify commented Jun 12, 2023

OSBotify commented Jun 13, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Fix the navigation to chat group member profiles #20612

Fix the navigation to chat group member profiles #20612

Conversation

PauloGasparSv commented Jun 12, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023

melvin-bot bot commented Jun 12, 2023

aimane-chnaif commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023

mountiny left a comment

Choose a reason for hiding this comment

mountiny Jun 12, 2023

Choose a reason for hiding this comment

PauloGasparSv commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023

aimane-chnaif commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023

aimane-chnaif commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023 • edited Loading

aimane-chnaif commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023 • edited Loading

aimane-chnaif commented Jun 12, 2023

aimane-chnaif commented Jun 12, 2023

aimane-chnaif commented Jun 12, 2023

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

PauloGasparSv commented Jun 12, 2023

PauloGasparSv commented Jun 12, 2023 • edited Loading

OSBotify commented Jun 12, 2023

github-actions bot commented Jun 12, 2023

OSBotify commented Jun 12, 2023

OSBotify commented Jun 13, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

PauloGasparSv commented Jun 12, 2023 •

edited

Loading

PauloGasparSv commented Jun 12, 2023 •

edited

Loading

PauloGasparSv commented Jun 12, 2023 •

edited

Loading

PauloGasparSv commented Jun 12, 2023 •

edited

Loading