Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudpresser/user details tooltip #20276

Merged
merged 59 commits into from
Jun 12, 2023
Merged

Cloudpresser/user details tooltip #20276

merged 59 commits into from
Jun 12, 2023

Commits on Jun 10, 2023

  1. feat(userTooltip): init

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    614b283 View commit details
    Browse the repository at this point in the history

  2. feat(reportActionItem): use userTooltip

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    f856ce5 View commit details
    Browse the repository at this point in the history

  3. fix(userTooltip): proper boolean conditional

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    e3f2fc1 View commit details
    Browse the repository at this point in the history

  4. fix(userDetailsTooltip): rename index

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    8c6a4b7 View commit details
    Browse the repository at this point in the history

  5. fix(userDetailsTooltip): update imports

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    198aa5b View commit details
    Browse the repository at this point in the history

  6. style(userDetailsTooltip): use function instead of const 

    Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>
    @cloudpresser @fedirjh
    cloudpresser and fedirjh committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    34f12e9 View commit details
    Browse the repository at this point in the history

  7. style(userDetailsTooltip): cast string to boolean 

    Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>
    @cloudpresser @fedirjh
    cloudpresser and fedirjh committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    e6eb717 View commit details
    Browse the repository at this point in the history

  8. style(userDetailsTooltip): don't destructure props

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    f7bde40 View commit details
    Browse the repository at this point in the history

  9. fix(userDetailsTooltip): useCallback

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    9840b18 View commit details
    Browse the repository at this point in the history

  10. style(userDetailsTooltip): new line

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    5722575 View commit details
    Browse the repository at this point in the history

  11. fix(userDetailsTooltip): propTypes

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    4fa3e52 View commit details
    Browse the repository at this point in the history

  12. feat(userDetailsTooltip): correct styles

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    4535ee0 View commit details
    Browse the repository at this point in the history

  13. feat(userDetailsTooltip): use login instead of handle

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    48f5af8 View commit details
    Browse the repository at this point in the history

  14. feat(userDetailsTooltip): use on LHN users

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    48557bb View commit details
    Browse the repository at this point in the history

  15. chore: lint

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    1d9a457 View commit details
    Browse the repository at this point in the history

  16. Merge remote-tracking branch 'upstream/main' into cloudpresser/userDe… 

    …tailsTooltip
    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    1e94377 View commit details
    Browse the repository at this point in the history

  17. feat(userDetailsTooltip): use it in mentions

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    aaa593b View commit details
    Browse the repository at this point in the history

  18. feat(userDetailsTooltip): use it in detailsPage

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    709a6b3 View commit details
    Browse the repository at this point in the history

  19. Revert "feat(userDetailsTooltip): use it in mentions" 

    This reverts commit c8f6f45425745e19108797402a9e3fb0941e90cf.
    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    efd0580 View commit details
    Browse the repository at this point in the history

  20. refactor(userDetailsTooltip): use accountID

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    6d2736c View commit details
    Browse the repository at this point in the history

  21. feat(userDetailsTooltip): use it on report welcome

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    77cb99c View commit details
    Browse the repository at this point in the history

  22. fix(userDetailsTooltip): render issue

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    d6fadfc View commit details
    Browse the repository at this point in the history

  23. fix(sideBarLinks): pass accountID to avatar

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    24aa674 View commit details
    Browse the repository at this point in the history

  24. fix(sidebarLinks): revert tooltip changes

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    7941eca View commit details
    Browse the repository at this point in the history

  25. Update src/components/DisplayNames/displayNamesPropTypes.js 

    Co-authored-by: Puneet Lath <puneet@expensify.com>
    @cloudpresser @puneetlath
    cloudpresser and puneetlath authored Jun 10, 2023
    Configuration menu
    Copy the full SHA
    b0b1a05 View commit details
    Browse the repository at this point in the history

  26. Update src/components/UserDetailsTooltip/userDetailsTooltipPropTypes.js 

    Co-authored-by: Puneet Lath <puneet@expensify.com>
    @cloudpresser @puneetlath
    cloudpresser and puneetlath authored Jun 10, 2023
    Configuration menu
    Copy the full SHA
    da0dcd3 View commit details
    Browse the repository at this point in the history

  27. Update src/components/DisplayNames/displayNamesPropTypes.js 

    Co-authored-by: Puneet Lath <puneet@expensify.com>
    @cloudpresser @puneetlath
    cloudpresser and puneetlath authored Jun 10, 2023
    Configuration menu
    Copy the full SHA
    0f3c1f2 View commit details
    Browse the repository at this point in the history

  28. Update src/components/UserDetailsTooltip/userDetailsTooltipPropTypes.js 

    Co-authored-by: Puneet Lath <puneet@expensify.com>
    @cloudpresser @puneetlath
    cloudpresser and puneetlath authored Jun 10, 2023
    Configuration menu
    Copy the full SHA
    ff1a4ec View commit details
    Browse the repository at this point in the history

  29. fix(reportActionItem): fragment props

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    9ac3b90 View commit details
    Browse the repository at this point in the history

  30. fix(reportActionItemMessage): pass accountID

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    a7c5077 View commit details
    Browse the repository at this point in the history

  31. chore: eslint --fix

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    0fed1bd View commit details
    Browse the repository at this point in the history

  32. chore: remove unused prop

    @cloudpresser
    cloudpresser committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    b656d43 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. fix: fallback avatar not avatarSource

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    cf3a4ad View commit details
    Browse the repository at this point in the history

  2. fix(userDetailsTooltip): avatar propType

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    8f85240 View commit details
    Browse the repository at this point in the history

  3. feat(userDetailsTooltip): remove sms domain

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    1c14280 View commit details
    Browse the repository at this point in the history

  4. chore: lint

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    3608e48 View commit details
    Browse the repository at this point in the history

  5. fix(userDetailsTooltip): condition to hide

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    a285d7e View commit details
    Browse the repository at this point in the history

  6. chore: use lodashGet

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    8eaf9bf View commit details
    Browse the repository at this point in the history

  7. chore: use lodashget

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    65a1103 View commit details
    Browse the repository at this point in the history

  8. test: update expectations

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    07fd999 View commit details
    Browse the repository at this point in the history

  9. chore: rename UserDetailsTooltip.js to index.js

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    68c1ed0 View commit details
    Browse the repository at this point in the history

  10. chore: prettier

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    e1dd0bf View commit details
    Browse the repository at this point in the history

  11. feat(userDetailsTooltip): early return

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    1ba85f2 View commit details
    Browse the repository at this point in the history

  12. fix: add concierge email on name for tooltip

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    8bc46ce View commit details
    Browse the repository at this point in the history

  13. chore: prettier

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    3922f09 View commit details
    Browse the repository at this point in the history

  14. fix: styles

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    ccc7229 View commit details
    Browse the repository at this point in the history

  15. refactor: create getAccoutIdForLogin function

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    245a284 View commit details
    Browse the repository at this point in the history

  16. test: update expectations

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    fca8b1e View commit details
    Browse the repository at this point in the history

  17. feat(getDisplayNamesWithTooltips): use accountID directly

    @cloudpresser
    cloudpresser committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    a97bf9b View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. chore: prettier

    @cloudpresser
    cloudpresser committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    89e626a View commit details
    Browse the repository at this point in the history

  2. fix: displayNamesPropTypes accountID

    @cloudpresser
    cloudpresser committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    c275f20 View commit details
    Browse the repository at this point in the history

  3. fix: accept numbers or strings 

    Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>
    @cloudpresser @fedirjh
    cloudpresser and fedirjh authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    50ef668 View commit details
    Browse the repository at this point in the history

  4. Update src/components/MultipleAvatars.js 

    Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>
    @cloudpresser @fedirjh
    cloudpresser and fedirjh authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    56bb67b View commit details
    Browse the repository at this point in the history

  5. feat: hide email when displayName is equal

    @cloudpresser
    cloudpresser committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    a8455fb View commit details
    Browse the repository at this point in the history

  6. fix: do not return text inside view 

    Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>
    @cloudpresser @fedirjh
    cloudpresser and fedirjh authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    b844737 View commit details
    Browse the repository at this point in the history

  7. Update src/components/UserDetailsTooltip/index.js 

    Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>
    @cloudpresser @fedirjh
    cloudpresser and fedirjh authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    3b52187 View commit details
    Browse the repository at this point in the history

  8. test: update displayNamesWithTooltips expectation

    @cloudpresser
    cloudpresser committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    cb8c6ca View commit details
    Browse the repository at this point in the history

  9. feat(displayNamesWithTooltips): avatar and login

    @cloudpresser
    cloudpresser committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    562244c View commit details
    Browse the repository at this point in the history

  10. feat(displayNames): fallback tooltips

    @cloudpresser
    cloudpresser committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    a0ea50d View commit details
    Browse the repository at this point in the history