Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17046 — migrate PressableWithotFocus to GenericPressable #20202

Merged
merged 18 commits into from
Jun 16, 2023
Merged

17046 — migrate PressableWithotFocus to GenericPressable #20202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f42e37e
migrate PressableWithotFocus to GenericPressable
robertKozik Jun 5, 2023
924e96a
hoist GenericPressable proptypes to PressableWithoutFocus
robertKozik Jun 6, 2023
c1d7329
move PressableWithoutFoucs to Pressable folder
robertKozik Jun 7, 2023
bcea8ea
fix propTypes of PressableWithFeedback - add missing propTypes
robertKozik Jun 7, 2023
0f9bc39
hoist propTypes of ImageRenderer to the top of the file as stated in …
robertKozik Jun 7, 2023
af0e8c4
Remove wrapperStyle proptype from PressableWithFeedback.js
robertKozik Jun 12, 2023
1f4d4b9
rename styling prop of PressableWithoutFocus to 'style'
robertKozik Jun 12, 2023
a6333e5
fix lint
robertKozik Jun 12, 2023
fa9ca8b
Merge branch 'main' into 17046-migrate-PressableWithoutFocus
robertKozik Jun 12, 2023
6e47178
change import of PressableWithoutFocus in ProfilePage.js
robertKozik Jun 12, 2023
6bfc85a
add accessibilityLabel for ProfilePage, pass styles as arrays
robertKozik Jun 12, 2023
65afa46
Merge branch 'main' into 17046-migrate-PressableWithoutFocus
robertKozik Jun 14, 2023
ebce2d6
Change accessibility role of ImageRenderer pressable to imagebutton
robertKozik Jun 14, 2023
9b167ac
fix omitted prop name in PressableWithoutFocus
robertKozik Jun 14, 2023
10e3774
change accessibilityRole from button to imagebutton
robertKozik Jun 14, 2023
8734e0b
change accessibility label for ImageRenderer component
robertKozik Jun 15, 2023
afb9b28
fix typo in translations
robertKozik Jun 15, 2023
30e0a94
Merge branch 'main' into 17046-migrate-PressableWithoutFocus
robertKozik Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function ImageRenderer(props) {
onPress={show}
onLongPress={(event) => showContextMenuForReport(event, anchor, report.reportID, action, checkIfContextMenuActive, ReportUtils.isArchivedRoom(report))}
accessibilityRole="imagebutton"
accessibilityLabel={props.translate('common.attachment')}
accessibilityLabel={props.translate('accessibilityHints.viewAttachment')}
>
<ThumbnailImage
previewSourceURL={previewSource}
Expand Down
1 change: 1 addition & 0 deletions src/languages/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1397,6 +1397,7 @@ export default {
chatUserDisplayNames: 'Chat user display names',
scrollToNewestMessages: 'Scroll to newest messages',
prestyledText: 'Prestyled text',
viewAttachment: 'View Attachment',
robertKozik marked this conversation as resolved.
Show resolved Hide resolved
},
parentReportAction: {
deletedMessage: '[Deleted message]',
Expand Down
1 change: 1 addition & 0 deletions src/languages/es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1863,6 +1863,7 @@ export default {
chatUserDisplayNames: 'Nombres de los usuarios del chat',
scrollToNewestMessages: 'Desplázate a los mensajes más recientes',
prestyledText: 'texto preestilizado',
viewAttachment: 'Ver archivo adjunto',
},
parentReportAction: {
deletedMessage: '[Mensaje eliminado]',
Expand Down