Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Emoji Picker #1991

Merged
merged 95 commits into from
Apr 15, 2021
Merged

Add Emoji Picker #1991

merged 95 commits into from
Apr 15, 2021

Commits on Feb 23, 2021

  1. Add emoji list

    @stitesExpensify
    stitesExpensify committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    89c1fe9 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Merge branch 'master' of github.com:Expensify/Expensify.cash into sti… 

    …tes-emojipicker2
    @stitesExpensify
    stitesExpensify committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    b8f3230 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Add emoji picker components and link them to reportActionCompose

    @stitesExpensify
    stitesExpensify committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    3aef3db View commit details
    Browse the repository at this point in the history

  2. Update emoji list to use unicode escaped strings

    @stitesExpensify
    stitesExpensify committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    e63876e View commit details
    Browse the repository at this point in the history

  3. Update to a flatlist and add method to add emoji to the textInput

    @stitesExpensify
    stitesExpensify committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    5841cb5 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Add emoji icon

    @stitesExpensify
    stitesExpensify committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    7c757d6 View commit details
    Browse the repository at this point in the history

  2. Update emoji list to have headers instead of individual arrays per ca… 

    …tegory
    @stitesExpensify
    stitesExpensify committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    96b2e43 View commit details
    Browse the repository at this point in the history

  3. Add emoji icon to expensicons list

    @stitesExpensify
    stitesExpensify committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    18e4c1e View commit details
    Browse the repository at this point in the history

  4. Use emoji button instead of send

    @stitesExpensify
    stitesExpensify committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    cd72afd View commit details
    Browse the repository at this point in the history

  5. Add styles for emoji picker button

    @stitesExpensify
    stitesExpensify committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    35dd8ae View commit details
    Browse the repository at this point in the history

  6. Update structure to match SectionList requirements

    @stitesExpensify
    stitesExpensify committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    abf77ce View commit details
    Browse the repository at this point in the history

  7. Re-format back to having all emojis in a single list

    @stitesExpensify
    stitesExpensify committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    b75744e View commit details
    Browse the repository at this point in the history

  8. Add basic search

    @stitesExpensify
    stitesExpensify committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    c17f51a View commit details
    Browse the repository at this point in the history

  9. Add blank items to make the headers the only thing on their row

    @stitesExpensify
    stitesExpensify committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    4297646 View commit details
    Browse the repository at this point in the history

  10. Update indicies to be static and add code to account for blank items

    @stitesExpensify
    stitesExpensify committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    0d4862d View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Differentiate between pre-label blanks and post-label inline blanks

    @stitesExpensify
    stitesExpensify committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    885f570 View commit details
    Browse the repository at this point in the history

  2. Pad headers

    @stitesExpensify
    stitesExpensify committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    0f8454f View commit details
    Browse the repository at this point in the history

  3. Remove header bar distinction

    @stitesExpensify
    stitesExpensify committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    d16fb6f View commit details
    Browse the repository at this point in the history

  4. Update styles to have a 100% header width

    @stitesExpensify
    stitesExpensify committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    f33c9a3 View commit details
    Browse the repository at this point in the history

  5. Add toLowerCase to make sure that we find search terms properly

    @stitesExpensify
    stitesExpensify committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    fb9fc8d View commit details
    Browse the repository at this point in the history

  6. Remove garbage emojis

    @stitesExpensify
    stitesExpensify committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    857274f View commit details
    Browse the repository at this point in the history

  7. Remove testing changes

    @stitesExpensify
    stitesExpensify committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    08daae6 View commit details
    Browse the repository at this point in the history

  8. Update styles

    @stitesExpensify
    stitesExpensify committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    cde5d7a View commit details
    Browse the repository at this point in the history

  9. Style

    @stitesExpensify
    stitesExpensify committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    9905e4f View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Focus on open

    @stitesExpensify
    stitesExpensify committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1c7d547 View commit details
    Browse the repository at this point in the history

  2. Space emojis evenly

    @stitesExpensify
    stitesExpensify committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    205c9b3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:Expensify/Expensify.cash into sti… 

    …tes-emojipicker2
    @stitesExpensify
    stitesExpensify committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b078bff View commit details
    Browse the repository at this point in the history

  4. Emoji styles

    @shawnborton
    shawnborton committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    33b210f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'stites-emojipicker2' of github.com:Expensify/Expensify.… 

    …cash into stites-emojipicker2
    @shawnborton
    shawnborton committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    570fb7d View commit details
    Browse the repository at this point in the history

  6. Remove color swatches from emojis

    @stitesExpensify
    stitesExpensify committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    9f4856e View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. More style clean up

    @shawnborton
    shawnborton committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    7b1b7ff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'stites-emojipicker2' of github.com:Expensify/Expensify.… 

    …cash into stites-emojipicker2
    @shawnborton
    shawnborton committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    b213d60 View commit details
    Browse the repository at this point in the history

  3. Fix sticky headers on search

    @stitesExpensify
    stitesExpensify committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    719e495 View commit details
    Browse the repository at this point in the history

  4. Use textInput or comment to add emoji to textInput

    @stitesExpensify
    stitesExpensify committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    e11297d View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Remove unused import

    @stitesExpensify
    stitesExpensify committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    61a16f2 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. re-add react

    @stitesExpensify
    stitesExpensify committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    f56e00a View commit details
    Browse the repository at this point in the history

  2. Remove bottom padding on small screens

    @stitesExpensify
    stitesExpensify committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    09c9a65 View commit details
    Browse the repository at this point in the history

  3. Make emoji picker button and emojis in picker hoverable

    @stitesExpensify
    stitesExpensify committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    e58e847 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Alphabetize expensicons

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    20f971f View commit details
    Browse the repository at this point in the history

  2. Comments for props and state vars

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    7eab869 View commit details
    Browse the repository at this point in the history

  3. Use underscore each instead of forEach

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    5906af7 View commit details
    Browse the repository at this point in the history

  4. Remove brackets around single styles

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    b199f89 View commit details
    Browse the repository at this point in the history

  5. Null initialize ref

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    9ed44c8 View commit details
    Browse the repository at this point in the history

  6. Bind renderItem instead of using an arrow function to increase perfor… 

    …mance
    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    803db87 View commit details
    Browse the repository at this point in the history

  7. undefined instead of null

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    48399a8 View commit details
    Browse the repository at this point in the history

  8. Rename vars to specify they are related to the emoji picker

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    074af23 View commit details
    Browse the repository at this point in the history

  9. Remove useless style

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    47826b9 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary styles

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    39b69c1 View commit details
    Browse the repository at this point in the history

  11. Remove unnecessary isVisible prop

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    35cacd0 View commit details
    Browse the repository at this point in the history

  12. Refactor PopoverWithMeasuredContent to just measure its children rath… 

    …er than a separate prop
    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    fb2c270 View commit details
    Browse the repository at this point in the history

  13. Return early and use find to make sure we only put each emoji in once

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    550fc21 View commit details
    Browse the repository at this point in the history

  14. add method docs

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8aa1555 View commit details
    Browse the repository at this point in the history

  15. rename onPress function prop

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    17a74b3 View commit details
    Browse the repository at this point in the history

  16. Update props

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    0d51fbc View commit details
    Browse the repository at this point in the history

  17. Add hover style to styles instead of inline

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    6810b75 View commit details
    Browse the repository at this point in the history

  18. Change from 'blank' to 'SPACER' and make it a constant

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    382a878 View commit details
    Browse the repository at this point in the history

  19. Make the numColumns a constant in the constructor with comments about… 

    … the implications of changing it
    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8b9c0b1 View commit details
    Browse the repository at this point in the history

  20. DRY and add more comments/warnings

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    9f64d4c View commit details
    Browse the repository at this point in the history

  21. Use nativeEvent directly since it will always exist

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    184785e View commit details
    Browse the repository at this point in the history

  22. move emojiPopoverAnchorPosition into state

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    0055378 View commit details
    Browse the repository at this point in the history

  23. Add isVisible prop to make sure we only focus when the modal is visible

    @stitesExpensify
    stitesExpensify committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    b1b6f53 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Let parent modal decide when the menu is visible

    @stitesExpensify
    stitesExpensify committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    26e8503 View commit details
    Browse the repository at this point in the history

  2. Update to have static width and height, use a normal popover

    @stitesExpensify
    stitesExpensify committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    7907a97 View commit details
    Browse the repository at this point in the history

  3. Fix styles

    @stitesExpensify
    stitesExpensify committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    26fa00d View commit details
    Browse the repository at this point in the history

  4. Reduce debounce

    @stitesExpensify
    stitesExpensify committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    5e6b602 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Merge branch 'master' of github.com:Expensify/Expensify.cash into sti… 

    …tes-emojipicker2
    @stitesExpensify
    stitesExpensify committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    c88377f View commit details
    Browse the repository at this point in the history

  2. Remove auto-focus

    @stitesExpensify
    stitesExpensify committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    4e25b8f View commit details
    Browse the repository at this point in the history

  3. Remove unused prop

    @stitesExpensify
    stitesExpensify committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    388d424 View commit details
    Browse the repository at this point in the history

  4. Remove unused prop

    @stitesExpensify
    stitesExpensify committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    9557dd7 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Use this.comment as source of truth to prevent weird bugs

    @stitesExpensify
    stitesExpensify committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    23a5f08 View commit details
    Browse the repository at this point in the history

  2. Blur main compose box before showing picker to prevent having to doub… 

    …le tap on emojis
    @stitesExpensify
    stitesExpensify committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    7a0fc9a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Merge branch 'master' of github.com:Expensify/Expensify.cash into sti… 

    …tes-emojipicker2
    @stitesExpensify
    stitesExpensify committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    e127abf View commit details
    Browse the repository at this point in the history

  2. Remove refactor of PopoverWithMeasuredContent since I'm not touching … 

    …it anymore
    @stitesExpensify
    stitesExpensify committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    012a486 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Merge branch 'master' of github.com:Expensify/Expensify.cash into sti… 

    …tes-emojipicker2
    @stitesExpensify
    stitesExpensify committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    f2c0bc1 View commit details
    Browse the repository at this point in the history

  2. Styles

    @stitesExpensify
    stitesExpensify committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    e752bc9 View commit details
    Browse the repository at this point in the history

  3. Make a native version of the emoji picker without a search bar

    @stitesExpensify
    stitesExpensify committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    4a9a842 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. fix scuffed merge

    @stitesExpensify
    stitesExpensify committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    f3c0c40 View commit details
    Browse the repository at this point in the history

  2. fix comment

    @stitesExpensify
    stitesExpensify committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    ee8e493 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary param since it's default

    @stitesExpensify
    stitesExpensify committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    29546d1 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary parens

    @stitesExpensify
    stitesExpensify committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    d508a07 View commit details
    Browse the repository at this point in the history

  5. Add pressed state to button styles

    @stitesExpensify
    stitesExpensify committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    2c7e196 View commit details
    Browse the repository at this point in the history

  6. Make comment more accurate

    @stitesExpensify
    stitesExpensify committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    9b75d6d View commit details
    Browse the repository at this point in the history

  7. Remove unused code from native picker

    @stitesExpensify
    stitesExpensify committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    ca841e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Explain animation timing hack

    @stitesExpensify
    stitesExpensify committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    cbe39fc View commit details
    Browse the repository at this point in the history

  2. Add const for picker size

    @stitesExpensify
    stitesExpensify committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    a5f795d View commit details
    Browse the repository at this point in the history

  3. move comment

    @stitesExpensify
    stitesExpensify committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    f05b5fb View commit details
    Browse the repository at this point in the history

  4. Change filter method for better readability

    @stitesExpensify
    stitesExpensify committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    ad7ac23 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Use style constants

    @stitesExpensify
    stitesExpensify committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    22be396 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:Expensify/Expensify.cash into sti… 

    …tes-emojipicker2
    @stitesExpensify
    stitesExpensify committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    6e3c787 View commit details
    Browse the repository at this point in the history

  3. lint style

    @stitesExpensify
    stitesExpensify committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    95c783b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:Expensify/Expensify.cash into sti… 

    …tes-emojipicker2
    @stitesExpensify
    stitesExpensify committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    fc9d37f View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. More scuffed merging

    @stitesExpensify
    stitesExpensify committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    0b5f628 View commit details
    Browse the repository at this point in the history

  2. Method docs

    @stitesExpensify
    stitesExpensify committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    4899e43 View commit details
    Browse the repository at this point in the history

  3. make reportActionItems pop out

    @stitesExpensify
    stitesExpensify committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    3a3856c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:Expensify/Expensify.cash into stite… 

    …s-emojipicker2
    @stitesExpensify
    stitesExpensify committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    7d97899 View commit details
    Browse the repository at this point in the history