Fix emoji reaction picker and tooltip wrong position #19659

bernhardoj · 2023-05-26T06:52:51Z

Details

This is a regression of #16052. There are 2 issues this PR trying to solve:

Hoverable component is unable to handle a ref passed as a ref object.
Some tooltips displayed below the component instead of above it.

Fixed Issues

$ #15796
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Wrong emoji picker test

Send a message
Add emoji reaction to the message
Now, press the Add Reaction button next to the emoji reaction
Verify below
Web/Desktop
Verify the emoji picker shows above the button

iOS/Android/mWeb
Verify the emoji picker shows just fine as a modal

Wrong tooltip position test

Hover over the Emoji Picker button within the Composer.
Verify that a tooltip is displayed.
Verify the tooltip is displayed above the button

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-05-26.at.16.29.02.mov

Mobile Web - Chrome

Screen.Recording.2023-05-26.at.14.42.11.mov

Mobile Web - Safari

Screen.Recording.2023-05-26.at.14.44.39.mov

Desktop

Screen.Recording.2023-05-26.at.16.32.00.mov

iOS

Screen.Recording.2023-05-26.at.14.47.21.mov

Android

Screen.Recording.2023-05-26.at.14.50.20.mov

melvin-bot · 2023-05-26T06:53:24Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-05-26T08:53:13Z

Additional screenshot of adding back the shift vertical
Slider

Emoji Categories

pecanoro · 2023-05-26T09:54:19Z

@bernhardoj I think the QA steps are incomplete!

pecanoro · 2023-05-26T09:55:15Z

I added @parasharrajat and myself to the review since this is coming from this PR: #16052

bernhardoj · 2023-05-26T09:56:02Z

Ah, I was editing it but forget to confirm the update. Upadting..

bernhardoj · 2023-05-26T10:11:27Z

Updated

src/styles/getTooltipStyles.js

parasharrajat · 2023-05-26T12:41:41Z

Rest LGTM. Testing and adding checklist.

parasharrajat · 2023-05-26T12:41:50Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-05-26.at.6.20.08.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-05-26.at.6.13.32.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-05-26.at.6.21.52.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-05-26.at.6.12.04.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-05-26.at.6.36.31.PM.mov

🔲 Android / native

Screen.Recording.2023-05-26.at.6.35.45.PM.mov

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

cc: @pecanoro

🎀 👀 🎀 C+ reviewed

pecanoro · 2023-05-26T13:14:09Z

Reviewing and testing!

pecanoro · 2023-05-26T14:32:06Z

Is there a reason why the categories tooltip show much higher than other tooltips?

bernhardoj · 2023-05-26T14:34:43Z

The emoji category has a shift vertical of -4 (it will move the tooltip up by 4)

pecanoro · 2023-05-26T14:35:31Z

Yeah, I know that's the cause, but is that on purpose? Like why do we do that for the categories and not the others?

bernhardoj · 2023-05-26T14:38:13Z

Like why do we do that for the categories and not the others

I don't have an answer to this but based on this comment, the shiftVertical is intentional.

Oh, I guess the reason is this

pecanoro · 2023-05-26T14:43:24Z

Got it! Merging then

OSBotify · 2023-05-26T14:52:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

parasharrajat · 2023-05-26T15:24:36Z

Thanks @pecanoro

rushatgabhane · 2023-05-26T19:23:11Z

This should have been CP'd to staging because it fixes a deploy blocker #19687

aldo-expensify · 2023-05-26T20:00:02Z

Requested CP to staging here: https://expensify.slack.com/archives/C07J32337/p1685131111481409

aldo-expensify · 2023-05-26T22:37:28Z

The CP will be done on Monday. No deploy to production is happening today anyway.

Fix emoji reaction picker and tooltip wrong position (cherry picked from commit 0600c65)

…ing-19659 🍒 Cherry pick PR #19659 to staging 🍒

OSBotify · 2023-05-29T16:21:33Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.3.19-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-05-29T23:36:12Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.19-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:26:57Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:44:46Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bernhardoj added 2 commits May 26, 2023 14:10

remove unnecessary clone and ref

476ee30

handle ref object

e7ab151

bernhardoj requested a review from a team as a code owner May 26, 2023 06:52

melvin-bot bot requested review from cristipaval and removed request for a team May 26, 2023 06:53

bernhardoj mentioned this pull request May 26, 2023

refactor tooltip to fix double focusable component #16052

Merged

55 tasks

bernhardoj added 2 commits May 26, 2023 16:51

add shift vertical back

03eae98

improve overlapping element check for an element with border radius

e8f0da3

pecanoro requested review from parasharrajat and pecanoro May 26, 2023 09:52

bernhardoj changed the title ~~Fix emoji reaction picker wrong position~~ Fix emoji reaction picker and tooltip wrong position May 26, 2023

parasharrajat suggested changes May 26, 2023

View reviewed changes

src/styles/getTooltipStyles.js Outdated Show resolved Hide resolved

src/styles/getTooltipStyles.js Outdated Show resolved Hide resolved

update variable name

a05f04c

parasharrajat reviewed May 26, 2023

View reviewed changes

src/styles/getTooltipStyles.js Show resolved Hide resolved

add comment

de55100

parasharrajat approved these changes May 26, 2023

View reviewed changes

cristipaval removed their request for review May 26, 2023 13:13

pecanoro approved these changes May 26, 2023

View reviewed changes

pecanoro merged commit 0600c65 into Expensify:main May 26, 2023

parasharrajat mentioned this pull request May 26, 2023

[HOLD for newdot C+ payment] [$1000] Web - Emoji Reaction - Reaction emoji is highlighted twice when using Tab key #15796

Closed

6 tasks

fedirjh mentioned this pull request May 26, 2023

Reaction emoji - Unable to add reaction from + menu #19687

Closed

6 tasks

OSBotify pushed a commit that referenced this pull request May 29, 2023

Merge pull request #19659 from bernhardoj/fix/15796-regression

36ff8b0

Fix emoji reaction picker and tooltip wrong position (cherry picked from commit 0600c65)

OSBotify mentioned this pull request May 29, 2023

🍒 Cherry pick PR #19659 to staging 🍒 #19746

Merged

OSBotify added a commit that referenced this pull request May 29, 2023

Merge pull request #19746 from Expensify/luacmartins-cherry-pick-stag…

9130f5b

…ing-19659 🍒 Cherry pick PR #19659 to staging 🍒

OSBotify mentioned this pull request May 29, 2023

Deploy Checklist: New Expensify 2023-05-26 #19657

Closed

32 tasks

OSBotify mentioned this pull request May 30, 2023

Deploy Checklist: New Expensify 2023-05-29 #19785

Closed

44 tasks

fedirjh mentioned this pull request Jun 5, 2023

[HOLD for payment 2023-07-20] [$1000] The tooltip changes its position when changed the language preference and works well after refreshing the page #17844

Closed

6 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix emoji reaction picker and tooltip wrong position #19659

Fix emoji reaction picker and tooltip wrong position #19659

bernhardoj commented May 26, 2023 •

edited

Loading

melvin-bot bot commented May 26, 2023

bernhardoj commented May 26, 2023

pecanoro commented May 26, 2023

pecanoro commented May 26, 2023

bernhardoj commented May 26, 2023

bernhardoj commented May 26, 2023

parasharrajat commented May 26, 2023

parasharrajat commented May 26, 2023 •

edited

Loading

parasharrajat left a comment

pecanoro commented May 26, 2023

pecanoro commented May 26, 2023 •

edited

Loading

bernhardoj commented May 26, 2023

pecanoro commented May 26, 2023

bernhardoj commented May 26, 2023 •

edited

Loading

pecanoro commented May 26, 2023

OSBotify commented May 26, 2023

parasharrajat commented May 26, 2023

rushatgabhane commented May 26, 2023

aldo-expensify commented May 26, 2023

aldo-expensify commented May 26, 2023

OSBotify commented May 29, 2023

OSBotify commented May 29, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Fix emoji reaction picker and tooltip wrong position #19659

Fix emoji reaction picker and tooltip wrong position #19659

Conversation

bernhardoj commented May 26, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 26, 2023

bernhardoj commented May 26, 2023

pecanoro commented May 26, 2023

pecanoro commented May 26, 2023

bernhardoj commented May 26, 2023

bernhardoj commented May 26, 2023

parasharrajat commented May 26, 2023

parasharrajat commented May 26, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

pecanoro commented May 26, 2023

pecanoro commented May 26, 2023 • edited Loading

bernhardoj commented May 26, 2023

pecanoro commented May 26, 2023

bernhardoj commented May 26, 2023 • edited Loading

pecanoro commented May 26, 2023

OSBotify commented May 26, 2023

parasharrajat commented May 26, 2023

rushatgabhane commented May 26, 2023

aldo-expensify commented May 26, 2023

aldo-expensify commented May 26, 2023

OSBotify commented May 29, 2023

OSBotify commented May 29, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

bernhardoj commented May 26, 2023 •

edited

Loading

parasharrajat commented May 26, 2023 •

edited

Loading

pecanoro commented May 26, 2023 •

edited

Loading

bernhardoj commented May 26, 2023 •

edited

Loading