Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate SignInPage to functional component #19498

Merged
merged 19 commits into from
Jun 8, 2023
Merged

Migrate SignInPage to functional component #19498

merged 19 commits into from
Jun 8, 2023

Commits on May 23, 2023

  1. Create usePermissions hook

    @roryabraham
    roryabraham committed May 23, 2023
    Configuration menu
    Copy the full SHA
    829a8af View commit details
    Browse the repository at this point in the history

  2. Create useLocalize hook

    @roryabraham
    roryabraham committed May 23, 2023
    Configuration menu
    Copy the full SHA
    9c70f34 View commit details
    Browse the repository at this point in the history

  3. Migrate SignInPage to functional component

    @roryabraham
    roryabraham committed May 23, 2023
    Configuration menu
    Copy the full SHA
    debfadd View commit details
    Browse the repository at this point in the history

  4. Destructure props

    @roryabraham
    roryabraham committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d6c6f73 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary lodashGet

    @roryabraham
    roryabraham committed May 23, 2023
    Configuration menu
    Copy the full SHA
    c2288d6 View commit details
    Browse the repository at this point in the history

  6. Fix useLocalize

    @roryabraham
    roryabraham committed May 23, 2023
    Configuration menu
    Copy the full SHA
    eacbc0d View commit details
    Browse the repository at this point in the history

  7. Fix missing dependency

    @roryabraham
    roryabraham committed May 23, 2023
    Configuration menu
    Copy the full SHA
    5d9a914 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Simplify usePermissions hook to use context

    @roryabraham
    roryabraham committed May 24, 2023
    Configuration menu
    Copy the full SHA
    9fb84a2 View commit details
    Browse the repository at this point in the history

  2. Function keyword instead of arrow function

    @roryabraham
    roryabraham committed May 24, 2023
    Configuration menu
    Copy the full SHA
    bcae04a View commit details
    Browse the repository at this point in the history

  3. Extract conditional rendering logic to separate function

    @roryabraham
    roryabraham committed May 24, 2023
    Configuration menu
    Copy the full SHA
    2cb906c View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Clearer variable naming

    @roryabraham
    roryabraham committed May 25, 2023
    Configuration menu
    Copy the full SHA
    03f53a2 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Merge branch 'main' into Rory-HookySignInPage 

    # Conflicts:
#	src/pages/signin/SignInPage.js
    @roryabraham
    roryabraham committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    1231088 View commit details
    Browse the repository at this point in the history

  2. Fix bad merge

    @roryabraham
    roryabraham committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    6b9a9c7 View commit details
    Browse the repository at this point in the history

  3. Fix crash in UnlinkLoginForm

    @roryabraham
    roryabraham committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    1ae5d86 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into Rory-HookySignInPage

    @roryabraham
    roryabraham committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    773e231 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Merge branch 'main' into Rory-HookySignInPage

    @roryabraham
    roryabraham committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    ebc566c View commit details
    Browse the repository at this point in the history

  2. Fix isPrimaryLogin

    @roryabraham
    roryabraham committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    6ca6ff0 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Remove useMemo for welcomeHeader and welcomeText

    @roryabraham
    roryabraham committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    2972805 View commit details
    Browse the repository at this point in the history

  2. Remove unused import

    @roryabraham
    roryabraham committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    3c58737 View commit details
    Browse the repository at this point in the history