Clean up Thread UI #18876

grgia · 2023-05-12T21:55:25Z

Details

Fixed Issues

$ #18872

Tests

Verify that no errors appear in the JS console
test a thread with 100+ comments, ensure that # replies is '99+'
QA that icons are 28x28 (or 32x32 with border)
QA that small screens truncate date

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-15.at.7.16.02.PM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-05-15T18:18:11Z

@aimane-chnaif @MonilBhavsar One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MonilBhavsar · 2023-05-16T05:14:51Z

src/components/MultipleAvatars.js

@@ -40,6 +40,9 @@ const propTypes = {

    /** Whether #focus mode is on */
    isFocusMode: PropTypes.bool,
+
+    /** Whether avatars are displayed on a report */
+    isInReportView: PropTypes.bool,


This prop name looks different than what it does. Can we rename this?

MonilBhavsar · 2023-05-16T05:16:26Z

src/pages/home/report/ReportActionItemThread.js

@@ -5,11 +5,14 @@ import _ from 'underscore';
 import styles from '../../../styles/styles';
 import * as Report from '../../../libs/actions/Report';
 import withLocalize, {withLocalizePropTypes} from '../../../components/withLocalize';
+import withWindowDimensions, {windowDimensionsPropTypes} from '../../../components/withWindowDimensions';
+


NAB, empty line

Suggested change

MonilBhavsar · 2023-05-16T05:17:15Z

src/pages/home/report/ReportActionItemThread.js

@@ -24,43 +27,56 @@ const propTypes = {
    /** ID of child thread report */
    childReportID: PropTypes.string.isRequired,

-    /** localization props */
+    /** Is hovered */


Could you more detail. May be - "Is thread item/message hovered?"

MonilBhavsar · 2023-05-16T05:18:34Z

src/pages/home/report/ReportActionItemThread.js

-                        style={[styles.ml2, styles.textMicroSupporting]}
-                    >{`${props.translate('threads.lastReply')} ${props.datetimeToCalendarTime(props.mostRecentReply)}`}</Text>
+const ReportActionItemThread = (props) => {
+    const numberReplies = props.numberOfReplies > 99 ? '99+' : `${props.numberOfReplies}`;


This could be defined in CONST, something like MAX_THREAD_REPLIES_MESSAGE

MonilBhavsar · 2023-05-16T05:21:19Z

src/languages/en.js

+        today: 'Today',
+        tomorrow: 'Tomorrow',
+        yesterday: 'Yesterday',


Also, we might want to make these lowercase. Looks odd here, whereas it looks good in slack

Agreed, pushed a fix!

grgia · 2023-05-16T09:21:29Z

Ready for another round!

aimane-chnaif

BaseGenericPressable change is just for prettier?
Please pull from main. Now prettier diff is gone

src/styles/StyleUtils.js

src/styles/styles.js

stitesExpensify · 2023-05-16T17:20:59Z

@aimane-chnaif @MonilBhavsar I know it's late for y'all but if you're still around a final review of this would be great so that we can get it deployed in the next hour or so!

aimane-chnaif · 2023-05-16T17:37:09Z

reviewing in 30 min

stitesExpensify

Looking great! One small request, but it's NAB

src/pages/home/report/ReportActionItemThread.js

stitesExpensify · 2023-05-16T18:04:39Z

Waiting for @aimane-chnaif review and then we will merge

stitesExpensify · 2023-05-16T18:48:25Z

@aimane-chnaif have you had a chance to take a look yet? We want to get this merged ASAP

aimane-chnaif · 2023-05-16T18:51:33Z

checklisting right now

aimane-chnaif · 2023-05-16T19:12:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

ios.mov

Android

aimane-chnaif

Verify that no errors appear in the JS console
test a thread with 100+ comments, ensure that # replies is '99+'
QA that icons are 28x28 (or 32x32 with border)
QA that small screens truncate date

Looks good, tests well!

aimane-chnaif · 2023-05-16T19:17:04Z

NAB: It would be good to show tooltip like other subscript avatars

Screen.Recording.2023-05-16.at.8.15.59.PM.mov

aimane-chnaif · 2023-05-16T19:36:59Z

Please add Same as Tests in Offline tests, QA Steps sections

chiragsalian

LGTM

chiragsalian · 2023-05-16T19:48:06Z

I updated the QA section to mention same as tests

OSBotify · 2023-05-16T19:54:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-17T01:07:45Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.3.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif · 2023-05-17T14:12:25Z

NAB: It would be good to show tooltip like other subscript avatars

Screen.Recording.2023-05-16.at.8.15.59.PM.mov

#18876 (comment)
This will be fixed in #19074

isagoico · 2023-05-17T21:15:09Z

Issue #19142 is failing step 4 in Android only

isagoico · 2023-05-17T21:24:19Z

@aimane-chnaif Full details can be found in the issue #19142 - Here's the screenshot

OSBotify · 2023-05-18T06:50:56Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.15-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix avatar size, fix hover color

6aa4293

grgia self-assigned this May 12, 2023

grgia added 5 commits May 12, 2023 23:06

Cap number of replies to '99+'

1833a6c

Use 2px border for Small avatars

0ede1f5

Use shortened date time on small screens

902b30f

Remove date changes, truncate timestamp

a975caa

only truncate on smallscreens

8aa7825

grgia requested a review from stitesExpensify May 15, 2023 17:22

grgia added 3 commits May 15, 2023 18:27

Remove date reference

ca9537d

flex sizing

87aa63a

support for mobile ios

c9d9166

grgia marked this pull request as ready for review May 15, 2023 18:17

grgia requested a review from a team as a code owner May 15, 2023 18:17

melvin-bot bot requested review from aimane-chnaif and MonilBhavsar and removed request for a team May 15, 2023 18:18

MonilBhavsar reviewed May 16, 2023

View reviewed changes

grgia added 2 commits May 16, 2023 10:16

use lowercase for in sentence timestamp, make 99 a CONST

8cea956

Rename variable and fix comments

25781b3

grgia requested a review from MonilBhavsar May 16, 2023 09:21

aimane-chnaif reviewed May 16, 2023

View reviewed changes

src/styles/StyleUtils.js Show resolved Hide resolved

src/styles/styles.js Outdated Show resolved Hide resolved

remove unused style

c996833

grgia requested a review from aimane-chnaif May 16, 2023 13:24

Merge branch 'main' into georgia-threadStyling

adf9a93

stitesExpensify previously approved these changes May 16, 2023

View reviewed changes

src/pages/home/report/ReportActionItemThread.js Outdated Show resolved Hide resolved

numberReplies -> numberOfRepliesText

73cd845

grgia dismissed stitesExpensify’s stale review via 73cd845 May 16, 2023 17:57

grgia requested a review from stitesExpensify May 16, 2023 17:57

stitesExpensify approved these changes May 16, 2023

View reviewed changes

aimane-chnaif approved these changes May 16, 2023

View reviewed changes

chiragsalian approved these changes May 16, 2023

View reviewed changes

chiragsalian merged commit b54b16a into main May 16, 2023

chiragsalian deleted the georgia-threadStyling branch May 16, 2023 19:48

OSBotify mentioned this pull request May 16, 2023

Deploy Checklist: New Expensify 2023-05-16 #19088

Closed

71 tasks

isagoico mentioned this pull request May 17, 2023

[HOLD for payment 2023-06-01] Android - Threads - Date is not truncated and very close to screen border #19142

Closed

6 tasks

melvin-bot bot mentioned this pull request May 18, 2023

[HOLD for payment 2023-05-25] Clean up Inline Thread Replies Styles (+ handle mobile/small screen sizes) #18872

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up Thread UI #18876

Clean up Thread UI #18876

grgia commented May 12, 2023 •

edited by chiragsalian

Loading

melvin-bot bot commented May 15, 2023

MonilBhavsar May 16, 2023

MonilBhavsar May 16, 2023

MonilBhavsar May 16, 2023

MonilBhavsar May 16, 2023

MonilBhavsar May 16, 2023

grgia May 16, 2023

grgia commented May 16, 2023

aimane-chnaif left a comment

stitesExpensify commented May 16, 2023

aimane-chnaif commented May 16, 2023

stitesExpensify left a comment

stitesExpensify commented May 16, 2023

stitesExpensify commented May 16, 2023

aimane-chnaif commented May 16, 2023

aimane-chnaif commented May 16, 2023

aimane-chnaif left a comment

aimane-chnaif commented May 16, 2023

aimane-chnaif commented May 16, 2023

chiragsalian left a comment

chiragsalian commented May 16, 2023

OSBotify commented May 16, 2023

OSBotify commented May 17, 2023

aimane-chnaif commented May 17, 2023

isagoico commented May 17, 2023

isagoico commented May 17, 2023

OSBotify commented May 18, 2023

Clean up Thread UI #18876

Clean up Thread UI #18876

Conversation

grgia commented May 12, 2023 • edited by chiragsalian Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 15, 2023

MonilBhavsar May 16, 2023

Choose a reason for hiding this comment

MonilBhavsar May 16, 2023

Choose a reason for hiding this comment

MonilBhavsar May 16, 2023

Choose a reason for hiding this comment

MonilBhavsar May 16, 2023

Choose a reason for hiding this comment

MonilBhavsar May 16, 2023

Choose a reason for hiding this comment

grgia May 16, 2023

Choose a reason for hiding this comment

grgia commented May 16, 2023

aimane-chnaif left a comment

Choose a reason for hiding this comment

stitesExpensify commented May 16, 2023

aimane-chnaif commented May 16, 2023

stitesExpensify left a comment

Choose a reason for hiding this comment

stitesExpensify commented May 16, 2023

stitesExpensify commented May 16, 2023

aimane-chnaif commented May 16, 2023

aimane-chnaif commented May 16, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

aimane-chnaif commented May 16, 2023

aimane-chnaif commented May 16, 2023

chiragsalian left a comment

Choose a reason for hiding this comment

chiragsalian commented May 16, 2023

OSBotify commented May 16, 2023

OSBotify commented May 17, 2023

aimane-chnaif commented May 17, 2023

isagoico commented May 17, 2023

isagoico commented May 17, 2023

OSBotify commented May 18, 2023

grgia commented May 12, 2023 •

edited by chiragsalian

Loading