-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Spanish chars in Legal first and last name #18786
Conversation
@madmax330 @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@eVoloshchak @madmax330 Just request, can we review and merge this PR asap, so will not miss timeline bonus. Thank you. |
Reviewing this shortly |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-05-18.at.19.00.09.movMobile Web - ChromeScreen_Recording_20230518-190156_Chrome.mp4Mobile Web - SafariScreen.Recording.2023-05-18.at.18.58.29.movDesktopScreen.Recording.2023-05-18.at.19.00.38.moviOSScreen.Recording.2023-05-18.at.18.59.10.movAndroidScreen_Recording_20230518-190245_New.Expensify.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and tests well on the front end.
However, I think this should be put on hold until the back-end changes are deployed, we can't merge this now (QA won't be able to test this test properly). @madmax330, what do you think?
@PrashantMangukiya, did you confirm that Spanish localization is correct? I can ask someone from the team to confirm this if not UPD: asked here |
I took Spanish translation from google translate. It looks ok for me, but I think we can ask someone from team to confirm it is correct. So in future there will be no need of any correction. Thank you. |
src/languages/es.js
Outdated
hasInvalidCharacter: 'El nombre solo puede contener letras y números.', | ||
hasInvalidCharacter: 'El nombre solo puede incluir letras y números latinos.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the approved translation:
El nombre solo puede contener números y caracteres latinos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Pushed correct translation.
@madmax330 any suggestion about the comment #18786 (review) |
@PrashantMangukiya I will make the backend updates this week. So I think we're good to merge. Also note that we're not going to be doing any deploys today, tomorrow and Friday due to EC3 (an accounting conference we're holding) so I will have plenty of time to get the backend changes done. |
@madmax330 Thank you for update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cc: @madmax330
@madmax330, friendly bump on this |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.18-0 🚀
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.18-0 🚀
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.18-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.18-2 🚀
|
@madmax330 @eVoloshchak PR is ready for review.
Details
Spanish alphabet not accepted for Legal first name and Legal last name field on personal details page. So in this PR we corrected ui logic, so now it allows Spanish alphabet for input and does not show ui error if Spanish characters entered.
Note: In this PR we corrected UI logic, but it needs to correct backend logic also. Because at present
PersonalDetails.updateLegalName()
api is returning 200, but name isn't saved If first or last name contained a Spanish character and during save name is replaced with an empty string by server side api. So internal team will take care of it by updating backend logic. Refer this comment.Fixed Issues
$ #17628
PROPOSAL: #17628 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Chrome
Web-Chrome.mov
Safari
Web-Safari.mov
Mobile Web - Chrome
MWeb-Chrome.mov
Mobile Web - Safari
MWeb-Safari.mov
Desktop
Desktop.mov
iOS
iOS.mov
Android
Android.mov