Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix firefox redirection from old dot #18631

Merged
merged 3 commits into from
May 17, 2023
Merged

fix: fix firefox redirection from old dot #18631

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cccd3b7
fix: fix firefox redirection from old dot
koko57 May 9, 2023
660f285
Merge branch 'main' into fix/17630-oldDot-redirect-in-firefox
koko57 May 16, 2023
d9f9492
fix: apply requested changes
koko57 May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/DeeplinkWrapper/index.website.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,14 @@ class DeeplinkWrapper extends PureComponent {
openRouteInDesktopApp(expensifyDeeplinkUrl) {
this.updateAppInstallationCheckStatus();

const browser = Browser.getBrowser();

// This check is necessary for Safari, otherwise, if the user
// does NOT have the Expensify desktop app installed, it's gonna
// show an error in the page saying that the address is invalid
if (CONST.BROWSER.SAFARI === Browser.getBrowser()) {
// It is also necessary for Firefox, otherwise the window.location.href redirect
// will abort the fetch request from NetInfo, which will cause the app to go offline temporarily.
if (browser === CONST.BROWSER.SAFARI || browser === CONST.BROWSER.FIREFOX) {
const iframe = document.createElement('iframe');
iframe.style.display = 'none';
document.body.appendChild(iframe);
Expand Down