Attachment shortcuts support on native devices #18407

azimgd · 2023-05-04T14:20:50Z

Details

Fixed Issues

$ #18268
PROPOSAL: #18268

Tests

Verify that no errors appear in the JS console

Connect hardware keyboard
Open any chat and press "+" icon in composer, select "Add Attachment"
Arrow up / Arrow down should scroll through the list
Open a chat with multiple attachments and click on any recent one
Arrow left / Arrow Right should scroll through attachments

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

scroll.mov

Mobile Web - Chrome

Screen.Recording.2023-05-05.at.20.52.53.mov

Mobile Web - Safari

scroll2.mov

Desktop

desktop.mov

iOS

![Uploading Screen Shot 2023-05-05 at 21.17.15.png…]()

Android

IMG_3149.MOV

MelvinBot · 2023-05-04T14:20:57Z

@luacmartins @rushatgabhane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-05-05T06:03:56Z

@azimgd let me know when this is ready for review, thanks!

azimgd · 2023-05-05T14:57:18Z

@rushatgabhane the code is ready to be reviewed. I will complete the checklist and add screenshots shortly.

azimgd · 2023-05-05T16:24:40Z

@rushatgabhane ready.

rushatgabhane

@azimgd code looks good to me! and tests well on android

left a small change request to use functional component.

rushatgabhane · 2023-05-08T08:07:13Z

src/components/AttachmentCarousel/CarouselActions/index.native.js

+    onCycleThroughAttachments: PropTypes.func.isRequired,
+};
+
+class Carousel extends React.Component {


non blocking: @azimgd could we please write this as a functional component? Because we're migrating everything to it anyway

rushatgabhane · 2023-05-08T08:12:32Z

src/components/AttachmentCarousel/index.js

@@ -219,7 +219,7 @@ class AttachmentCarousel extends React.Component {
        const nextIndex = this.state.page - deltaSlide;
        const nextItem = this.state.attachments[nextIndex];

-        if (!nextItem) {
+        if (!nextItem || !this.scrollRef.current) {


could you please help me understand why we made this change?

I assume that was some sort of a race condition happening on Android where scrollRef was undefined upon scroll.

rushatgabhane · 2023-05-09T07:20:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-24.at.01.15.54.mov

Mobile Web - Chrome

Screen.Recording.2023-05-24.at.04.07.43.mov

Mobile Web - Safari

Screen.Recording.2023-05-24.at.04.04.49.mov

Desktop

Screen.Recording.2023-05-24.at.03.57.58.mov

iOS

Screen.Recording.2023-05-24.at.03.55.29.mov

Android

WhatsApp.Video.2023-05-23.at.23.57.27.mp4

rushatgabhane · 2023-05-09T22:10:36Z

@azimgd we need to fix the conflicts caused by prettier merged to main

https://expensify.slack.com/archives/C01GTK53T8Q/p1683669159014609

luacmartins · 2023-05-15T14:32:01Z

@azimgd conflicts

azimgd · 2023-05-16T18:08:22Z

updated.

rushatgabhane · 2023-05-16T18:17:20Z

@azimgd could you please run prettier and push the diff to make the checks happy ✅

luacmartins

Looking good. We just need to address @rushatgabhane's comment.

azimgd · 2023-05-23T16:14:15Z

Hey @rushatgabhane would you mind taking a look one more time please. @luacmartins I haven't implemented functional component initially as the CarouselActions/index.js was implemented as a class component, so I followed the same pattern when created a new file.

rushatgabhane · 2023-05-23T17:51:05Z

@azimgd okayy, thank you for converting it!

We have a lint error, can you please fix that and then we're good to go!
(Tests well)

azimgd · 2023-05-23T17:55:59Z

@rushatgabhane are we good to add // eslint-disable-next-line react-hooks/exhaustive-deps as these effects don't have a "changing" dependencies?

rushatgabhane · 2023-05-23T18:05:20Z

sure, sounds good!

rushatgabhane

@luacmartins LGTM! 🚀

luacmartins

LGTM

OSBotify · 2023-05-23T23:01:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-25T00:34:27Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-25T01:07:58Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-05-25T01:29:55Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-26T07:07:07Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.18-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add KeyboardShortcut support for AttachmentPicker

5fc80ac

azimgd requested a review from a team as a code owner May 4, 2023 14:20

melvin-bot bot requested review from luacmartins and rushatgabhane and removed request for a team May 4, 2023 14:20

azimgd added 2 commits May 5, 2023 14:09

Scrollable attachments implementation

9ff7139

Merge branch 'Expensify:main' into attachment-modal-shortcut

ce843ef

rushatgabhane suggested changes May 8, 2023

View reviewed changes

rushatgabhane reviewed May 8, 2023

View reviewed changes

merge commit

2e2b6d2

prettier diff

65bdce4

twisterdotcom mentioned this pull request May 16, 2023

[HOLD for payment 2023-06-02] [$1000] Attachment modal shortcut bugs on native #18268

Closed

luacmartins previously approved these changes May 19, 2023

View reviewed changes

refactor to functional component

d1cdb04

azimgd dismissed luacmartins’s stale review via d1cdb04 May 23, 2023 16:12

fix eslint warning

755b89f

rushatgabhane approved these changes May 23, 2023

View reviewed changes

luacmartins approved these changes May 23, 2023

View reviewed changes

luacmartins merged commit e1daecc into Expensify:main May 23, 2023

OSBotify mentioned this pull request May 25, 2023

Deploy Checklist: New Expensify 2023-05-25 #19565

Closed

53 tasks

This was referenced May 29, 2023

[HOLD][$250] Migrate index.js to function component #16111

Closed

[HOLD][$250] Migrate index.native.js to function component #16112

Closed

situchan mentioned this pull request Jun 5, 2023

[HOLD for payment 2023-06-21] [$1000] Web - Attachment - The attachments carousel repeats the same image if press the Next key after clicking on any attachment #19484

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attachment shortcuts support on native devices #18407

Attachment shortcuts support on native devices #18407

azimgd commented May 4, 2023 •

edited

Loading

MelvinBot commented May 4, 2023

rushatgabhane commented May 5, 2023

azimgd commented May 5, 2023

azimgd commented May 5, 2023

rushatgabhane left a comment •

edited

Loading

rushatgabhane May 8, 2023 •

edited

Loading

rushatgabhane May 8, 2023

azimgd May 16, 2023

rushatgabhane commented May 9, 2023 •

edited

Loading

rushatgabhane commented May 9, 2023 •

edited

Loading

luacmartins commented May 15, 2023

azimgd commented May 16, 2023

rushatgabhane commented May 16, 2023 •

edited

Loading

luacmartins left a comment

azimgd commented May 23, 2023

rushatgabhane commented May 23, 2023 •

edited

Loading

azimgd commented May 23, 2023

rushatgabhane commented May 23, 2023

rushatgabhane left a comment

luacmartins left a comment

OSBotify commented May 23, 2023

OSBotify commented May 25, 2023

OSBotify commented May 25, 2023

OSBotify commented May 25, 2023

OSBotify commented May 26, 2023

Attachment shortcuts support on native devices #18407

Attachment shortcuts support on native devices #18407

Conversation

azimgd commented May 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented May 4, 2023

rushatgabhane commented May 5, 2023

azimgd commented May 5, 2023

azimgd commented May 5, 2023

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

rushatgabhane May 8, 2023 • edited Loading

Choose a reason for hiding this comment

rushatgabhane May 8, 2023

Choose a reason for hiding this comment

azimgd May 16, 2023

Choose a reason for hiding this comment

rushatgabhane commented May 9, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane commented May 9, 2023 • edited Loading

luacmartins commented May 15, 2023

azimgd commented May 16, 2023

rushatgabhane commented May 16, 2023 • edited Loading

luacmartins left a comment

Choose a reason for hiding this comment

azimgd commented May 23, 2023

rushatgabhane commented May 23, 2023 • edited Loading

azimgd commented May 23, 2023

rushatgabhane commented May 23, 2023

rushatgabhane left a comment

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

OSBotify commented May 23, 2023

OSBotify commented May 25, 2023

OSBotify commented May 25, 2023

OSBotify commented May 25, 2023

OSBotify commented May 26, 2023

azimgd commented May 4, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane May 8, 2023 •

edited

Loading

rushatgabhane commented May 9, 2023 •

edited

Loading

rushatgabhane commented May 9, 2023 •

edited

Loading

rushatgabhane commented May 16, 2023 •

edited

Loading

rushatgabhane commented May 23, 2023 •

edited

Loading