-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix automatic authentication with magic link on mobile native #17141
Conversation
|
@jasperhuangg @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@mollfpr Removing you since this is a quick deploy blocker fix that adds something removed by mistake. |
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroidScreen_Recording_20230407-123951_New.Expensify.mp4 |
…ile-native Fix automatic authentication with magic link on mobile native (cherry picked from commit 58b2bbb)
…-17141 🍒 Cherry pick PR #17141 to staging 🍒
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 1.2.96-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.96-4 🚀
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀
|
cc @NikkiWines @johnmlee101
Details
This is a fix for the mobile native Apps only. The thing is that iOS deep linking is broken atm and this can be tested on Android native only.
Fixed Issues
$ #17091
Tests
npm run android
commandadb shell am start -a android.intent.action.VIEW -d "new-expensify://v/702/000000"
replace 702 with the properaccountID
from the previous stepOffline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
N/AMobile Web - Chrome
N/AMobile Web - Safari
N/ADesktop
N/AiOS
N/AAndroid
Screen.Recording.2023-04-07.at.21.57.02.mov