Convert some capital letters to lowercase and capitalize months and days in Spanish(Final) #16627

ayazhussain79 · 2023-03-28T16:40:18Z

Details

We want to convert some capital characters to lowercase and capitalization for months and days in Spanish.

Fixed Issues

$ #16403
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Go to settings > Preferences
Click on language and change it to spanish
Go back > Go to Profile > personal details > Date of birth
Verify that it says "Fecha de nacimiento" in the header text
Open the date picker
Verify the first letter in month name is in uppercase
Verify that the days letters are also in uppercase
Go back > Go to Home address
Verify that field name "Código postal"
Go back to Profile > Upload photo
Select a image and click ok
Verify that it says "Editar foto" in the header text
Go back > Go to Workspace
Select a workspace
Go to Connect bank account
Verify that it says "Un momento" on the loading screen header
Go back to settings > Preferences
Click on language and change it to english
Go back > Go to Workspace
Select a workspace
Go to Connect bank account
Verify that it says "One moment" on the loading screen header

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

2023-03-25-05-02-23_IjBKQjEb.mp4

Mobile Web - Chrome

Screen.Recording.2023-03-27.at.10.49.36.PM.mov

Mobile Web - Safari

Desktop

Screen.Recording.2023-03-27.at.10.40.34.PM.mov

iOS

Screen.Recording.2023-03-27.at.10.46.35.PM.mov

Android

Screen.Recording.2023-03-27.at.11.02.56.PM.mov

MelvinBot · 2023-03-28T16:40:25Z

@luacmartins @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ayazhussain79 · 2023-03-28T16:40:37Z

@Julesssss @thesahindia @aldo-expensify new PR is ready for review with signed commit

aldo-expensify · 2023-03-28T17:18:04Z

src/components/CalendarPicker/index.js

@@ -18,8 +18,8 @@ class CalendarPicker extends React.PureComponent {
    constructor(props) {
        super(props);

-        this.monthNames = moment.localeData(props.preferredLocale).months();
-        this.daysOfWeek = moment.localeData(props.preferredLocale).weekdays();
+        this.monthNames = _.map(moment.localeData(props.preferredLocale).months(), month => month.replace(/^\w/, c => c.toUpperCase()));


NAB: Just wondering why we didn't do something simpler like:

Suggested change

this.monthNames = _.map(moment.localeData(props.preferredLocale).months(), month => month.replace(/^\w/, c => c.toUpperCase()));

this.monthNames = _.map(moment.localeData(props.preferredLocale).months(), month => month.toUpperCase());

@aldo-expensify The first line of code converts the month names to title case (where the first letter of each word is capitalized), while the second line of code converts the month names to all uppercase. We just need to convert first letter of the month to uppercase

I see, thanks for explaining!

I was also confused by this. Could you please add a small comment explaining this for people in the future? Thanks

Does this mean that we want sentence case for these? If so, I believe that we can use Str.recapitalize for that.

@ayazhussain79, can you make this change?

@thesahindia ok I'm going to change it

you can check new change

Julesssss

Left a small comment, but thanks for getting the commits signed!

luacmartins · 2023-03-29T12:04:41Z

src/components/CalendarPicker/index.js

@@ -18,8 +18,8 @@ class CalendarPicker extends React.PureComponent {
    constructor(props) {
        super(props);

-        this.monthNames = moment.localeData(props.preferredLocale).months();
-        this.daysOfWeek = moment.localeData(props.preferredLocale).weekdays();
+        this.monthNames = _.map(moment.localeData(props.preferredLocale).months(), month => month.replace(/^\w/, c => c.toUpperCase()));


Does this mean that we want sentence case for these? If so, I believe that we can use Str.recapitalize for that.

src/components/CalendarPicker/index.js

ayazhussain79 · 2023-03-29T14:38:38Z

@thesahindia you can check the new changes

aldo-expensify · 2023-03-29T14:46:24Z

src/components/CalendarPicker/index.js

@@ -18,8 +19,8 @@ class CalendarPicker extends React.PureComponent {
    constructor(props) {
        super(props);

-        this.monthNames = moment.localeData(props.preferredLocale).months();
-        this.daysOfWeek = moment.localeData(props.preferredLocale).weekdays();
+        this.monthNames = _.map(moment.localeData(props.preferredLocale).months(), month => Str.recapitalize(month));


Suggested change

this.monthNames = _.map(moment.localeData(props.preferredLocale).months(), month => Str.recapitalize(month));

this.monthNames = _.map(moment.localeData(props.preferredLocale).months(), Str.recapitalize);

NAB

@aldo-expensify changed that line as suggested you can check it

thesahindia · 2023-03-29T21:06:00Z

@ayazhussain79, the fixed issues section should look like this -

Fixed Issues

$ #16403
PROPOSAL: #16403 (comment)

And you will need to update the steps. You can check other PRs to understand how we write the steps.

Include the specific steps you followed to navigate to the page, rather than simply stating the name of the page.
Be more specific about what needs to verified.

Here's how I would write the test steps for the first two cases. You can follow the same for other cases.

Go to settings > Preferences
Click on language and change it to spanish
Go back > Go to Profile > personal details > Date of birth
Verify that it says "Fecha de nacimiento" in the header text
Open the date picker
Verify the first letter in month name is in uppercase
Verify that the days letters are also in uppercase

Lastly I would not suggest using commit message like "This commit will do xyz". For example in your first commit, instead of writing "This commit will capitalize month and day names" you could just write "capitalize month and day names".

ayazhussain79 · 2023-03-29T21:56:46Z

@thesahindia updated fixed issues section you can check it and next time I will correct all my mistakes, Thank you

thesahindia · 2023-03-30T07:11:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

thesahindia

All yours @luacmartins

thesahindia · 2023-03-30T07:15:23Z

have uploaded other platform videos/SS except Mobile Web - Safari

@ayazhussain79, what issue are you facing when using the app on iOS Safari??

luacmartins

LGTM!

luacmartins · 2023-03-30T09:42:01Z

@Julesssss @aldo-expensify all yours

Julesssss

Thanks all 👍

OSBotify · 2023-03-30T09:56:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-31T12:05:32Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.2.93-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

OSBotify · 2023-04-03T18:40:17Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.93-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ayazhussain79 added 2 commits March 28, 2023 21:10

This commit will capitalize month and day names

7af5150

This commit will used lowercase/upper case on some words

6cb015d

ayazhussain79 requested a review from a team as a code owner March 28, 2023 16:40

melvin-bot bot requested review from luacmartins and thesahindia and removed request for a team March 28, 2023 16:40

ayazhussain79 mentioned this pull request Mar 28, 2023

Previous PR #16593

Closed

54 tasks

aldo-expensify reviewed Mar 28, 2023

View reviewed changes

Julesssss self-requested a review March 28, 2023 23:15

Julesssss reviewed Mar 28, 2023

View reviewed changes

luacmartins reviewed Mar 29, 2023

View reviewed changes

This commit will capitalize first letter using Str recapitalize

b1517da

aldo-expensify reviewed Mar 29, 2023

View reviewed changes

This commit will capitalized first letter as suggested

c2318f9

thesahindia approved these changes Mar 30, 2023

View reviewed changes

luacmartins approved these changes Mar 30, 2023

View reviewed changes

Julesssss reviewed Mar 30, 2023

View reviewed changes

Julesssss approved these changes Mar 30, 2023

View reviewed changes

Julesssss merged commit 4d04aa1 into Expensify:main Mar 30, 2023

OSBotify mentioned this pull request Mar 31, 2023

Deploy Checklist: New Expensify 2023-03-31 #16787

Closed

20 tasks

MelvinBot mentioned this pull request Apr 3, 2023

[HOLD for payment 2023-04-10] [$1000] The new date of birth field header has the capital ‘N’ in the third word unlike other areas of the application where every letter are small in Spanish #16403

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert some capital letters to lowercase and capitalize months and days in Spanish(Final) #16627

Convert some capital letters to lowercase and capitalize months and days in Spanish(Final) #16627

ayazhussain79 commented Mar 28, 2023 •

edited

Loading

MelvinBot commented Mar 28, 2023

ayazhussain79 commented Mar 28, 2023

aldo-expensify Mar 28, 2023

ayazhussain79 Mar 28, 2023

aldo-expensify Mar 28, 2023

ayazhussain79 Mar 28, 2023

Julesssss Mar 28, 2023

luacmartins Mar 29, 2023

thesahindia Mar 29, 2023

ayazhussain79 Mar 29, 2023

ayazhussain79 Mar 29, 2023

Julesssss left a comment

luacmartins Mar 29, 2023

ayazhussain79 commented Mar 29, 2023

aldo-expensify Mar 29, 2023

ayazhussain79 Mar 29, 2023

thesahindia commented Mar 29, 2023

ayazhussain79 commented Mar 29, 2023

thesahindia commented Mar 30, 2023

thesahindia left a comment

thesahindia commented Mar 30, 2023

luacmartins left a comment

luacmartins commented Mar 30, 2023

Julesssss left a comment

OSBotify commented Mar 30, 2023

OSBotify commented Mar 31, 2023

OSBotify commented Apr 3, 2023

	this.monthNames = _.map(moment.localeData(props.preferredLocale).months(), month => month.replace(/^\w/, c => c.toUpperCase()));
	this.monthNames = _.map(moment.localeData(props.preferredLocale).months(), month => month.toUpperCase());

Convert some capital letters to lowercase and capitalize months and days in Spanish(Final) #16627

Convert some capital letters to lowercase and capitalize months and days in Spanish(Final) #16627

Conversation

ayazhussain79 commented Mar 28, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 28, 2023

ayazhussain79 commented Mar 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Julesssss left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ayazhussain79 commented Mar 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thesahindia commented Mar 29, 2023

Fixed Issues

ayazhussain79 commented Mar 29, 2023

thesahindia commented Mar 30, 2023

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

thesahindia commented Mar 30, 2023

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Mar 30, 2023

Julesssss left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 30, 2023

OSBotify commented Mar 31, 2023

OSBotify commented Apr 3, 2023

ayazhussain79 commented Mar 28, 2023 •

edited

Loading