-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Message actions popover not showing after open app download links page and go back #14431
Conversation
79d5521
to
9c616ee
Compare
@luacmartins @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well. All yours @eVoloshchak!
@@ -239,8 +235,8 @@ class PopoverReportActionContextMenu extends React.Component { | |||
selection={this.state.selection} | |||
reportID={this.state.reportID} | |||
reportAction={this.state.reportAction} | |||
isArchivedRoom={this.props.isArchivedRoom} | |||
isChronosReport={this.props.isChronosReport} | |||
isArchivedRoom={this.state.isArchivedRoom} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we're using this.state.isArchivedRoom in measureContent
, but this.props.isArchivedRoom in render
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eVoloshchak thanks for the catch! it should use this.state.isArchivedRoom
and this.state.isChronosReport
in both places. PR updated.
Other than that the code looks good, so I'm going to start testing and going through the checklist |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-01-23.at.13.17.06.movMobile Web - ChromeScreen_Recording_20230123-133325_Chrome.mp4Mobile Web - SafariScreen.Recording.2023-01-23.at.13.24.41.movDesktopScreen.Recording.2023-01-23.at.13.18.42.moviOSScreen.Recording.2023-01-23.at.13.23.49.movAndroidScreen.Recording.2023-01-23.at.13.41.37.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested, looks good and works well
cc: @luacmartins
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.2.58-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.2.58-4 🚀
|
Details
Escalate
PopoverReportActionContextMenu
to [Expensify.js (https://github.com/Expensify/App/blob/main/src/Expensify.js) to become an app-wide component, thus avoiding race conditions when using the app-wideReportActionContextMenu.showContextMenu
methodFixed Issues
$ #14131
#14131 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.Screenshots/Videos
Web
Screen.Recording.2023-01-20.at.17.02.52.mov
Mobile Web - Chrome
Screen.Recording.2023-01-20.at.17.04.39.mov
Mobile Web - Safari
Screen.Recording.2023-01-20.at.17.10.17.mov
Desktop
Screen.Recording.2023-01-20.at.17.26.06.mov
iOS
Screen.Recording.2023-01-20.at.17.23.46.mov
Android
Screenrecorder-2023-01-20-20-08-34-35.mp4