Navigate to workspace settings after workspace deletion #12971

jasperhuangg · 2022-11-23T20:36:30Z

Details

Navigate to the WorkspacesListPage after we delete a workspace.
Updates the WorkspacesListPage to not list workspaces that are pending deletion. This makes it so that when we delete a workspace offline, it won't show up there afterwards.
Updates the copy for Delete Workspace to Delete workspace to match the capitalization of all of our other copies.

$ #12962
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Tap on your avatar > Workspaces > Select a workspace or click New workspace.
Click the vertical ellipses menu > Delete workspace
Verify you are taken back to your list of workspaces (the page with the New workspace button), and that the workspace you deleted isn't visible.

Verify that no errors appear in the JS console

Offline tests

Tap on your avatar > Workspaces > Select a workspace or click New workspace.
Go offline
Click the vertical ellipses menu > Delete workspace
Verify you are taken back to your list of workspaces (the page with the New workspace button), and that the workspace you deleted isn't visible.

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-chrome.mov

Mobile Web - Safari

ios-safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

… a workspace

…SettingsAfterDelete

melvin-bot · 2022-11-23T21:02:36Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

srikarparsi · 2022-11-25T06:23:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

srikarparsi · 2022-11-25T06:31:31Z

hey @jasperhuangg I can't get my iphone or android emulators working but I'll try to debug that tomorrow and hopefully merge it by the end of the day

melvin-bot · 2022-11-29T17:47:11Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jasperhuangg · 2022-11-29T17:48:23Z

@cristipaval PB'd you on this one so we can get the ball rolling a bit while @srikarparsi fixes his emulators

jasperhuangg · 2022-11-29T17:52:00Z

@cristipaval most of the reviewer checklist is done–we just need a reviewer to confirm it works on iOS, Android, Mobile Safari, and Mobile Chrome and it should be good to merge afterwards.

Thanks in advance!

srikarparsi · 2022-11-29T18:26:39Z

thanks @jasperhuangg, I had two customer issues to work on and wanted to prioritize them since the customers seemed a little angry. I then had a problem with rebasing this branch since commits weren't signing so I'm working on fixing that and will try to do the screenshots next but @cristipaval, if you're able to do the screenshots today for the mobile devices that would be really great :)

jasperhuangg · 2022-11-29T18:28:21Z

@srikarparsi all good no problem at all! totally feel you with those customers issues they can definitely stress me out sometimes.

branch since commits weren't signing so I'm working on fixing that and will try to do the screenshots next

let me know if you need help with this–you need to run some git config command IIRC. This happened to me one time I installed some Git desktop client and I accidentally signed in using my non-Expensify email address. Any subsequent commits to Expensify repos wouldn't sign.

cristipaval · 2022-11-29T18:51:43Z

I'm on it

srikarparsi · 2022-11-29T19:54:13Z

thanks @cristipaval!! yeah thanks @jasperhuangg I ended up deleting my local copy of the App repo and re-cloning it using https but it's been running for the last 45 minutes. It's been moving slowly so I'm letting it run but hopefully that fixes it since signing commits is working fine in the other repos.

OSBotify · 2022-11-29T20:00:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-11-30T04:10:16Z

🚀 Deployed to staging by @srikarparsi in version: 1.2.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aldo-expensify · 2022-11-30T18:09:53Z

This PR shouldn't have done this part:

Updates the WorkspacesListPage to not list workspaces that are pending deletion. This makes it so that when we delete a workspace offline, it won't show up there afterwards.

This was expected behaviour, it was not part of the issue being solved, and caused this regression: #13192

aldo-expensify · 2022-11-30T18:12:32Z

PR up to revert ^

mvtglobally · 2022-11-30T19:11:04Z

Team was still getting the following issue with this PR #13154. Will it be resolved with revert?

luacmartins · 2022-11-30T19:37:57Z

@mvtglobally I'm unable to reproduce #13154 on staging or locally.

OSBotify · 2022-12-01T16:13:42Z

🚀 Deployed to production by @luacmartins in version: 1.2.34-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

youssef-lr and others added 4 commits November 23, 2022 17:18

Do not make changes to IOU locally if currencies differ

6986408

Fix linting

96ed054

navigate to workspace settings instead of main settings upon deleting…

59d1aac

… a workspace

update inconsistent copy

82e7f25

jasperhuangg self-assigned this Nov 23, 2022

jasperhuangg added 3 commits November 23, 2022 12:37

revert unrelated changes

12c328a

filter out policies that are pending deletion

4618e73

Merge branch 'main' of github.com:Expensify/App into jasper-workspace…

44168d0

…SettingsAfterDelete

jasperhuangg marked this pull request as ready for review November 23, 2022 21:02

jasperhuangg requested a review from a team as a code owner November 23, 2022 21:02

melvin-bot bot requested review from srikarparsi and removed request for a team November 23, 2022 21:02

jasperhuangg requested a review from a team November 29, 2022 17:46

melvin-bot bot requested review from cristipaval and removed request for a team November 29, 2022 17:47

cristipaval approved these changes Nov 29, 2022

View reviewed changes

srikarparsi approved these changes Nov 29, 2022

View reviewed changes

srikarparsi merged commit a1da135 into main Nov 29, 2022

srikarparsi deleted the jasper-workspaceSettingsAfterDelete branch November 29, 2022 19:54

OSBotify mentioned this pull request Nov 30, 2022

Deploy Checklist: New Expensify 2022-11-30 #13180

Closed

32 tasks

aldo-expensify mentioned this pull request Nov 30, 2022

[HOLD for payment 2022-12-08] Workspace - Delete workspace error icon & message do not appear for failed scenario #13192

Closed

aldo-expensify mentioned this pull request Nov 30, 2022

Revert filtering out workspaces with pending delete action #13201

Merged

49 tasks

jasperhuangg mentioned this pull request Dec 2, 2022

After Deleting a workspace it directly navigates to main setting page instead of workspace list page #12962

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Navigate to workspace settings after workspace deletion #12971

Navigate to workspace settings after workspace deletion #12971

jasperhuangg commented Nov 23, 2022 •

edited

Loading

melvin-bot bot commented Nov 23, 2022

srikarparsi commented Nov 25, 2022 •

edited by cristipaval

Loading

srikarparsi commented Nov 25, 2022

melvin-bot bot commented Nov 29, 2022

jasperhuangg commented Nov 29, 2022

jasperhuangg commented Nov 29, 2022 •

edited

Loading

srikarparsi commented Nov 29, 2022

jasperhuangg commented Nov 29, 2022 •

edited

Loading

cristipaval commented Nov 29, 2022

srikarparsi commented Nov 29, 2022

OSBotify commented Nov 29, 2022

OSBotify commented Nov 30, 2022

aldo-expensify commented Nov 30, 2022 •

edited

Loading

aldo-expensify commented Nov 30, 2022

mvtglobally commented Nov 30, 2022

luacmartins commented Nov 30, 2022

OSBotify commented Dec 1, 2022

Navigate to workspace settings after workspace deletion #12971

Navigate to workspace settings after workspace deletion #12971

Conversation

jasperhuangg commented Nov 23, 2022 • edited Loading

Details

Tests

Offline tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Nov 23, 2022

srikarparsi commented Nov 25, 2022 • edited by cristipaval Loading

Reviewer Checklist

Screenshots/Videos

srikarparsi commented Nov 25, 2022

melvin-bot bot commented Nov 29, 2022

jasperhuangg commented Nov 29, 2022

jasperhuangg commented Nov 29, 2022 • edited Loading

srikarparsi commented Nov 29, 2022

jasperhuangg commented Nov 29, 2022 • edited Loading

cristipaval commented Nov 29, 2022

srikarparsi commented Nov 29, 2022

OSBotify commented Nov 29, 2022

OSBotify commented Nov 30, 2022

aldo-expensify commented Nov 30, 2022 • edited Loading

aldo-expensify commented Nov 30, 2022

mvtglobally commented Nov 30, 2022

luacmartins commented Nov 30, 2022

OSBotify commented Dec 1, 2022

jasperhuangg commented Nov 23, 2022 •

edited

Loading

srikarparsi commented Nov 25, 2022 •

edited by cristipaval

Loading

jasperhuangg commented Nov 29, 2022 •

edited

Loading

jasperhuangg commented Nov 29, 2022 •

edited

Loading

aldo-expensify commented Nov 30, 2022 •

edited

Loading