Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal QA] Fix the way the reviewer checklist is found #12936

Merged
merged 23 commits into from
Nov 23, 2022
Merged

[Internal QA] Fix the way the reviewer checklist is found #12936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7a3df02
Improve layout by switching it to flex
tgolen Nov 17, 2022
b0cddae
A few tweaks to the layout for different screen widths
tgolen Nov 17, 2022
7d76729
Remove some of the old code
tgolen Nov 17, 2022
a8e082a
Remove unused code
tgolen Nov 17, 2022
f956443
Remove unused code and styles
tgolen Nov 17, 2022
b090f0c
Allow styles to be spread
tgolen Nov 17, 2022
999ba0c
Leave a WIP marker
tgolen Nov 17, 2022
6dce24d
Move styles to the style files
tgolen Nov 18, 2022
dac354b
Remove flex style from form button because it makes the height of the…
tgolen Nov 18, 2022
7fe35bd
Allow keyboard to be dismissed
tgolen Nov 18, 2022
7022f1a
Remove unused import
tgolen Nov 18, 2022
cd5e0fe
Merge branch 'main' into tgolen-fix-signin-keyboard-avoiding
tgolen Nov 21, 2022
012b561
Fix typo in the prop name
tgolen Nov 21, 2022
8e5f142
Remove scrollview
tgolen Nov 22, 2022
eb3833f
Fix a wonky flex layout which makes the success message take up the e…
tgolen Nov 22, 2022
8ddf21e
Dismiss keyboard when tapping outside of the inputs
tgolen Nov 22, 2022
611bee8
Improve the padding around the input form
tgolen Nov 22, 2022
11b76f0
Merge branch 'main' into tgolen-fix-signin-keyboard-avoiding
tgolen Nov 22, 2022
8cd5c1c
Fix how the reviewer checklist is found in GH action
tgolen Nov 22, 2022
daa51ec
Remove line break that causes bad formatting of checklist
tgolen Nov 22, 2022
5fdd0b6
Update PR template to have collapsable sections for screenshots by de…
tgolen Nov 22, 2022
70d39cd
Revert changes from bad branch
tgolen Nov 22, 2022
0093d7d
Revert changes from bad branch
tgolen Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 36 additions & 15 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ This is a checklist for PR authors. Please make sure to complete all tasks and c
- [ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- [ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- [ ] I tested this PR with a [High Traffic account](https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#high-traffic-accounts) against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

- [ ] I included screenshots or videos for tests on [all platforms](https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms)
- [ ] I ran the tests on **all platforms** & verified they passed on:
- [ ] iOS / native
Expand Down Expand Up @@ -167,23 +166,45 @@ The reviewer will copy/paste it into a new comment and complete it after the aut

</details>

### Screenshots
<!-- Add screenshots for all platforms tested. Pull requests won't be merged unless the screenshots show the app was tested on all platforms.-->
### Screenshots/Videos
<details>
<summary>Web</summary>

<!-- add screenshots or videos here -->

</details>

<details>
<summary>Mobile Web - Chrome</summary>

<!-- add screenshots or videos here -->

</details>

<details>
<summary>Mobile Web - Safari</summary>

<!-- add screenshots or videos here -->

</details>

<details>
<summary>Desktop</summary>

<!-- add screenshots or videos here -->

#### Web
<!-- Insert screenshots of your changes on the web platform-->
</details>

<details>
<summary>iOS</summary>

#### Mobile Web - Chrome
<!-- Insert screenshots of your changes on the web platform (from chrome mobile browser)-->
<!-- add screenshots or videos here -->

#### Mobile Web - Safari
<!-- Insert screenshots of your changes on the web platform (from safari mobile browser)-->
</details>

#### Desktop
<!-- Insert screenshots of your changes on the desktop platform-->
<details>
<summary>Android</summary>

#### iOS
<!-- Insert screenshots of your changes on the iOS platform-->
<!-- add screenshots or videos here -->

#### Android
<!-- Insert screenshots of your changes on the Android platform-->
</details>
2 changes: 1 addition & 1 deletion .github/actions/javascript/reviewerChecklist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function checkIssueForCompletedChecklist(numberOfChecklistItems) {
for (let i = 0; i < combinedComments.length; i++) {
// Skip all other comments if we already found the reviewer checklist
if (foundReviewerChecklist) {
return;
break;
}

const whitespace = /([\n\r])/gm;
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/javascript/reviewerChecklist/reviewerChecklist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function checkIssueForCompletedChecklist(numberOfChecklistItems) {
for (let i = 0; i < combinedComments.length; i++) {
// Skip all other comments if we already found the reviewer checklist
if (foundReviewerChecklist) {
return;
break;
}

const whitespace = /([\n\r])/gm;
Expand Down