Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont display tooltips on platforms that dont support hover #12168

Merged
merged 52 commits into from
Jan 7, 2023
Merged

Dont display tooltips on platforms that dont support hover #12168

merged 52 commits into from
Jan 7, 2023

Commits on Oct 26, 2022

  1. Create function to detect internet explorer

    @roryabraham
    roryabraham committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    d78b0d0 View commit details
    Browse the repository at this point in the history

  2. Create more accurate implementation of hasHoverSupport

    @roryabraham
    roryabraham committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    2f372e2 View commit details
    Browse the repository at this point in the history

  3. Handle edge case for ancient IE mobile

    @roryabraham
    roryabraham committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    1faba5d View commit details
    Browse the repository at this point in the history

  4. Add documentation for IE edge case

    @roryabraham
    roryabraham committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    346e074 View commit details
    Browse the repository at this point in the history

  5. Combine canUseTouchscreen and hasHoverSupport into DeviceCapabilities… 

    … library
    @roryabraham
    roryabraham committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    852c0c3 View commit details
    Browse the repository at this point in the history

  6. Dont render tooltips if the device does not support hover

    @roryabraham
    roryabraham committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    5e8f723 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Upgrade testing-library/react-native and transitive peer dependencies

    @roryabraham
    roryabraham committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    a8360e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Merge branch 'main' into Rory-NoTooltipWithoutMouse 

    # Conflicts:
#	package-lock.json
#	package.json
#	src/components/DatePicker/index.js
    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    18ff316 View commit details
    Browse the repository at this point in the history

  2. Reinstall packages after merge

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    d17c423 View commit details
    Browse the repository at this point in the history

  3. Reapply changes from 12078

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    9091ee5 View commit details
    Browse the repository at this point in the history

  4. Add eslint-plugin-lwc transitive dependency

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    932d999 View commit details
    Browse the repository at this point in the history

  5. Nix deprecated babel-eslint and replace with @babel/eslint-parser

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    f8938cf View commit details
    Browse the repository at this point in the history

  6. Separately install jest-environment-jsdom

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    22da5de View commit details
    Browse the repository at this point in the history

  7. Migrate to DeviceCapabilities lib in OptionsList/index.js

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    f583bdf View commit details
    Browse the repository at this point in the history

  8. Fix JS style

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    e7f26c3 View commit details
    Browse the repository at this point in the history

  9. Upgrade jest to match jest-environment-eslint

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    6b473ed View commit details
    Browse the repository at this point in the history

  10. Upgrade babel/preset-env

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    3b0e1b2 View commit details
    Browse the repository at this point in the history

  11. Fix babel config

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    e9097a7 View commit details
    Browse the repository at this point in the history

  12. Upgrade reanimated to fix jest 28 bug

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    5652989 View commit details
    Browse the repository at this point in the history

  13. Fix noisy loose tests

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    f720dac View commit details
    Browse the repository at this point in the history

  14. Fix fake timers

    @roryabraham
    roryabraham committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    0b3123e View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Create draft of TooltipTest

    @roryabraham
    roryabraham committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    515a3c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Merge branch 'main' into Rory-NoTooltipWithoutMouse 

    # Conflicts:
#	ios/Podfile.lock
#	package-lock.json
#	src/libs/Browser/index.js
#	src/libs/Browser/index.web.js
#	src/pages/iou/steps/IOUAmountPage.js
    @roryabraham
    roryabraham committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    9dfe38e View commit details
    Browse the repository at this point in the history

  2. Remove IE considerations

    @roryabraham
    roryabraham committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    28b2462 View commit details
    Browse the repository at this point in the history

  3. Finish removing IE support

    @roryabraham
    roryabraham committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    05e466d View commit details
    Browse the repository at this point in the history

  4. Swap out ReactDom.createPortal for @gorhom/portal

    @roryabraham
    roryabraham committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    73f0bdf View commit details
    Browse the repository at this point in the history

  5. Fix typo in touchscreen

    @roryabraham
    roryabraham committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    aece03e View commit details
    Browse the repository at this point in the history

  6. Finish automated tests

    @roryabraham
    roryabraham committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    46b2140 View commit details
    Browse the repository at this point in the history

  7. Remove console log

    @roryabraham
    roryabraham committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    ecb7894 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Merge branch 'main' into Rory-NoTooltipWithoutMouse

    @roryabraham
    roryabraham committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    8e0a11a View commit details
    Browse the repository at this point in the history

  2. Mostly fix UnreadIndicatorsTest

    @roryabraham
    roryabraham committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    f1b5250 View commit details
    Browse the repository at this point in the history

  3. Fully fix UnreadIndicatorsTest

    @roryabraham
    roryabraham committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    518aad2 View commit details
    Browse the repository at this point in the history

  4. Fix sidebar tests

    @roryabraham
    roryabraham committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    6df5f55 View commit details
    Browse the repository at this point in the history

  5. Move setTimeout to file level instead of beforeEach

    @roryabraham
    roryabraham committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    2cf41c1 View commit details
    Browse the repository at this point in the history

  6. Try using built-in jest sharding

    @roryabraham
    roryabraham committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    6bd8c69 View commit details
    Browse the repository at this point in the history

  7. Move fail-fast property to the correct place:

    @roryabraham
    roryabraham committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    afc55b6 View commit details
    Browse the repository at this point in the history

  8. Add setupNode back

    @roryabraham
    roryabraham committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    9394b78 View commit details
    Browse the repository at this point in the history

  9. Add setupNode to shellTests jobs

    @roryabraham
    roryabraham committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    dc7c330 View commit details
    Browse the repository at this point in the history

  10. Remove getPullRequestsMergedBetween from jest job

    @roryabraham
    roryabraham committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    8ac00ea View commit details
    Browse the repository at this point in the history

  11. Use dynamic job total

    @roryabraham
    roryabraham committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    bf7b724 View commit details
    Browse the repository at this point in the history

  12. Try adding max-workers to address handing test

    @roryabraham
    roryabraham committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    3b68d03 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. Button up TooltipTest

    @roryabraham
    roryabraham committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    a22b336 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Add a comment explaining why TooltipTest manually imports Tooltip/ind… 

    …ex.js
    @roryabraham
    roryabraham committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    ec9dce1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Rory-NoTooltipWithoutMouse

    @roryabraham
    roryabraham committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    08bedee View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2023

  1. Merge branch main into Rory-NoTooltipWithoutMouse

    @roryabraham
    roryabraham committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    4236e8f View commit details
    Browse the repository at this point in the history

  2. Revert test-related changes

    @roryabraham
    roryabraham committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    d09744c View commit details
    Browse the repository at this point in the history

  3. Ooops I didn't commit everything :D

    @roryabraham
    roryabraham committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    9361ad7 View commit details
    Browse the repository at this point in the history

  4. Add code comment for ref callback

    @roryabraham
    roryabraham committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    611e0d8 View commit details
    Browse the repository at this point in the history

  5. Remove unrelated lint change

    @roryabraham
    roryabraham committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    92f0efd View commit details
    Browse the repository at this point in the history

  6. Move tooltip down a level in the component tree and fix issues with s… 

    …hiftVertical prop
    @roryabraham
    roryabraham committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    0706760 View commit details
    Browse the repository at this point in the history

  7. Hide tooltip if correct position not yet measured

    @roryabraham
    roryabraham committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    a62d5fd View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Merge branch 'main' into Rory-NoTooltipWithoutMouse 

    # Conflicts:
#	src/components/Tooltip/index.js
    @roryabraham
    roryabraham committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    d3aa664 View commit details
    Browse the repository at this point in the history