Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update handling so that Concierge link redirects to chat" #11909

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

sketchydroide
Copy link
Contributor

Reverts #11527

Internal QA for this did not pass and we though it was better to revert, and then let @thienlnam take a look tomrrow
https://expensify.slack.com/archives/C07J32337/p1666020529387209

@sketchydroide sketchydroide self-assigned this Oct 17, 2022
@sketchydroide sketchydroide requested a review from a team as a code owner October 17, 2022 16:24
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@melvin-bot melvin-bot bot requested review from sobitneupane and srikarparsi and removed request for a team October 17, 2022 16:24
@sketchydroide sketchydroide merged commit 32f94ec into main Oct 17, 2022
@sketchydroide sketchydroide deleted the revert-11527-jack-conciergePath branch October 17, 2022 16:30
@melvin-bot melvin-bot bot added the Emergency label Oct 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2022

@sketchydroide looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@sketchydroide
Copy link
Contributor Author

sketchydroide commented Oct 17, 2022

Not exactly an emergency, but there was some urgency, and the rever should not need to go through the check lists.

OSBotify pushed a commit that referenced this pull request Oct 17, 2022
Revert "Update handling so that Concierge link redirects to chat"

(cherry picked from commit 32f94ec)
OSBotify added a commit that referenced this pull request Oct 17, 2022
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.2.16-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @sketchydroide in version: 1.2.16-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants