Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: memo SidebarLinks #11907

Merged
merged 14 commits into from
Oct 31, 2022
Merged

perf: memo SidebarLinks #11907

merged 14 commits into from
Oct 31, 2022

Commits on Oct 19, 2022

  1. move platform code to specific functions

    @hannojg
    hannojg committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    1d123db View commit details
    Browse the repository at this point in the history

  2. clean code

    @hannojg
    hannojg committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    6816236 View commit details
    Browse the repository at this point in the history

  3. perf: memo SidebarLinks

    @hannojg
    hannojg committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    73f7468 View commit details
    Browse the repository at this point in the history

  4. Revert "perf: memo SidebarLinks" 

    This reverts commit 2d98ce0f6d44cd371f8bacfb49868f9ba5603b61.
    @hannojg
    hannojg committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    424f8e0 View commit details
    Browse the repository at this point in the history

  5. refactor: moved PopoverMenu into its own component … 

    … instead of using memo. From performance perspective that even seems to have slightly improved over the React.memo approach.
    @hannojg
    hannojg committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    bb5e243 View commit details
    Browse the repository at this point in the history

  6. clean: prop types

    @hannojg
    hannojg committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    e6c6941 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Merge branch 'main' of github.com:margelo/expensify-app-fork into per… 

    …f/memoize-sidebar
    @hannojg
    hannojg committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    1ef7b38 View commit details
    Browse the repository at this point in the history

  2. removed onyx subscribe, use shouldComponentUpdate

    @hannojg
    hannojg committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    ba3b9bf View commit details
    Browse the repository at this point in the history

  3. code style

    @hannojg
    hannojg committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    b0c73f1 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @hannojg @mountiny
    hannojg and mountiny authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    83efc2b View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Merge branch 'main' of github.com:margelo/expensify-app-fork into per… 

    …f/memoize-sidebar
    @hannojg
    hannojg committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    e780a7e View commit details
    Browse the repository at this point in the history

  2. fix issue after merge

    @hannojg
    hannojg committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    a759d82 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. revert change

    @hannojg
    hannojg committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    73e1a89 View commit details
    Browse the repository at this point in the history

  2. revert change

    @hannojg
    hannojg committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    74820f9 View commit details
    Browse the repository at this point in the history