Tooltip appears sometimes when go back from chat (mWeb - Safari) - reported by @aneequeahmad

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to chat with someone
2. Go back from chat using back button and open chat again and go back.
3. Repeat this process sometimes and a tool tip will appear when back on chat screen

Expected Result:

No tootip should appear on chats list screen.

Actual Result:

Tooltip appear on chat list screen

Workaround:

unknown

Platform:

Where is this issue occurring?

• Mobile Web (Safari)/ iphone 11 pro

Version Number: 1.1.79-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Image.from.iOS.5.mov

Expensify/Expensify Issue URL:
Issue reported by: @aneequeahmad
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1655759723252049

Job Post: https://www.upwork.com/jobs/~01d41ef083193aa30f

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Christinadobrzyn]

Based on this chat - https://expensify.slack.com/archives/C01GTK53T8Q/p1655759723252049 - looks like this might be a bug.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

Looks like we need consistent reproduction steps on this. This can be external but should be treated as a monthly, at least until there are more consistent steps to reproduce it.

[melvin-bot]

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[roryabraham]

@kevinksullivan as soon as this is exported please make it a monthly

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[melvin-bot]

Current assignee @roryabraham is eligible for the Exported assigner, not assigning anyone new.

[metehanozyurt]

Proposal

Cause

When button press tooltip showed up mWeb.

Solution

We can restrict tooltip views on mobile webs. We need to get help from the canUseTouchscreen function in our library and make the following changes. In this way, we prevent other tooltips from appearing. While doing the tests, I found that other tooltips were also appearing. We do not encounter this problem only with the back button.

App/src/components/Tooltip/index.js

Lines 142 to 148 in a2f8cf9

	render() {
	// Skip the tooltip and return the children, if the text is empty.
	if (_.isEmpty(this.props.text)) {
	return this.props.children;
	}
	let child = (
	<View

Adding this line

        // Skip the tooltip and return the children, if the text is empty.
        if (_.isEmpty(this.props.text)) {
            return this.props.children;
        }
        
        // Skip the tooltip and return the children, if the mweb.
        if (this.canUseTouchScreen) {
            return this.props.children;
        }
        let child = (

and this change on constructor

....
        this.canUseTouchScreen = canUseTouchScreen();
        this.state = {
            // Is tooltip rendered?
....

[parasharrajat]

Note: There is a regression from this issue's PR #14149.

[JmillsExpensify]

Alright, so time to circle back on the payment. Based on the regression from this PR, no bonus is eligible. Further per our Contributing guidelines, we still need to wait until the 19th, or 7 days after the linked fix reaches production. I'm updating the issue title as a result.

In the meantime, @roryabraham @Santhosh-Sellavel can you handle your portion of the bug zero steps? I'll get a headstart on the regression tests.

[JmillsExpensify]

Also while we are at it, based on the regression, that would mean the following payouts now apply. cc @roryabraham for confirmation given the special considerations discussed above.

• @aneequeahmad reported this issue. $750
• @Santhosh-Sellavel handled PR review, so with the regression that comes out to $500.

Sound right?

[roryabraham]

Sounds right 👍🏼

[JmillsExpensify]

Offers sent to Contributors. In the meantime, @roryabraham @Santhosh-Sellavel can either of you close out your items on the BZ checklist? I'll get the regression test started.

[Santhosh-Sellavel]

I'll think this more like an improvement to the tooltip we can check all off @roryabraham .

[aneequeahmad]

@JmillsExpensify Accepted offer, Thanks for mentioning

[JmillsExpensify]

You're all set!

[JmillsExpensify]

We still need to compensate Santhosh. Keep open until we close that loop.

[JmillsExpensify]

All contributors paid out. I'll close the loop on the regression test today.

[JmillsExpensify]

Sorry ya'll. I'll close the loop on that test. Monday and late last week got away from me.

[JmillsExpensify]

Closed the loop above, so closing this issue.