[HOLD for payment 2023-01-19] Unpin tooltip text is splitting into 2 lines

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app and navigate to chat
2. Press the pin icon in the header of the chat screen
3. Hover over the pin icon again and check the tooltip text

Expected Result:

Unpin text should be in a single line

Actual Result:

Unpin text is splitting in 2 lines

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.51-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

unpin-tooltip-text.mov

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673208539820589

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01757fe35604e7bf17
• Upwork Job ID: 1612617865531674624
• Last Price Increase: 2023-01-10

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[alex-mechler]

@roryabraham possibly related to #12168?

[alex-mechler]

Confirmed its related to that PR by reverting it locally

[alex-mechler]

This appears to be because of a delay in rerendering the Portal's components. If we do not set a text width in updateTooltipTextWidth, but read the ref's offsetWidth, we see that the offsetWidth is correct when it has not been overwritten

[alex-mechler]

Okay, adding a timeout before recalculating the width of the tooltip fixes this, but I think that narrows it down to the Portal component not re-rendering its children fast enough

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01757fe35604e7bf17

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[Julesssss]

Resolved and CP'd, but not deployed to prod. Removing the blocking label.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.52-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Return to createPortal to properly recalculate tooltipTextWidth #14171

If no regressions arise, payment will be issued on 2023-01-19. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia / @alex-mechler] The PR that introduced the bug has been identified. Link to the PR: Dont display tooltips on platforms that dont support hover #12168
• [@thesahindia / @alex-mechler] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Dont display tooltips on platforms that dont support hover #12168 (comment)
• [@thesahindia / @alex-mechler] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1673567182700139
• [@muttmuure] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/257633

[mallenexpensify]

@muttmuure can you issue payment today and also complete the checklist above, thanks

[thesahindia]

Unassigning since I didn't do anything here.

[muttmuure]

This was resolved internally and CP'd to prod, so no payments needed.

Posted buddy check here

[jayeshmangwani]

This was resolved internally and CP'd to prod, so no payments needed.

@muttmuure reporting bonus is due here

[muttmuure]

@jayeshmangwani oh yes, you're correct. I've invited you to apply. Thanks!

[jayeshmangwani]

@muttmuure hey , price should be $250 for reporting bonus and for the job you have invited me to is $1000

[muttmuure]

Should be resolved

[muttmuure]

Please could you accept the offer? Thanks!

[jayeshmangwani]

@muttmuure accepted, Thanks

[muttmuure]

@jayeshmangwani has been paid!

Closing out