[HOLD for payment 2021-12-13] [HOLD for payment 2021-12-06] IOU - "Request $xx" button appears at the top of the page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app and login
2. Click on green Fab button
3. Tap Request Money
4. Select amount and click Next

Expected Result:

"Request $xx" button should appear at the bottom of the page

Actual Result:

"Request $xx" button appears at the top of the page

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.16-1
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

**Expensify/Expensify Issue URL:** **Issue reported by:** Applause **Slack conversation:**

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

It is missed in #4070.
we just need to add flex1 to AnimationStep at

App/src/pages/iou/IOUModal.js

Line 397 in c95c2dd

<AnimatedStep

.

It fixes the issue. submitting a PR to resolve deploy blocker as there is a timezone gap. Feel free to close it if this is not appropriate.

[NikkiWines]

@parasharrajat thanks for submitting a fix. Let me just check how compensation would work for fixing this deploy blocker.

Typically the engineer who introduced the bug should fix it in order to receive full compensation, but it looks like that contributor has been a bit difficult to contact recently.

@Expensify/contributor-management, do we have a set fee for fixing deploy blockers?

[chiragsalian]

Code is now on staging. @kavimuru can you retest and close the issue if its been resolved.

[mallenexpensify]

@Expensify/contributor-management, do we have a set fee for fixing deploy blockers?

Yes, contributors get compensated $250 for fixing deploy blockers. I'm going to auto-assign a CM via the External label then they can create an Upwork job then pay 7 days after there are no regressions

[MelvinBot]

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[dylanexpensify]

On it!

[dylanexpensify]

Internal: https://www.upwork.com/ab/applicants/1463434565061685248/job-details
External: https://www.upwork.com/jobs/~010a9031d77677f005

[MelvinBot]

Triggered auto assignment to @parasharrajat (Exported)

[MelvinBot]

Current assignee @NikkiWines is eligible for the Exported assigner, not assigning anyone new.

[isagoico]

Retest for #6417 (Fix) was a pass! I think we can close this one out 🎉

[isagoico]

Oh wops I think a payment is needed here. Will remove the deploy blocker label and reopen so the payment is tracked here

[MHashamKhan1999]

Greetings,
I've checked out your given link and understand what's the actual problem you're facing, basically, the widgets or the main axis alignment issue or maybe the whole content of the screen is in the same container so another container will be used and your problem will be resolved.. I've extensive experience in developing these applications and I am available to help you out in getting your desired result. I'd like to hop on a call and give you an exact strategy to how to get this handle for your business.

I Will provide you with the complete documentation and the source code for every customization of the application so that you can edit it whenever you want in the future. I have read the job description and find it a perfect match for me as I have 6 years of extensive hands-on experience in Application Development and knowledge about React native and flutter development as well. I have developed a lot of applications and stores using GroovePages/Drupal/React Native/WordPress/Woo-commerce/Shopify/Magneto/PHP/Larvel and would love to help you out as per your requirements.

Here are my current ongoing projects on which I’m working

• https://functionalclinicalaesthetics.com/
• https://feelthemerge.com/
  You can pursue the owner to your own leisure when you have time.

I'd be happier to again cover more detail on call hopefully this is will valuable to you and here are some testimonials from my previous clients who've run e-commerce websites that I've done website dev, and E-commerce plugin integration, etc for

1- ninachristineperfumes.com
2- brickstowall.com
3- addisonkhansolicitors.com
4- arifanis.com
5- ewatchwholesale.com
6- nomadz.co

Looking forward to talking to you.
Thank You,

Best Regards,
Saad khan.

[mallenexpensify]

@dylanexpensify when you create jobs in Upwork, can you be sure to include the GH issue number in the title? It makes it much easier to find/reconcile them.

[mallenexpensify]

@NikkiWines Rajat was auto-assigned to this issue as a Contributor+ via the Exported label. Should he have been assigned to this issue before since he submitted an acceptable proposal to fix the issue?
cc @Beamanator (we're working on C+ flows)

[Beamanator]

I think you're right @mallenexpensify he should have been assigned before adding External, so we would have had the automatic comment that said he was assigned to the job. At this point we should be able to remove & re-add him to get that comment, or just keep it as-is. But it looks like @NikkiWines basically gave him the job here

[NikkiWines]

@mallenexpensify, yeah, he probably should've been assigned.

It was a little unclear to me if I needed to follow the typical triaging process given this was a deploy blocker and had some time urgency associated with it. In this case, Rajat had a fix up super quickly, so I didn't end up going through the standard process (sorry)

[parasharrajat]

Yeah, this was the deploy blocker so we just shorten the process. I think we next issues where my proposal is selected. I should be assign before Exported label is applied.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.16-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix IOU Modal styles. #6417

If no regressions arise, payment will be issued on 2021-12-06. 🎊

[parasharrajat]

Ping for

@dylanexpensify

[mvtglobally]

Issue not reproducible during KI retests. (Second Week)

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.17-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix IOU Modal styles. #6417

If no regressions arise, payment will be issued on 2021-12-13. 🎊

[michaelhaxhiu]

What's the appropriate payout date for this GH supposed to be? cc @NikkiWines for a buddy check perhaps?

[NikkiWines]

Botify seems drunk 😅 I believe 2021-12-06 is the correct date, especially since QA has not been able to reproduce this issue for a couple of weeks now.

[parasharrajat]

Ping for

@dylanexpensify

[dylanexpensify]

Perfect, thanks for clarifying! Paying now!

[dylanexpensify]

@parasharrajat sent offer! Once accepted I'll pay it out now!

[dylanexpensify]

Paid, contract ended, posting closed!